Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i7oSa-0007Hc-Re for pgsql-hackers@arkaria.postgresql.org; Tue, 10 Sep 2019 22:18:05 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1i7oSY-0001KZ-QW for pgsql-hackers@arkaria.postgresql.org; Tue, 10 Sep 2019 22:18:02 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i7oSY-0001Ap-Ad for pgsql-hackers@lists.postgresql.org; Tue, 10 Sep 2019 22:18:02 +0000 Received: from cyclops.postgrespro.ru ([93.174.131.138] helo=mail.postgrespro.ru) by magus.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1i7oSV-0001G8-JA for pgsql-hackers@postgresql.org; Tue, 10 Sep 2019 22:18:01 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.postgrespro.ru (Postfix) with ESMTP id DD25721C3FA0; Wed, 11 Sep 2019 01:17:57 +0300 (MSK) X-Virus-Scanned: Debian amavisd-new at postgrespro.ru X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=x tagged_above=-99 required=4 WHITELISTED tests=[] autolearn=unavailable Received: from [10.100.236.30] (unknown [193.106.43.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mail.postgrespro.ru (Postfix) with ESMTPSA id 751B421C3F9F; Wed, 11 Sep 2019 01:17:57 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mail; t=1568153877; bh=jfWQPw4G0ByN7gfYp2BsfAw17yASOQPZwI6bo4IUoos=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=ebEzW7HnBWosqbYExRsEFXQzVBKysk5jOB3mZi9KaeK7qjofXKVwogV4qRlnSiC26 PiFh/9kYVqIBUxaeXpw3gL/K8RY7daQrNHo3bOYm3l48IW891nPybe//JrjJTrAzd0 okDCuqHRVMFNc3wTp3u/6u3ZramffdsSBBNaYXUU= Subject: Re: [PATCH] Opclass parameters To: Tomas Vondra , "pgsql-hackers@postgresql.org" Cc: Alvaro Herrera , Robert Haas , Tom Lane , Nikolay Shaplov , Oleg Bartunov References: <20190903220254.GA22389@alvherre.pgsql> <20190910220358.6tj37k4v6vyaqac7@development> <20190910221401.ebw6kgsb4ziqtqmg@development> From: Nikita Glukhov Organization: Postgres Professional Message-ID: Date: Wed, 11 Sep 2019 01:15:11 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190910221401.ebw6kgsb4ziqtqmg@development> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 11.09.2019 1:14, Tomas Vondra wrote: > > BTW, is there a place where we actually verify the signature of the > new am > proc? Because I only see code like this: > > +    case OPCLASS_OPTIONS_PROC: > +        ok = true; > +        break; > > in all "validate" functions. See assignProcTypes() at src/backend/commands/opclasscmds.c -- Nikita Glukhov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company