Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k0KRW-0003Fq-Fd for pgsql-hackers@arkaria.postgresql.org; Tue, 28 Jul 2020 07:54:35 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1k0KRU-0004hK-0g for pgsql-hackers@arkaria.postgresql.org; Tue, 28 Jul 2020 07:54:32 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k0KRT-0004hD-MA for pgsql-hackers@lists.postgresql.org; Tue, 28 Jul 2020 07:54:31 +0000 Received: from mail.postgrespro.ru ([93.174.131.139]) by magus.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1k0KRM-0006W3-Fw for pgsql-hackers@postgresql.org; Tue, 28 Jul 2020 07:54:31 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.postgrespro.ru (Postfix) with ESMTP id 1721421C2C07; Tue, 28 Jul 2020 10:54:23 +0300 (MSK) X-Virus-Scanned: Debian amavisd-new at postgrespro.ru X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=x tagged_above=-99 required=4 WHITELISTED tests=[] autolearn=unavailable Received: from mail.postgrespro.ru (unknown [93.174.131.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mail.postgrespro.ru (Postfix) with ESMTPSA id D1AC421C2B4A; Tue, 28 Jul 2020 10:54:22 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mail; t=1595922862; bh=ce8zvZ33tXJsKwIyNGPEixWGOikbcyW7LZ69Y3O194I=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=qOgURLZsC8FLbhUdQX33NTj/s+enp76tuvF6XLfT5v6AEYgn71j+KwyvXvrkSMp+8 erCu+xrQsp1sQPEY02acB+P/c++3ZEoZWzH7zWRh0uRzwc+4Tk0P3CaTnxStNVz6cI Qt8/fYlkc5dP7Yc9hSRnpm8340bErhdFcxNLbNgQ= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Tue, 28 Jul 2020 10:54:22 +0300 From: Alexey Kondratov To: Andrey Lepikhov Cc: Amit Langote , Ashutosh Bapat , Ashutosh Bapat , Etsuro Fujita , PostgreSQL-Dev Subject: Re: [POC] Fast COPY FROM command for the table with foreign partitions In-Reply-To: References: <3d0909dc-3691-a576-208a-90986e55489f@postgrespro.ru> <7a3c3bdd-dc43-68a7-7cc5-ae139f1de4a7@postgrespro.ru> <08721da1dc2da7c0e275593b4f8d9037@postgrespro.ru> User-Agent: Roundcube Webmail/1.4.0 Message-ID: X-Sender: a.kondratov@postgrespro.ru List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2020-07-28 03:33, Andrey Lepikhov wrote: > 27.07.2020 21:34, Alexey Kondratov пишет: >> Hi Andrey, >> >> On 2020-07-23 09:23, Andrey V. Lepikhov wrote: >>> On 7/16/20 2:14 PM, Amit Langote wrote: >>>> Amit Langote >>>> EnterpriseDB: http://www.enterprisedb.com >>>> >>> >>> Version 5 of the patch. With changes caused by Amit's comments. >> >> Just got a segfault with your v5 patch by deleting from a foreign >> table. It seems that ShutdownForeignScan inside node->fdwroutine >> doesn't have a correct pointer to the required function. >> >> I haven't had a chance to look closer on the code, but you can easily >> reproduce this error with the attached script (patched Postgres >> binaries should be available in the PATH). It works well with master >> and fails with your patch applied. > > I used master a3ab7a707d and v5 version of the patch with your script. > No errors found. Can you check your test case? Yes, my bad. I forgot to re-install postgres_fdw extension, only did it for postgres core, sorry for disturb. Regards -- Alexey Kondratov Postgres Professional https://www.postgrespro.com Russian Postgres Company