Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1thwlp-008xvi-15 for pgsql-hackers@arkaria.postgresql.org; Tue, 11 Feb 2025 20:22:13 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1thwln-0006hZ-1m for pgsql-hackers@arkaria.postgresql.org; Tue, 11 Feb 2025 20:22:11 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1thwlm-0006hF-OJ for pgsql-hackers@lists.postgresql.org; Tue, 11 Feb 2025 20:22:11 +0000 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1thwjF-000JVN-14 for pgsql-hackers@lists.postgresql.org; Tue, 11 Feb 2025 20:19:35 +0000 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-439566c991dso5656155e9.3 for ; Tue, 11 Feb 2025 12:19:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739305172; x=1739909972; darn=lists.postgresql.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cEue1z0/zSHItN3QfbhCNsFihuWLFdXnkS8Ju15Ll40=; b=L0Q9Lh9kHt6LRMzTzWCCj3PjsbfTA3T5wadXWSBd85cwHr0BsGU/nIvFl5QHhYcf34 /d1o/Ku9YTKLAxPoWtp9bK3zIz0Rc6gc2NiWXrbLx6dmGCVi0xYjnFa8th9dKcaJ1kXG ST1xc5p8ZzXQE+6rPuJyZ8CaZ9q83VfbLyEx/o+0BoVYifOj58rreMvRDwiXmCxrLdNS UhFBw8NppNCDVkAVAO3k0bgef1jOvfSRcMoVhue2WSUS4mHUiU5TlNCcm/3ascz/Sz5a FvpShMo7Ve7Jg2m+1qKv3yzSehA9HZtOqJs3zHmjnlsDh2ulRSFp+YqGKQjkwHM7n8B7 FM7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739305172; x=1739909972; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cEue1z0/zSHItN3QfbhCNsFihuWLFdXnkS8Ju15Ll40=; b=Lt9xUs59ztsSpWdJgyFbXB/ww7a8JEh1tjdnzDqhLL5Gt9hJQFGjNIlGYRtLL8F3J0 w0MPI6CtT9YDJXq0RJroUfkV0CNNN6qGj/vZxred1TUMlJ21bGZgRHfSOQ2PKfkxwks8 XD5SlX6O2k8LRVDSJ04uR8lW93TPzwoKss5x/x/t3h77cZTVpZaufQDpRr0Yh+8AS4uc XJGuSTgHPqqSTp4240in6Ud+EJxS8YHaSIhGja/J6foN7W6CaF80RVeQgB3wBmBWfllU SlXyPM2i93I+Ju1pPNcpVPqngXwrx8KjA8zH5fsTukw/cVbRCwvmrFs62DNzb7Xgd2Jl S9yQ== X-Forwarded-Encrypted: i=1; AJvYcCVkblbOgStQD6yJLMlUqs/PQCArHUfzEa6hPXtM2UvpoK/qKYZ9UXHM6qm/LqC40UJUQAJL0VwqXlKDbDit@lists.postgresql.org X-Gm-Message-State: AOJu0YycjjboWbAQORznRP5wXB5lCBoaRJ5QHuCTeG8B126J8Jvjo5DI IDUcGTMISDqCFrx3zcgDL/8HC8ToAQr7Q6BJsr7xy5btvW7orsVn X-Gm-Gg: ASbGncu6yxrPztz7KZVHW39LsKBKk6f+1DHNpsalNXi+lB4Oisek1CCEBc2yTDS0/Su 0geMvK6JD2u/UHBDskz6QMVmNVu3aIGqIlYUCyiSZal2UYgsZLXWAP8L5BwZpDpFEUIFyHXJg0N /lcsz3ND9IGmDrS2UXQSJBxunzBi2Kpbpit7I4Qexbpc+XXkc0M8HLES40WNz/Bulusf8tSBu64 SxxmYOzyEhHXCtAuSiLzo3xlq38XFDmmOiwInO4BhtrVg7IjrFHIfTKhxCcXztgqaJbvU+hM8r1 fgjyOCWDPSVR8YgdRh1SAQ8= X-Google-Smtp-Source: AGHT+IG56d5jS9HBGtKaBQWI/xzjnHCKj3z+EFVET7kwgDkSm860OtqxP8oeI58YnNS0ngGvi7V19Q== X-Received: by 2002:a05:600c:3b92:b0:439:574c:bf76 with SMTP id 5b1f17b1804b1-43958173fddmr6484165e9.7.1739305171673; Tue, 11 Feb 2025 12:19:31 -0800 (PST) Received: from [172.20.10.2] ([31.4.241.34]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4390daf44f3sm225464595e9.29.2025.02.11.12.19.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Feb 2025 12:19:31 -0800 (PST) Message-ID: Date: Tue, 11 Feb 2025 21:19:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: explain analyze rows=%.0f To: Robert Haas Cc: Ilia Evdokimov , Matheus Alcantara , Guillaume Lelarge , Daniel Gustafsson , Ibrar Ahmed , "Gregory Stark (as CFM)" , Tom Lane , Amit Kapila , Justin Pryzby , Peter Geoghegan , vignesh C , "David G. Johnston" , pgsql-hackers@lists.postgresql.org References: <55695d15-c738-4401-8883-58bc855c9b03@tantorlabs.com> <58bb3a5b-c92a-408c-b02a-f47aedc1c0e2@tantorlabs.com> <70bc1af0-6910-4f71-84ba-fa02095fe9ba@tantorlabs.com> Content-Language: en-US From: Andrei Lepikhov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 12/2/2025 00:41, Robert Haas wrote: > On Tue, Feb 11, 2025 at 12:14 PM Andrei Lepikhov wrote: >> Moreover, switching to a floating-point type for row explanations in >> each parameterised node would provide a more comprehensive view and add >> valuable information about the parameterisation of the node, which may >> not be immediately apparent. > > I agree strongly with all of this. I believe we should just implement > what was agreed here: > > https://www.postgresql.org/message-id/21013.1243618236%40sss.pgh.pa.us > > Let's just display 2 fractional digits when nloops>1, else 0, and call it good. Why are there only two fractional digits? I reviewed the user reports where we identified issues without sufficient data, based on explains only, and typical examples included loop numbers ranging from 1E5 to 1E7 and tuples from 1E2 to 1E5. Therefore, it may make sense to display fractional digits up to two meaningful (non-zero) digits. -- regards, Andrei Lepikhov