Feedback-ID: i0c21471d:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-332-gdeb4194079-fm-20240319.002-gdeb41940
MIME-Version: 1.0
Message-Id: <f8aa99bd-2a2e-455f-abf9-16ce1c049888@app.fastmail.com>
In-Reply-To: 
 <CAHv8RjKOhZb8boekTNrSS3tUoxq=h_sBHi=zjzV9ndJtvO5fOQ@mail.gmail.com>
References: <9a9c7e65-c47b-4400-a63e-ac6169c0860e@app.fastmail.com>
 <CALDaNm2ev8_r4N5Sfa2GjzuzZNz17L0nsX_ZqfcarmS5oa5Szw@mail.gmail.com>
 <TYCPR01MB12077CD333376B53F9CAE7AC0F5562@TYCPR01MB12077.jpnprd01.prod.outlook.com>
 <e390e35e-508e-4eb8-92e4-e6b066407a41@app.fastmail.com>
 <TYCPR01MB12077121263EFF7680486B635F5212@TYCPR01MB12077.jpnprd01.prod.outlook.com>
 <40595e73-c7e1-463a-b8be-49792e870007@app.fastmail.com>
 <6423dfeb-a729-45d3-b71e-7bf1b3adb0c9@enterprisedb.com>
 <TYCPR01MB12077DE77454D68E959E85E35F5272@TYCPR01MB12077.jpnprd01.prod.outlook.com>
 <e8564096-3c4f-4990-ac7d-ba089739b878@app.fastmail.com>
 <CANhcyEW6-dH28gLbFc5XpDTJ6JPizU+t5g-aKUWJBf5W_Zriqw@mail.gmail.com>
 <2f0b73f3-e7c0-4e95-9712-1993442a6b64@app.fastmail.com>
 <CAA4eK1JtnzqYNQ_S+mj_XsPfgk7szxegKiVQq4-8fY1wUcUnpg@mail.gmail.com>
 <34637e7f-0330-420d-8f45-1d022962d2fe@app.fastmail.com>
 <CALDaNm053p5Drh9+=VvkH0Zf_3xoLB+xw8RsNZjEwhc5xc_W=Q@mail.gmail.com>
 <96a45e74-bd83-422b-bad3-acb52d0ff5f4@eisentraut.org>
 <CALDaNm01cKLMeGYWNGO+YVyB246On=m6BW3-TEbcU+otTT8Wzw@mail.gmail.com>
 <CAHv8RjKOhZb8boekTNrSS3tUoxq=h_sBHi=zjzV9ndJtvO5fOQ@mail.gmail.com>
Date: Thu, 21 Mar 2024 01:59:06 -0300
From: "Euler Taveira" <euler@eulerto.com>
To: "'Shubham Khanna'" <khannashubham1197@gmail.com>,
 "vignesh C" <vignesh21@gmail.com>
Cc: "Peter Eisentraut" <peter@eisentraut.org>,
 "Amit Kapila" <amit.kapila16@gmail.com>,
 "Shlok Kyal" <shlok.kyal.oss@gmail.com>,
 "kuroda.hayato@fujitsu.com" <kuroda.hayato@fujitsu.com>,
 "Tomas Vondra" <tomas.vondra@enterprisedb.com>,
 "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>,
 "Michael Paquier" <michael@paquier.xyz>,
 "Andres Freund" <andres@anarazel.de>,
 "Ashutosh Bapat" <ashutosh.bapat.oss@gmail.com>,
 =?UTF-8?Q?Fabr=C3=ADzio_de_Royes_Mello?= <fabriziomello@gmail.com>
Subject: Re: speed up a logical replica setup
Content-Type: multipart/alternative;
 boundary=e3b5c6bc53eb46c887822a2d0611cb89
Archived-At: <https://www.postgresql.org/message-id/f8aa99bd-2a2e-455f-abf9-16ce1c049888%40app.fastmail.com>
Precedence: bulk

--e3b5c6bc53eb46c887822a2d0611cb89
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 20, 2024, at 7:16 AM, Shubham Khanna wrote:
> On Tue, Mar 19, 2024 at 8:54=E2=80=AFPM vignesh C <vignesh21@gmail.com=
> wrote:
> >
> > If you are not planning to have the checks for name length, this cou=
ld
> > alternatively be fixed by including database id also while querying
> > pg_subscription like below in set_replication_progress function:
> > appendPQExpBuffer(str,
> > "SELECT oid FROM pg_catalog.pg_subscription \n"
> > "WHERE subname =3D '%s' AND subdbid =3D (SELECT oid FROM
> > pg_catalog.pg_database WHERE datname =3D '%s')",
> > dbinfo->subname,
> > dbinfo->dbname);
>=20
> The attached patch has the changes to handle the same.

I included a different query that does the same. See v32.


--
Euler Taveira
EDB   https://www.enterprisedb.com/

--e3b5c6bc53eb46c887822a2d0611cb89
Content-Type: text/html;charset=utf-8
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE html><html><head><title></title><style type=3D"text/css">p.Mso=
Normal,p.MsoNoSpacing{margin:0}</style></head><body><div>On Wed, Mar 20,=
 2024, at 7:16 AM, Shubham Khanna wrote:<br></div><blockquote type=3D"ci=
te" id=3D"qt" style=3D""><div>On Tue, Mar 19, 2024 at 8:54=E2=80=AFPM vi=
gnesh C &lt;<a href=3D"mailto:vignesh21@gmail.com">vignesh21@gmail.com</=
a>&gt; wrote:<br></div><div>&gt;<br></div><div>&gt; If you are not plann=
ing to have the checks for name length, this could<br></div><div>&gt; al=
ternatively be fixed by including database id also while querying<br></d=
iv><div>&gt; pg_subscription like below in set_replication_progress func=
tion:<br></div><div>&gt; appendPQExpBuffer(str,<br></div><div>&gt; "SELE=
CT oid FROM pg_catalog.pg_subscription \n"<br></div><div>&gt; "WHERE sub=
name =3D '%s' AND subdbid =3D (SELECT oid FROM<br></div><div>&gt; pg_cat=
alog.pg_database WHERE datname =3D '%s')",<br></div><div>&gt; dbinfo-&gt=
;subname,<br></div><div>&gt; dbinfo-&gt;dbname);<br></div><div><br></div=
><div>The attached patch has the changes to handle the same.<br></div></=
blockquote><div><br></div><div>I included a different query that does th=
e same. See v32.<br></div><div><br></div><div><br></div><div id=3D"sig11=
2409080"><div class=3D"signature">--<br></div><div class=3D"signature">E=
uler Taveira<br></div><div class=3D"signature">EDB&nbsp;&nbsp; <a href=3D=
"https://www.enterprisedb.com/">https://www.enterprisedb.com/</a><br></d=
iv></div><div><br></div></body></html>
--e3b5c6bc53eb46c887822a2d0611cb89--