Subject: Re: BUG #15212: Default values in partition tables don't work as
 expected and allow NOT NULL violation
References: <20181108193940.2uam7tz6femqrd64@alvherre.pgsql>
From: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Message-ID: <f8d48ff8-9e57-e338-e21d-74dda4eca4dc@lab.ntt.co.jp>
Date: Fri, 9 Nov 2018 14:04:45 +0900
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20181108193940.2uam7tz6femqrd64@alvherre.pgsql>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
To: Alvaro Herrera <alvherre@2ndquadrant.com>,
        Amit Langote <amitlangote09@gmail.com>
Cc: Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
        =?UTF-8?Q?J=c3=bcrgen_Strobel?= <juergen+postgresql@strobel.info>
Precedence: bulk

On 2018/11/09 4:39, Alvaro Herrera wrote:
> Pushed.

Thank you for committing.  I've closed the CF entry.

> I included the test case for collations to the three branches, but no
> code changes.  We can patch master for the handling of collations per
> your patch,

Okay, but should we back-patch it by adding WARNING to back-branches as
you suggest?

> and if somebody has it, a change to how defaults are applied
> when routing tuples.

I haven't written such a patch yet.  Do we want such a feature?

Thanks,
Amit