Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1tI7gw-00CJRk-2Y
	for pgsql-hackers@arkaria.postgresql.org; Mon, 02 Dec 2024 14:46:26 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1tI7gt-000RY1-Di
	for pgsql-hackers@arkaria.postgresql.org; Mon, 02 Dec 2024 14:46:24 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <ilya.evdokimov@tantorlabs.com>)
	id 1tI7gt-000RXt-2q
	for pgsql-hackers@lists.postgresql.org; Mon, 02 Dec 2024 14:46:24 +0000
Received: from forward500a.mail.yandex.net ([178.154.239.80])
	by magus.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <ilya.evdokimov@tantorlabs.com>)
	id 1tI7gr-000fQ9-3J
	for pgsql-hackers@postgresql.org; Mon, 02 Dec 2024 14:46:23 +0000
Received: from mail-nwsmtp-smtp-production-main-17.iva.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-17.iva.yp-c.yandex.net [IPv6:2a02:6b8:c0c:74ac:0:640:7554:0])
	by forward500a.mail.yandex.net (Yandex) with ESMTPS id 3B45F61479;
	Mon,  2 Dec 2024 17:46:20 +0300 (MSK)
Received: by mail-nwsmtp-smtp-production-main-17.iva.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id EkfHo01OquQ0-JdkmEf30;
	Mon, 02 Dec 2024 17:46:18 +0300
X-Yandex-Fwd: 1
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tantorlabs.com;
	s=mail; t=1733150778;
	bh=SbcAbQYlYiIjWAIrvommE8foIEhb4Rb3Nydc2KmlX5Y=;
	h=From:In-Reply-To:Cc:Date:References:To:Subject:Message-ID;
	b=Uxgp27J/E8tblI4Ph+o+F4ztBO4fkAHCB9EM6AEkmGj32p/8TPArm9dMxAjKReGM+
	 l2hVLO4CNshv7UnQ3ofzawjvM0t7Xj+KWsPvfmOowSiXkWNqvlLa4YKgmBXgSR2Fgj
	 9gGhExFREJP3IzROMHQ9XMpnalufKa/zF196r1+I=
Authentication-Results: mail-nwsmtp-smtp-production-main-17.iva.yp-c.yandex.net; dkim=pass header.i=@tantorlabs.com
Message-ID: <f972c2c9-edcc-49b8-9f23-6208eedc3d23@tantorlabs.com>
Date: Mon, 2 Dec 2024 17:46:14 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Vacuum statistics
To: Alena Rybakina <a.rybakina@postgrespro.ru>
Cc: Jim Nasby <jnasby@upgrade.com>, Andrei Zubkov <zubkov@moonset.ru>,
 Masahiko Sawada <sawada.mshk@gmail.com>,
 Melanie Plageman <melanieplageman@gmail.com>,
 jian he <jian.universality@gmail.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>, a.lepikhov@postgrespro.ru,
 Alexander Korotkov <aekorotkov@gmail.com>
References: <bee34abe-fe87-49b3-8523-8ae19e641ccf@yandex.ru>
 <9b10c6d3-52c4-4eef-b67c-c33442667729@postgrespro.ru>
 <CAD21AoAVK7DwTZLfhwuRhTGgR=_ASu5YshEg_Cmpojk5ZdZ3tA@mail.gmail.com>
 <CAAKRu_auu=xt4w3Mm_jW-voJunZgno6XDDohH6hhRc4Z9dGdYQ@mail.gmail.com>
 <CAD21AoD66b3u28n=73kudgMp5wiGiyYUN9LuC9z2ka6YTru5Gw@mail.gmail.com>
 <9485d892-fd04-4e3a-ac24-7dd767cb7333@postgrespro.ru>
 <CAPpHfduwY8-fp34CuO9O57ouCs1K=Gn1rTnuG4AaWYhEo6nXyw@mail.gmail.com>
 <0B6CBF4C-CC2A-4200-9126-CE3A390D938B@upgrade.com>
 <6732acf8ce0f31025b535ae1a64568750924a887.camel@moonset.ru>
 <5AA8FFD5-6DE2-4A31-8E00-AE98F738F5D1@upgrade.com>
 <85b963fe-5977-43aa-9241-75b862abcc69@postgrespro.ru>
 <E0B6D242-C16D-4848-930E-B693D4E5C678@upgrade.com>
 <e2003f94-2075-4183-8298-9d25d8431fb1@postgrespro.ru>
 <9C7A167C-DCDE-4A17-9ABE-6276723FEC50@upgrade.com>
 <2d493cf9-9ba7-4cc1-a3f2-67afd7c163ee@postgrespro.ru>
 <CAPpHfds=woPcB9nPtMmu=g=U9q6-FHFh7fF_x=uhU3k2Oi03sA@mail.gmail.com>
Content-Language: en-US
From: Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>
In-Reply-To: <CAPpHfds=woPcB9nPtMmu=g=U9q6-FHFh7fF_x=uhU3k2Oi03sA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/f972c2c9-edcc-49b8-9f23-6208eedc3d23%40tantorlabs.com>
Precedence: bulk

In my opinion, the patches are semantically correct. However, not all 
dead code has been removed - I'm referring to pgstat_update_snapshot(). 
Also, the tests need to be fixed.

--
Best regards,
Ilia Evdokimov,
Tantor Labs LLC.