public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: Tom Lane <[email protected]>
To: Andres Freund <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: Save a few bytes in pg_attribute
Date: Tue, 21 Mar 2023 17:36:48 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

On 21.03.23 00:51, Tom Lane wrote:
> Andres Freund <[email protected]> writes:
>> On 2023-03-20 10:37:36 -0400, Tom Lane wrote:
>>> I agree that attinhcount could be narrowed, but I have some concern
>>> about attstattarget.  IIRC, the limit on attstattarget was once 1000
>>> and then we raised it to 10000.  Is it inconceivable that we might
>>> want to raise it to 100000 someday?
> 
>> Hard to believe that'd happen in a minor version - and I don't think there'd
>> an issue with widening it again in a major version?
> 
> True.  However, I think Tomas' idea of making these columns nullable
> is even better than narrowing them.

The context of my message was to do the proposed change for PG16 to buy 
back a few bytes that are being added by another feature, and then 
consider doing a larger detangling of pg_attribute and tuple descriptors 
in PG17, which might well involve taking the attstattarget out of the 
hot path.  Making attstattarget nullable (i.e., not part of the fixed 
part of pg_attribute) would require fairly significant surgery, so I 
think it would be better done as part of a more comprehensive change 
that would allow the same treatment for other columns as well.

view thread (8+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Save a few bytes in pg_attribute
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox