Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xBplm-00000003PTk-2s0S for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Sep 2026 08:34:30 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.98.2) (envelope-from ) id 1xBpll-0000000130a-1uir for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Sep 2026 08:34:29 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xBpll-0000000130S-0jPR for pgsql-hackers@lists.postgresql.org; Wed, 30 Sep 2026 08:34:29 +0000 Received: from mail-lr2-x10.google.com ([2a00:1450:4864:38::10]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1xBplj-000000020QT-2XuG for pgsql-hackers@lists.postgresql.org; Wed, 30 Sep 2026 08:34:28 +0000 Received: by mail-lr2-x10.google.com with SMTP id 38308e7fff4ca-3a5919af2eeso40859051fa.3 for ; Wed, 30 Sep 2026 01:34:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790757265; x=1791362065; darn=lists.postgresql.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=LQx9v0hWeJnsDDLwnNtQoupixWFXRvjgdF8XY1n7bjg=; b=kW+dbCMFKKA0ufPvmd8eEEt9NRpjfMSJYnUwvU5Xd9eI7JWnPJZbDyOdC76tcnE9/d X3K4W+V+Hu1Jfopu38pD1eKnXN/3A8kTTYbNOa5Vqd70tFuq8t/jmjTEJfP8TTBphzkH xdcTc3mFKme2LyLuFGWVKNIYVS62I0pTudFcMqKyeyKT9mkwc6Ie33/FREz+AOX6ivr9 EPHZHx8krqcqpU+FpH3S4QkagEO/64QwFStKK8HGh0660ecTfnQzMC87R2CBfepdCoIm LwJ96/Lst/QlknQAyXP3BvngiGCBWntdWVyU/BiFdshmlXW5vbvVLkjuAa3d4y4V9AZZ 4e4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790757265; x=1791362065; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=LQx9v0hWeJnsDDLwnNtQoupixWFXRvjgdF8XY1n7bjg=; b=Purv7jlcClPYxA06aIcwQ1SAFN7jmJP3XQmMON33UhaWjmfuV3WFVhqyB00QJP14vf bhxWD0+mAl/DQW6Edk0GEcEEg+seWy73Lrlz2SPX1tQR+JLSirD7nS/agGyu4omQklAe GoJ28HbBS9P6gQ/ro9NbYD+v5FYYjZjqygtIzfle5+qkn/V0o1sTwe4ZeIXFXU3knAJN W19wYPVJjFzAmeO3WeBbbyV7x+yJ3esY9Mpk3Vc7zr8zWv5MHT/ycoDB21WSeiQGO/k7 +r2tOuwRYD3rJ+r8NsywKDSpycklaog7OMzW3OwrdXtiygbxfeh3hub1oC/EC7dGv84K M9vQ== X-Gm-Message-State: AFq9FYLs5Ee3ZYZK0uTOpuXxWi+4woffDxRuwCAwhIkcd086HW3aFM9j Ua+99SKS0uA16wbWNdVBDWerLwWyGSGxP/pb78m9u3/2xKkXwLaPlADi X-Gm-Gg: AYBFou2yOACpBJtPTEbAfnf+cZxvmOuLXPZ/DsQf0PDkB4BjuaGmbJ0FpewMJbgEeU5 vYb8cIvJ17B/mcGoNJlzfAZHbkPeyS0ofQP/XDs7oj0A2vl+kawIONUvhUxq8Ro4hSTe1U9BJOg n66OSzYoVZ1fk1YvxxQQve/N0hAYl8IjpVY0G5GCsqZy17IxFMIrGXeHUvuha69y+LFO5ZuK4vh IkFzri1WwITntfue0OMNce3NmpHU5loWrdRhuMFrUFgTd18hMxklxBuWTVEI7avb1YbMjejPsQM hdK6IXq07LUChdMq1sd9c62fI8OkPn7GUfMq1LkTEeTLGg+vW4UVidAsJ3c2spFe2ftAQ4zKav1 8A5xDY6A/xhiArxfN7aYk8kvHITf8pSnSdocFGIncGMpsVK2a1ZY51/0MujtbMb6I5JcTewMNe/ aIgxQq5VSZve0dVA76ZwvyicqodtRW1e2hCYdIXM9HE5Le02iPwcX6wlBMY5s6K6U4Jre9+oayx jw3oqpe7JmeyHnHijibwb5CIv8cpKonytiMFOIB+g== X-Received: by 2002:a2e:be28:0:b0:3a6:4a45:df83 with SMTP id 38308e7fff4ca-3a7791843c1mr2473691fa.8.1790757264670; Wed, 30 Sep 2026 01:34:24 -0700 (PDT) Received: from [127.0.0.1] (85-21-144-215.static.corbina.ru. [85.21.144.215]) by smtp.googlemail.com with ESMTPSA id 38308e7fff4ca-3a77d077121sm1172581fa.2.2026.09.30.01.34.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Sep 2026 01:34:24 -0700 (PDT) Message-ID: Date: Wed, 30 Sep 2026 11:34:23 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: ReplicationSlotRelease() clobbers another backend's statusFlags entry To: Michael Paquier , "Hayato Kuroda (Fujitsu)" Cc: PostgreSQL Hackers , Andrey Borodin References: <889a06dd-45fc-423b-9dd2-87d5b5dc60c6@gmail.com> Content-Language: en-US, ru-RU From: Vlad Lesin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 9/30/26 4:21 AM, Michael Paquier wrote: >> Regarding the test, I only used to reproduce the issue but not reviewed well, >> because not sure it's aimed to be included. It may need more polish, i.e., >> advance_wal() has already been defined. > > Regarding this part, I am unconvinced that this is worth the cycles > spent on. I am OK to be proved wrong, but for one the test assumes > that we could crash, which is an anti-pattern with the fix in place > because we don't crash once the status flags are not correctly > filtered. Without the fix, the test fails even without the asserts from the v2-0002 patch. -- Best regards, Vlad