Subject: Re: Re: Tid scan improvements
To: David Rowley <david.rowley@2ndquadrant.com>,
 Edmund Horner <ejrh00@gmail.com>, Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Tomas Vondra
 <tomas.vondra@2ndquadrant.com>,
 PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
References: 
 <CAMyN-kB-nFTkF=VA_JPwFNo08S0d-Yk0F741S2B7LDmYAi8eyA@mail.gmail.com>
 <CAMyN-kCW+D4EpFz-0+LJVOi1Mp3faeJop1wkom+FM_04nRxyXA@mail.gmail.com>
 <20220.1545363076@sss.pgh.pa.us>
 <CAMyN-kAJBX8BNAx--UwruKaN6ctpOz6t+MRmiKRv2pRKy+FTFw@mail.gmail.com>
 <28822.1545411468@sss.pgh.pa.us>
 <CAMyN-kA-cdPN5+W8Nx5tC=pyHpxhXOngO_rQ0+PPzGgf6ZGghw@mail.gmail.com>
 <24929.1547829356@sss.pgh.pa.us>
 <CAMyN-kDaFgpkbYw1dVSvADp4KZisq7oNdaQ1GkyVAqEZ0Xvk=Q@mail.gmail.com>
 <CAMyN-kCnmBq7b-CJ3NVyV1b0A-1SrzwoP1Y=a403iPa1_Vrb+g@mail.gmail.com>
 <CAKJS1f9f+1CEyT3_mv9kN-Le=npqS-0iyZgqPDgCrFYKEAACKA@mail.gmail.com>
 <CAMyN-kC1Eacuk6LAMYH9-M9ddfn6JF1_kJZZedSH8gh7Ljckew@mail.gmail.com>
 <CAKJS1f9Rd1nYmk4AX+EZ09jCzxaYS9dQey3CuM3kKyTwFZjQYg@mail.gmail.com>
 <CAMyN-kCRiXB50Sx_Ftwb9YFQG5Se99eLkzPPbU34qvpTdQa-2w@mail.gmail.com>
 <CAMyN-kAWZHXXmB0KyZoj_Y7HSU+4H4hYNutuTqXiTveQFQueHA@mail.gmail.com>
 <CAKJS1f9DBpoZk5Fhyq5eQu3YfAWo8E7J2zEPSz70J=im8rVngw@mail.gmail.com>
From: David Steele <david@pgmasters.net>
Message-ID: <f9c17014-3269-2fc1-2c77-dd102c42e410@pgmasters.net>
Date: Mon, 25 Mar 2019 12:11:03 +0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0)
 Gecko/20100101 Thunderbird/60.6.0
MIME-Version: 1.0
In-Reply-To: 
 <CAKJS1f9DBpoZk5Fhyq5eQu3YfAWo8E7J2zEPSz70J=im8rVngw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/18/19 1:35 PM, David Rowley wrote:
> On Fri, 15 Mar 2019 at 18:42, Edmund Horner <ejrh00@gmail.com> wrote:
> 
>> Subsequent commits will incrementally abstract table access
>> functionality to be routed through table access methods. That change
>> is too large to be reviewed & committed at once, so it'll be done
>> incrementally.
> 
> and looking at [1] I see patch 0004 introduces some changes in
> nodeTidscan.c to call a new tableam API function named
> heapam_fetch_row_version. I see this function does have a ItemPointer
> argument, so I guess we must be keeping those as unique row
> identifiers in the API.
> 
> Patch 0001 does change the signature of heap_setscanlimits() (appears
> to be committed already), and then in 0010 the only code that calls
> heap_setscanlimits() (IndexBuildHeapRangeScan()) is moved and renamed
> to heapam_index_build_range_scan() and set to be called via the
> index_build_range_scan TableAmRoutine method.  So it looks like out of
> that patch series nothing is there to allow you to access
> heap_setscanlimits() directly via the TableAmRoutine API, so perhaps
> for this to work heap_setscanlimits will need to be interfaced,
> however, I'm unsure if that'll violate any assumptions that Andres
> wants to keep out of the API...  Andres?

Thoughts on this, Andres?

Regards,
-- 
-David
david@pgmasters.net