Message-ID: <f9d90b0b-d57c-4887-968b-31b399d05942@uni-muenster.de>
Date: Thu, 26 Mar 2026 19:12:04 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: COMMENTS are not being copied in CREATE TABLE LIKE
To: Carlos Alves <carlos@alves.inf.br>, pgsql-hackers@lists.postgresql.org
References: <e08cb97f-0364-4002-9cda-3c16b42e4136@uni-muenster.de>
 <CAL-Pge6dUj7gEdd74aPjvxmPkgjMXMF2kp3hDh75eQCPmsBeZQ@mail.gmail.com>
 <177454798496.946.17517925915684610719.pgcf@coridan.postgresql.org>
Content-Language: de-DE, en-GB
From: Jim Jones <jim.jones@uni-muenster.de>
In-Reply-To: 
 <177454798496.946.17517925915684610719.pgcf@coridan.postgresql.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/f9d90b0b-d57c-4887-968b-31b399d05942%40uni-muenster.de>
Precedence: bulk

Hi Carlos

On 26/03/2026 18:59, Carlos Alves wrote:
> No errors or failures were detected during the tests.
> 
> The only suggestion is to keep the parameter description a single paragraph, following the same style as the description of the other inclusion parameters. But the current description is coherent and okay.
> 
> After the tests, the patch is working as expected:
> - Table-level comments are copied when the `including comments` parameter is used.
> - When there is more than one source table, comments, if any, are kept in the order in which they appear in the command, separated by a new line.
> - The performance of command execution was not affected.
> 
> I think only the code review is missing, but I don't have much experience to perform this step.


Thanks for this thorough review. This helps a lot!
Let's see what the other reviewers have to say about the code and your
docs suggestion.

Best, Jim