Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n9FCm-0001xq-7F for pgsql-hackers@arkaria.postgresql.org; Sun, 16 Jan 2022 23:45:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1n9FCk-0002Ip-T2 for pgsql-hackers@arkaria.postgresql.org; Sun, 16 Jan 2022 23:44:58 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n9FCk-0002Ia-8g for pgsql-hackers@lists.postgresql.org; Sun, 16 Jan 2022 23:44:58 +0000 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1n9FCh-0000uK-8h for pgsql-hackers@postgresql.org; Sun, 16 Jan 2022 23:44:56 +0000 Received: by mail-wm1-x331.google.com with SMTP id d187-20020a1c1dc4000000b003474b4b7ebcso18783969wmd.5 for ; Sun, 16 Jan 2022 15:44:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; h=message-id:date:mime-version:user-agent:subject:content-language :from:to:cc:references:in-reply-to:content-transfer-encoding; bh=EOScq1IlwkXLqMQzs3axJcof9zyPUzLUywed2CyBCwA=; b=M0zNCSjulql9meIPw2x7DLIMNdD2vT/BB1lYKAW4hm5lHa5RsrDG9cSStvPVS8ho+A QkE5EozQNaKBwKAgRgEFjRYMOAMU9cSAJkAV6s4ijsq1UTZvnXyh/Q53mJS30c3WniLI aHJxnJK3dnhgaUWzqOEXEkhzCddzBf5tka73agFvSPTm0wS63nsYYnh2HzVpaLqtTLgJ QQKqDi2veXIx6JqbnEnKtOhH4vLqL9bN1ongaPdZS62isfNts655APNI3gdMNN7eZkMZ nxwt9OZ/dxanfXOkTjkAFy0qiSZ4RbQNAbV5+2yeLHRcGIc3on+BZYQ+Swn5zljVYhxa iEeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=EOScq1IlwkXLqMQzs3axJcof9zyPUzLUywed2CyBCwA=; b=xt9H2IBaKKoL/7mGJw77BcMv4uFrbTtShBcnklERsK7EYCHElIfuAxH4Id8kQFyhL+ KbaDGpolecmptvp8eOs+GePRmaleowHGHDWpc/2i2+u6xo2+zD51j4ox397HF5oVmoOi dS5K4Gpx6/B43wSAN7HHdixyZWOOl1lhavOG8H8ObNs0JIN4aqK5h6ztuyelmlc8t/hT 27RYk34sKI4xnECWYjjiQGn7HPPItgHA6rw8EAreEc9jHxhWzJqnfWc/+JbVB88pYhRE 6TfsiS1RTRdTYZaE8Bh6hqcrx9e8HpnV0lAQMNneriX/yG4txE+huXq3mdXToMtSh+BG YelA== X-Gm-Message-State: AOAM532+ReYXMy4GdG4tkJ7JRHJkzQP/41TIF/YE4rCIi6IIrPHEJbhv 4/jZ/rCkhMv4LSYPAmCQxV6+kdKor/HUCVKxmckn6X2Q4b1DTxbQoEblvwuFSZuyOEydkQINuRz kKRLDaP7p5bHWIbMRmPTptUBv4tBaihP7zkXILUHIwqS8iip4CSkW2mIWCTB+QEYeOywNIGA+24 GCtml3peiaNOVl9r9/IKfeRa/xf/IfMw5o8Gq8 X-Google-Smtp-Source: ABdhPJxKx1YnXVtKSML1Iz0ktrKhKSHvnNy5p2QTL+3GYuqRsYGu5p7CcvEyb9SKCI8wZuJdX7MOwQ== X-Received: by 2002:adf:f6cb:: with SMTP id y11mr12330789wrp.419.1642376692798; Sun, 16 Jan 2022 15:44:52 -0800 (PST) Received: from [10.137.0.18] (ip-86-49-251-241.net.upcbroadband.cz. [86.49.251.241]) by smtp.gmail.com with ESMTPSA id t19sm1096060wmq.42.2022.01.16.15.44.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 16 Jan 2022 15:44:52 -0800 (PST) Message-ID: Date: Mon, 17 Jan 2022 00:44:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: extended stats on partitioned tables Content-Language: en-US From: Tomas Vondra To: Justin Pryzby Cc: Zhihong Yu , Jaime Casanova , pgsql-hackers@postgresql.org References: <46f37069-55cb-db6a-a15a-e351a2606592@enterprisedb.com> <20211103231904.GP17618@telsasoft.com> <689accb1-76e8-5115-6ed0-336749cdca57@enterprisedb.com> <20211203052411.GU17618@telsasoft.com> <8052505e-2dd2-e8cb-26c9-cbb5dff7d750@enterprisedb.com> <20211212213210.GP17618@telsasoft.com> <20211213135348.GT17618@telsasoft.com> <20220115051138.GR14051@telsasoft.com> <929bd70f-cfc9-6b8e-e827-53555b6d77fe@enterprisedb.com> In-Reply-To: <929bd70f-cfc9-6b8e-e827-53555b6d77fe@enterprisedb.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk I've pushed the part adding stxdinherit flag to the catalog, so that on master we build statistics both with and without data from the child relations. I'm not going to push the ACL refactoring. We have similar code on various other places (not addressed by the proposed patch), and it'd make backpatching harder. So I'm not sure it'd be an improvement. In any case, I'm going to mark this as committed. Justin, if you think we should reconsider the ACL refactoring, please submit it as a separate patch. It seems mostly unrelated to the issue this thread was about. regards -- Tomas Vondra EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company