public inbox for [email protected]
help / color / mirror / Atom feedFrom: Madyshev Egor <[email protected]>
To: Boris Mironov <[email protected]>
To: [email protected] <[email protected]>
Subject: RE: Idea to enhance pgbench by more modes to generate data (multi-TXNs, UNNEST, COPY BINARY)
Date: Mon, 2 Mar 2026 14:12:09 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <PH0PR08MB702074674145021B680D9D6C8871A@PH0PR08MB7020.namprd08.prod.outlook.com>
References: <DS0PR08MB9565D91414C65B3AC363825488CFA@DS0PR08MB9565.namprd08.prod.outlook.com>
<CAExHW5vtdtd5QnFobxOhbVeh5jk3_61zYRxLqCXEZpO3jOeFDg@mail.gmail.com>
<DS0PR08MB9565C0B8B45F7B8D78D89EA188CAA@DS0PR08MB9565.namprd08.prod.outlook.com>
<CAExHW5umH2K5w_5GRCWGrRHfceMjVn72hF=z_A7G+vReryx0uw@mail.gmail.com>
<DS0PR08MB956560D79EA051E98688F78088CAA@DS0PR08MB9565.namprd08.prod.outlook.com>
<CAExHW5vFMkBfv9zB3c5gxF=VLkR7dxM2a3pSFsNuz4JYqc8wRA@mail.gmail.com>
<PH0PR08MB7020CE2AE1B6937BD01B852F88C9A@PH0PR08MB7020.namprd08.prod.outlook.com>
<PH0PR08MB702059D610C7D84594CD3BB388D5A@PH0PR08MB7020.namprd08.prod.outlook.com>
<PH0PR08MB70201EC778A20A2BDC8A5F4A88D2A@PH0PR08MB7020.namprd08.prod.outlook.com>
<PH0PR08MB7020802F14B1AC122AAB6F7588D3A@PH0PR08MB7020.namprd08.prod.outlook.com>
<PH0PR08MB702075EB12438C2F9A32CD26889EA@PH0PR08MB7020.namprd08.prod.outlook.com>
<PH0PR08MB70205C9C827602026F60FA07889FA@PH0PR08MB7020.namprd08.prod.outlook.com>
<[email protected]>
<PH0PR08MB70206B42F5A79A518B610815889FA@PH0PR08MB7020.namprd08.prod.outlook.com>
<PH0PR08MB70204888D724794BA83EA6E58866A@PH0PR08MB7020.namprd08.prod.outlook.com>
<PH0PR08MB70207B96C493E5777DB4D6428866A@PH0PR08MB7020.namprd08.prod.outlook.com>
<[email protected]>
<PH0PR08MB70208182284EBA18F64228798877A@PH0PR08MB7020.namprd08.prod.outlook.com>
<PH0PR08MB702074674145021B680D9D6C8871A@PH0PR08MB7020.namprd08.prod.outlook.com>
Hi Boris,
I have reviewed the new patch. Overall, it looks correct,
but I have a few minor questions.
1. What do you think about moving characters in 'detail: Allowed step
characters are: "dtgMScGUvpf"' so that generation modes and
transactions count modes are not mixed? For example "dtMSgcGUvpf".
2. In the initCreateTables function, default values are set as empty
strings '' in the pgbench_history and pgbench_accounts tables. Was
this done intentionally, and if so, what is the reason? In the
pgbench_tellers and pgbench_branches tables, the implicit default
would be NULL - why was this logic changed?
3. In showPopulateTableCopyProgress, I think it would be better to
calculate elapsed_sec and remaining_sec inside the condition blocks,
as is done in the original code.
4. Do the changes and bug fixes in the patch affect performance? Are
the existing performance measurements still valid?
Best regards,
Egor
view thread (21+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: RE: Idea to enhance pgbench by more modes to generate data (multi-TXNs, UNNEST, COPY BINARY)
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox