Feedback-ID: i0c21471d:Fastmail
User-Agent: Cyrus-JMAP/3.7.0-alpha0-713-g1f035dc716-fm-20220617.001-g1f035dc7
Mime-Version: 1.0
Message-Id: <fa0d60e1-87af-4b55-9385-c8ff4be1b836@www.fastmail.com>
In-Reply-To: <29bd8c6e-9c87-4a72-abea-52218a387e2e@www.fastmail.com>
References: 
 <CAB-JLwYOYwL=XTyAXKiH5CtM_Vm8KjKh7aaitCKvmCh4rzr5pQ@mail.gmail.com>
 <CAA4eK1JW+_Pff3TOaBqbOqn-LbMT2kj2bpw-a88ZSTdbTZ-aMg@mail.gmail.com>
 <CAB-JLwas_=FGr8bXKD7K6g0=RDUFuYU71TLLGTsQ-DTRNpq1QQ@mail.gmail.com>
 <CAA4eK1KSBGrLKR63iS38Bkvjq6fBCWzbuD6R15kEWdmd8aj3mw@mail.gmail.com>
 <73b06a32-56ab-4056-86ff-e307f3c316f1@www.fastmail.com>
 <f026292b-c9ee-472e-beaa-d32c5c3a2ced@www.fastmail.com>
 <d192bc58-e9c7-442c-bae8-63f8e8f43fda@www.fastmail.com>
 <20220322010410.m6ccotflls45d7vq@alap3.anarazel.de>
 <aec5dd79-245c-454e-ae28-00ba3c8977ed@www.fastmail.com>
 <29bd8c6e-9c87-4a72-abea-52218a387e2e@www.fastmail.com>
Date: Mon, 04 Jul 2022 14:41:26 -0300
From: "Euler Taveira" <euler@eulerto.com>
To: "Andres Freund" <andres@anarazel.de>
Cc: "Amit Kapila" <amit.kapila16@gmail.com>,
 "Marcos Pegoraro" <marcos@f10.com.br>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: logical replication restrictions
Content-Type: multipart/mixed;
 boundary=c32aa70069d4430ca8f4f3f76887eb41
Archived-At: 
 <https://www.postgresql.org/message-id/fa0d60e1-87af-4b55-9385-c8ff4be1b836%40www.fastmail.com>
Precedence: bulk

--c32aa70069d4430ca8f4f3f76887eb41
Content-Type: multipart/alternative;
 boundary=7f6f2bddf9c5494aa231d2710aa7ffa9

--7f6f2bddf9c5494aa231d2710aa7ffa9
Content-Type: text/plain

On Wed, Mar 23, 2022, at 6:19 PM, Euler Taveira wrote:
> On Mon, Mar 21, 2022, at 10:09 PM, Euler Taveira wrote:
>> On Mon, Mar 21, 2022, at 10:04 PM, Andres Freund wrote:
>>> On 2022-03-20 21:40:40 -0300, Euler Taveira wrote:
>>> > On Mon, Feb 28, 2022, at 9:18 PM, Euler Taveira wrote:
>>> > > Long time, no patch. Here it is. I will provide documentation in the next
>>> > > version. I would appreciate some feedback.
>>> > This patch is broken since commit 705e20f8550c0e8e47c0b6b20b5f5ffd6ffd9e33. I
>>> > rebased it.
>>> 
>>> This fails tests, specifically it seems psql crashes:
>>> https://cirrus-ci.com/task/6592281292570624?logs=cores#L46
>> Yeah. I forgot to test this patch with cassert before sending it. :( I didn't
>> send a new patch because there is another issue (with int128) that I'm
>> currently reworking. I'll send another patch soon.
> Here is another version after rebasing it. In this version I fixed the psql
> issue and rewrote interval_to_ms function.