Subject: Re: More time spending with "delete pending"
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>, Tom Lane
 <tgl@sss.pgh.pa.us>, Justin Pryzby <pryzby@telsasoft.com>
References: <20729794-e2bf-bd7a-f01b-d132f89fd0d7@gmail.com>
 <fcc8aea0-14d2-9fab-1a4e-37fd1925c49b@gmail.com>
 <YOQVX1f9/2s1ct6W@paquier.xyz>
 <78fa6a17-8e71-7c99-62bd-8a11a47fe894@gmail.com>
 <YOatgGjMgnEFsnGL@paquier.xyz>
 <d030cc87-641c-c2f0-b7a9-4d6669ea91d7@gmail.com>
 <YOfkMRNtMjyDLnLL@paquier.xyz>
 <2aa7ce7a-d73a-fa36-4fb5-3affe1860c58@gmail.com>
 <YOu/9Zc/LuL1Lscu@paquier.xyz> <YOvOlfRrIO0yGtgw@paquier.xyz>
 <YOvYnj2pB/EB2l8A@paquier.xyz>
From: Alexander Lakhin <exclusion@gmail.com>
Message-ID: <fa17e7c7-1a8a-e2b2-0a79-7b52a2d2bd2d@gmail.com>
Date: Mon, 12 Jul 2021 09:06:01 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <YOvYnj2pB/EB2l8A@paquier.xyz>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Content-Language: ru-RU
Archived-At: 
 <https://www.postgresql.org/message-id/fa17e7c7-1a8a-e2b2-0a79-7b52a2d2bd2d%40gmail.com>
Precedence: bulk

Hello Michael,
12.07.2021 08:52, Michael Paquier wrote:
> On Mon, Jul 12, 2021 at 02:09:41PM +0900, Michael Paquier wrote:
>> And fairywren, that uses MinGW, is unhappy:
>> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=fairywren&dt=2021-07-12%2004%3A47%3A13
>> Looking at it now.
> I am not sure what to do here to cool down MinGW, so the patch has
> been reverted for now:
> - Plain stat() is not enough to do a proper detection of the files
> pending for deletion on MSVC, so reverting only the part with
> microsoft_native_stat() is not going to help.
> - We are going to need an evaluation of the stat() implementation in
> MinGW and check if is it possible to rely on it more.  If yes, we
> could get away with more tweaks based on __MINGW32__/__MINGW64__.
I'll take care of it and will prepare mingw-compatible patch tomorrow.

Best regards,
Alexander