Message-ID: <fa3bef59-2202-a61d-c4d9-72e419bfe5f3@pgmasters.net>
Date: Tue, 26 Sep 2023 16:19:12 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.15.1
Subject: Re: Add const qualifiers
To: Peter Eisentraut <peter@eisentraut.org>,
 Pg Hackers <pgsql-hackers@postgresql.org>
References: <669a035c-d23d-2f38-7ff0-0cb93e01d610@pgmasters.net>
 <d2d18bf3-0600-0b3a-6189-069f681a4449@pgmasters.net>
 <96cb71e3-13d3-543e-fe3d-9c7034fc6574@eisentraut.org>
Content-Language: en-US
From: David Steele <david@pgmasters.net>
In-Reply-To: <96cb71e3-13d3-543e-fe3d-9c7034fc6574@eisentraut.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/fa3bef59-2202-a61d-c4d9-72e419bfe5f3%40pgmasters.net>
Precedence: bulk

On 9/26/23 06:34, Peter Eisentraut wrote:
> On 09.09.23 21:03, David Steele wrote:
>> On 9/1/23 11:39, David Steele wrote:
>>> Hackers,
>>>
>>> I noticed that there was a mismatch between the const qualifiers for 
>>> excludeDirContents in src/backend/backup/backup/basebackup.c and 
>>> src/bin/pg_rewind/file_map.c and that led me to use ^static 
>>> const.*\*.*= to do a quick search for similar cases.
>>>
>>> I think at the least we should make excludeDirContents match, but the 
>>> rest of the changes seem like a good idea as well.
>>
>> Added to 2023-11 CF.
> 
> committed

Thank you, Peter!