public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: Jeevan Chalke <[email protected]>
To: Andrew Dunstan <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: More new SQL/JSON item methods
Date: Wed, 3 Jan 2024 22:04:52 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <CAM2+6=XjTyqrrqHAOj80r0wVQxJSxc0iyib9bPC55uFO9VKatg@mail.gmail.com>
	<[email protected]>
	<CAM2+6=XTW1COd+56ekjP=CUceZyrgyrcBge_z0ZRkCgVwcGHQg@mail.gmail.com>
	<[email protected]>
	<CAM2+6=UCSp74devvHYpMx5NvpyWbCO3gYvgpEYHtNYqF2j6Z9Q@mail.gmail.com>
	<[email protected]>
	<CAM2+6=UrDfcsz0xn+oUmomOnPYazuP8dAM_Wrx5YMsWxXjWyKA@mail.gmail.com>
	<[email protected]>
	<CAM2+6=UMCtXVSk1NmGHzsYYY6xGdnaMMKxVaKUtG7o0jkiuyQg@mail.gmail.com>
	<[email protected]>

On 03.01.24 13:01, Peter Eisentraut wrote:
> On 07.12.23 14:24, Jeevan Chalke wrote:
>> We have the same issue with integer conversion and need a fix.
>>
>> Unfortunately, I was using int8in() for the conversion of numeric 
>> values. We should be using numeric_int8() instead. However, there is 
>> no opt_error version of the same.
>>
>> So, I have introduced a numeric_int8_opt_error() version just like we 
>> have one for int4, i.e. numeric_int4_opt_error(), to suppress the 
>> error. These changes are in the 0001 patch. (All other patch numbers 
>> are now increased by 1)
>>
>> I have used this new function to fix this reported issue and used 
>> numeric_int4_opt_error() for integer conversion.
> 
> I have committed the 0001 and 0002 patches for now.
> 
> The remaining patches look reasonable to me, but I haven't reviewed them 
> in detail.

The 0002 patch had to be reverted, because we can't change the order of 
the enum values in JsonPathItemType.  I have instead committed a 
different patch that adjusts the various switch cases to observe the 
current order of the enum.  That also means that the remaining patches 
that add new item methods need to add the new enum values at the end and 
adjust the rest of their code accordingly.

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: More new SQL/JSON item methods
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox