Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hpQQk-00047L-FA for pgsql-hackers@arkaria.postgresql.org; Mon, 22 Jul 2019 05:00:10 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hpQQi-0005oM-R9 for pgsql-hackers@arkaria.postgresql.org; Mon, 22 Jul 2019 05:00:08 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hpQQi-0005lL-DM for pgsql-hackers@lists.postgresql.org; Mon, 22 Jul 2019 05:00:08 +0000 Received: from mail-lj1-x244.google.com ([2a00:1450:4864:20::244]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hpQQf-0003Bb-TV for pgsql-hackers@postgresql.org; Mon, 22 Jul 2019 05:00:07 +0000 Received: by mail-lj1-x244.google.com with SMTP id x25so36245831ljh.2 for ; Sun, 21 Jul 2019 22:00:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language; bh=AVOGnGR2fwHQXfS0rYNKKDfcXFyLtqjK9t3YWgW8Qr0=; b=TR9AsurN6ne3oc8YCc8VI/kZeqRZLmZBMGtVJ3p9lZvf3TlbwUMTzYC8MfBN7YzBKn 8MdBYwwkiPrAD3b8pL3iI6N4RkoEysMfbECWhmKs/Y5yapjXgOhB3OURLeEvQ8cVmsxE 3CrM1Ffrg+pRKLlcqzw7eAkn3wmPzAJiUqd1e8gAUAQeVAjlLeIshiFphvUJeiRT7WYw 7PRNI75nCSq/OR1Fii8qB+c2ucuezVAJljF7vTSeQy+9/82rzVcI+gSAfCyH8ohaILMW vdbdV3Z3qun8tylT/Q1LrYcY8MZCPurP/xwPDTNYR1wlIs19r3ZZTFfxdoMGRUv/Jwud Q7qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=AVOGnGR2fwHQXfS0rYNKKDfcXFyLtqjK9t3YWgW8Qr0=; b=ECGVkjJ3F8l0lwfkNPrlLdKJJxTweDgcW3kWMV/qpnFENsYgcuBecPQJyEhEjPaKkf y1aQJB0uPQjRcKiWTAtrLb37rhIiqSVjrU9BknIdpRZSfP5KT+LCLwFCuMhOwmS4g5FW X03KchulVeaDIfunfdgnUu28IWI3+8/47sCvY8Tn0L5pbnfsG7uEQMddE2ZJf2jEtCPL QbgmI17eC7DkN2viW+MmbJwVv6eryrn3/+Zl+lH5PswU2XgjnuADW2AVuDIfvUk5G/Ze zgmpho7aNpcGYEeA/IRZWsbUvH8x94juxrLC73lR/Fwy7amhB8VWh0dOaexdktv6pMqG UdYA== X-Gm-Message-State: APjAAAUyEQvripuBQkdO5Ox4wxQ0/Um8Sti2zeoDJI0FDMMwqMmOaVwq 9W9zvOaZOgdJ7hh6dt2MNth4iA2L X-Google-Smtp-Source: APXvYqyJKHuDa3u5YV745jTMFgd5Q/1oFEiywI6Fr5UmhX3GHYQOCITaxa2ezTTaNLEAAWcYnttbvA== X-Received: by 2002:a2e:8e90:: with SMTP id z16mr13276754ljk.4.1563771602632; Sun, 21 Jul 2019 22:00:02 -0700 (PDT) Received: from [1.0.0.7] ([178.155.4.119]) by smtp.gmail.com with ESMTPSA id n24sm7385263ljc.25.2019.07.21.22.00.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 21 Jul 2019 22:00:02 -0700 (PDT) Subject: Re: Fix typos and inconsistencies for HEAD (take 7) To: Tom Lane , Michael Paquier Cc: pgsql-hackers@postgresql.org References: <20190722010543.GB1757@paquier.xyz> <28139.1563768879@sss.pgh.pa.us> From: Alexander Lakhin Message-ID: Date: Mon, 22 Jul 2019 08:00:00 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <28139.1563768879@sss.pgh.pa.us> Content-Type: multipart/alternative; boundary="------------DEAE41C3D7AA538074018D8C" Content-Language: en-US List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk This is a multi-part message in MIME format. --------------DEAE41C3D7AA538074018D8C Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Hello Tom, 22.07.2019 7:14, Tom Lane wrote: >> Fixing both places sounds adapted to me. An alternative we could use >> here is just to say something like that: >> The effective resolution is only 1/HZ, which can be configured with >> kernel parameter (see man 7 time), and is 4 milliseconds by >> default. > Whatever we say here is going to be a lie on some platforms. > > Probably best just to say that the sleep resolution is platform-dependent > and leave it at that. I think, we can say "on many systems"/ "on most Unixen", and it would not be a lie. In my opinion, while a generic reference to platform-dependency is OK for developer' documentation, it makes the following passage in config.sgml vague (we don't give user a hint, what "the effective resolution" can be - several seconds/milliseconds/nanoseconds?): /The default value is 200 milliseconds (200ms). Note that on many systems, the// //effective resolution of sleep delays is 10 milliseconds; setting// //bgwriter_delay to a value that is not a multiple of 10// //might have the same results as setting it to the next higher multiple of 10. / -> /The default value is 200 milliseconds (200ms). Note that the// //effective resolution of sleep delays is paltform-dependent. setting// //bgwriter_delay to a value that is not a multiple of the effective resolution,/ /might have the same results as setting it to the next higher multiple./ Best regards, Alexander --------------DEAE41C3D7AA538074018D8C Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit
Hello Tom,
22.07.2019 7:14, Tom Lane wrote:
Fixing both places sounds adapted to me.  An alternative we could use
here is just to say something like that:
The effective resolution is only 1/HZ, which can be configured with
kernel parameter (see man 7 time), and is 4 milliseconds by
default.
Whatever we say here is going to be a lie on some platforms.

Probably best just to say that the sleep resolution is platform-dependent
and leave it at that.
I think, we can say "on many systems"/ "on most Unixen", and it would not be a lie.
In my opinion, while a generic reference to platform-dependency is OK for developer' documentation, it makes the following passage in config.sgml vague (we don't give user a hint, what "the effective resolution" can be - several seconds/milliseconds/nanoseconds?):
The default value is 200 milliseconds (<literal>200ms</literal>). Note that on many systems, the
effective resolution of sleep delays is 10 milliseconds; setting
<varname>bgwriter_delay</varname> to a value that is not a multiple of 10
might have the same results as setting it to the next higher multiple of 10.
->
The default value is 200 milliseconds (<literal>200ms</literal>). Note that the
effective resolution of sleep delays is paltform-dependent. setting
<varname>bgwriter_delay</varname> to a value that is not a multiple of the effective resolution,
might have the same results as setting it to the next higher multiple.

Best regards,
Alexander
--------------DEAE41C3D7AA538074018D8C--