Feedback-ID: ie0a040ee:Fastmail
Message-ID: <fb505187-907c-4925-9b0a-6391f212dabb@eisentraut.org>
Date: Wed, 21 Jan 2026 15:19:17 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: AIX support
To: Srirama Kucherlapati <sriram.rk@in.ibm.com>
Cc: AIX PG user <postgres-ibm-aix@wwpdl.vnet.ibm.com>,
 Heikki Linnakangas <hlinnaka@iki.fi>, Tristan Partin <tristan@partin.io>,
 "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
References: <CY5PR11MB63928CC05906F27FB10D74D0FD322@CY5PR11MB6392.namprd11.prod.outlook.com>
 <794e9968-c48f-4ec3-a5f9-a7e8faca8979@eisentraut.org>
 <176279401378.2081919.12877701948713975661.pgcf@coridan.postgresql.org>
 <SJ4PPFB817783263EA0FD91EBC346308C51DBA3A@SJ4PPFB81778326.namprd15.prod.outlook.com>
 <c4a5fcf5-fd41-4548-a18a-c05761979c9a@eisentraut.org>
 <SJ4PPFB817783267BD66F22BFC328D93F81DBA8A@SJ4PPFB81778326.namprd15.prod.outlook.com>
 <DF3QX1B91OKO.182K0IH9QDQUY@partin.io>
 <SJ4PPFB8177832684055FA99E25A710A09BDBB2A@SJ4PPFB81778326.namprd15.prod.outlook.com>
 <SJ4PPFB817783265975DE0984EE26A94891DBBBA@SJ4PPFB81778326.namprd15.prod.outlook.com>
 <SJ4PPFB817783261597674B9814FE523944DB8EA@SJ4PPFB81778326.namprd15.prod.outlook.com>
 <61d9ecc8-da4e-487a-9774-838b044cda4d@eisentraut.org>
 <SJ4PPFB8177832645802E05CC9DD299E792DB8CA@SJ4PPFB81778326.namprd15.prod.outlook.com>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <SJ4PPFB8177832645802E05CC9DD299E792DB8CA@SJ4PPFB81778326.namprd15.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/fb505187-907c-4925-9b0a-6391f212dabb%40eisentraut.org>
Precedence: bulk

On 15.01.26 06:51, Srirama Kucherlapati wrote:
>> This patch appears to be incomplete.  It references a file mkldexport.sh
>> but that file does not exist and is not included in the patch.
> 
> The initial patch contained only Meson-specific changes addressing the 
> comments provided regarding Meson in this discussion.
> https://www.postgresql.org/message-id/ 
> DF3QX1B91OKO.182K0IH9QDQUY%40partin.io <https://www.postgresql.org/ 
> message-id/DF3QX1B91OKO.182K0IH9QDQUY%40partin.io>
> 
> As requested, I have now included the mkldexport.sh changes in the 
> attached file. We want to initially close all the meson review comments.
> 
> Please review the changes and let me know your thoughts or if any 
> further adjustments are needed.

I took this idea of disabling static libraries in meson and made it a 
separate patch; see [0].  It looks like this patch is getting close to 
consensus, so we could commit it soon.  Then you could rebase your patch 
over it, which would make it quite a bit simpler.

I think in general, the meson changes are ok.  But I needed some 
changes, for example, your patch contains

+if not dep_static_lib.disabled()

but the method .disabled() doesn't exist, it should be .found().  So I'm 
wondering how this patch was tested.

Another patch of interest to you could be [1], which moves the 
MAXIMUM_ALIGNOF computation into c.h.  This should also simplify your 
patch.  But that patch has not received any discussion so far.

In any case, you should post complete patch series.  It's ok to split 
changes into multiple patches, and then recommend which parts you want 
reviewed first.  But we need to see at least a rough outline of the 
complete plan before spending significant effort on reviewing the pieces.


[0]: 
https://www.postgresql.org/message-id/e8aa97db-872b-4087-b073-f296baae948d%40eisentraut.org

[1]: 
https://www.postgresql.org/message-id/58cedbc7-5658-468d-868e-a4d06de04ca6%40eisentraut.org