Message-ID: <fb552452-d61f-403b-85c1-187ea7f030af@oss.nttdata.com>
Date: Wed, 2 Apr 2025 02:35:35 +0900
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Extend ALTER DEFAULT PRIVILEGES for large objects
To: Yugo NAGATA <nagata@sraoss.co.jp>, Laurenz Albe <laurenz.albe@cybertec.at>
Cc: Nathan Bossart <nathandbossart@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
 pgsql-hackers@postgresql.org
References: <20240424115242.236b499b2bed5b7a27f7a418@sraoss.co.jp>
 <3602391.1713930458@sss.pgh.pa.us> <20240424210839.GA863220@nathanxps13>
 <20240426175406.13e47ea3904de814afbfe496@sraoss.co.jp>
 <20240913161801.b1e60534d77fa9df447b775f@sraoss.co.jp>
 <9c0c4d7881d2450baf70edb0ae95415a81ac8cb1.camel@cybertec.at>
 <20250123192220.9bad2b9aec110bf335521276@sraoss.co.jp>
Content-Language: en-US
From: Fujii Masao <masao.fujii@oss.nttdata.com>
In-Reply-To: <20250123192220.9bad2b9aec110bf335521276@sraoss.co.jp>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/fb552452-d61f-403b-85c1-187ea7f030af%40oss.nttdata.com>
Precedence: bulk


On 2025/01/23 19:22, Yugo NAGATA wrote:
> On Wed, 22 Jan 2025 13:30:17 +0100
> Laurenz Albe <laurenz.albe@cybertec.at> wrote:
> 
>> On Fri, 2024-09-13 at 16:18 +0900, Yugo Nagata wrote:
>>> I've attached a updated patch. The test is rewritten using has_largeobject_privilege()
>>> function instead of calling loread & lowrite, which makes the test a bit simpler.
>>> Thare are no other changes.
>>
>> When I tried to apply this patch, I found that it doesn't apply any
>> more since commit f391d9dc93 renamed tab-complete.c to tab-complete.in.c.
>>
>> Attached is a rebased patch.
> 
> Thank you for updating the patch!
> 
>> I agree that large objects are a feature that should fade out (alas,
>> the JDBC driver still uses it for BLOBs).  But this patch is not big
>> or complicated and is unlikely to create a big maintenance burden.
>>
>> So I am somewhat for committing it.  It works as advertised.
>> If you are fine with my rebased patch, I can mark it as "ready for
>> committer".  If it actually gets committed depends on whether there
>> is a committer who thinks it worth the effort or not.
> 
> I confirmed the patch and I am fine with it.

I've started reviewing this patch since it's marked as "ready for committer".

I know of several systems that use large objects, and I believe
this feature would be beneficial for them. Overall, I like the idea.


The latest patch looks good to me. I just have one minor comment:

>   only the privileges for schemas, tables (including views and foreign
>   tables), sequences, functions, and types (including domains) can be
>   altered.

In alter_default_privileges.sgml, this part should also mention large objects?

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION