Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n66C3-0001TH-Ua for pgsql-hackers@arkaria.postgresql.org; Sat, 08 Jan 2022 07:31:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1n66C1-0005VJ-Ml for pgsql-hackers@arkaria.postgresql.org; Sat, 08 Jan 2022 07:31:13 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n66C1-0005VA-AF for pgsql-hackers@lists.postgresql.org; Sat, 08 Jan 2022 07:31:13 +0000 Received: from mail-pj1-x1033.google.com ([2607:f8b0:4864:20::1033]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1n66By-0002BA-V6 for pgsql-hackers@postgresql.org; Sat, 08 Jan 2022 07:31:12 +0000 Received: by mail-pj1-x1033.google.com with SMTP id 59-20020a17090a09c100b001b34a13745eso7296692pjo.5 for ; Fri, 07 Jan 2022 23:31:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=j-davis-com.20210112.gappssmtp.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=SsysSJc0i69lAGuHBAg3sEdHInfHlllX4Ul4cmUu5fE=; b=LbjArIZ9aJMr4epKTwdhT6/gz6gF1n3aiu8EpuBK2YT2/K7eMpz3M3/o4ECiEEhWwY JgQN//9SFeM06gEqG3I/0CSJvz0lVdfsQjoLNOosditgz8PWnPOytTvgrMD3lD3OttqF eZV7DqNWb8n0Wwq5WI1ytWXKRHPVlRj4uPbKkQs1O2vwGhdw0QSxiThTH+l5FoSyCuL/ hokzpAt8OhWgAUdBkYmqzBh7R2Du0rwaJBPfEJD36RSDyUVJKKgBeHmYhisTs1qLOQRY znh6Jp2PdytzPV+9fwiF/4x5UPbFIH7YMd5Utpk4Cz28UzE8EcbWCwP21BP4mKXHDBzx 2TEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=SsysSJc0i69lAGuHBAg3sEdHInfHlllX4Ul4cmUu5fE=; b=TuOvPAgDu7IvWwMLb7xIhyPG1AzdCcdmxElj8zOOTG6KqSIMZr/d5qNZouz9q8aMs7 5DsSdM5sxDO1OyKw1oEU9KP83I8fU9NW4WRnmLp5IbyaLMrKTTJDU6Fzpi4RyG5emKBf bVed8IwbkUJQf9Oc+2x/P1JSj1Y33X5fjAVCxpImepMgNGrXq260bVV0d/Kj7207Ec8y FYD4ICkMzW2CM/GH3jKxrxL/Idj1AXUIKKCAJChkDZ3XRPSX+eSn6uIHbaAZ9ezW3BVf WvoijoRS7P8IMEtzFOtVGTTwvVYD7kdh2aoz33w6WVK8tKUnIdVuuy0cc3PoLMQMDrlJ FB+A== X-Gm-Message-State: AOAM533LPBr0VgcrPNXd8G74N1AegcSXt/3T0mrvkT8nW2kfY+VTEkK7 3mP3Ln6yM8/5By2cc73sQgXSSw== X-Google-Smtp-Source: ABdhPJyVobCGwSIOIzwA2sHYrwg/L1J+/hU3FjzYjgG/D0xw6keixjpVd35+fLzRo7Ta/36VAQ0jKw== X-Received: by 2002:a17:90a:6683:: with SMTP id m3mr443329pjj.172.1641627068881; Fri, 07 Jan 2022 23:31:08 -0800 (PST) Received: from jdavis.lan (c-73-231-146-4.hsd1.ca.comcast.net. [73.231.146.4]) by smtp.gmail.com with ESMTPSA id t5sm849245pgj.85.2022.01.07.23.31.07 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 07 Jan 2022 23:31:08 -0800 (PST) Message-ID: Subject: Re: Non-superuser subscription owners From: Jeff Davis To: Amit Kapila , Mark Dilger Cc: Andrew Dunstan , PostgreSQL-development , Robert Haas Date: Fri, 07 Jan 2022 23:31:06 -0800 In-Reply-To: References: <9DFC88D3-1300-4DE8-ACBC-4CEF84399A53@enterprisedb.com> <6BB4451E-7B1B-474C-BD1F-DB7531E720C6@enterprisedb.com> <6A2B0FF6-CC86-48CE-B0D3-5401AA5CFEA9@enterprisedb.com> <1BB0A553-3FE9-4A91-A975-6F9D8C157FBD@enterprisedb.com> <7C62876F-5D19-4B5C-96AC-5590B10A49B2@enterprisedb.com> <66f55a6b9ff7bdd6bfd0d05e8fd8351690e69e23.camel@j-davis.com> <92BEDE2A-8043-4F50-9BD8-46977A9A2972@enterprisedb.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Sat, 2022-01-08 at 12:27 +0530, Amit Kapila wrote: > For Update/Delete, we do read the table first via > FindReplTupleInLocalRel(), so is there a need to check ACL_SELECT > before that? If it's logically an update/delete, then I think ACL_UPDATE/DELETE is the right one to check. Do you have a different opinion? Regards, Jeff Davis