Content-Type: multipart/mixed; boundary="------------JGyK0Kzb6oFal04LPpLnLsxq"
Message-ID: <fc5509ce-5144-4dac-8d13-21793da44fc5@postgrespro.ru>
Date: Thu, 2 Nov 2023 00:28:05 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
From: "Anton A. Melnikov" <a.melnikov@postgrespro.ru>
Subject: 003_check_guc.pl crashes if some extensions were loaded.
Archived-At: <https://www.postgresql.org/message-id/fc5509ce-5144-4dac-8d13-21793da44fc5%40postgrespro.ru>
Precedence: bulk

This is a multi-part message in MIME format.
--------------JGyK0Kzb6oFal04LPpLnLsxq
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hello!

Found that src/test/modules/test_misc/t/003_check_guc.pl will crash if an extension
that adds own GUCs was loaded into memory.
So it is now impossible to run a check-world with loaded extension libraries.

Reproduction:
cd src/test/modules/test_misc
export EXTRA_INSTALL="contrib/pg_stat_statements"
export TEMP_CONFIG=$(pwd)/pg_stat_statements_temp.conf
echo -e "shared_preload_libraries = 'pg_stat_statements'" > $TEMP_CONFIG
echo "compute_query_id = 'regress'" >> $TEMP_CONFIG
make check PROVE_TESTS='t/003_check_guc.pl'

# +++ tap check in src/test/modules/test_misc +++
t/003_check_guc.pl .. 1/?
#   Failed test 'no parameters missing from postgresql.conf.sample'
#   at t/003_check_guc.pl line 81.
#          got: '5'
#     expected: '0'
# Looks like you failed 1 test of 3.

Maybe exclude such GUCs from this test?
For instance, like that:

--- a/src/test/modules/test_misc/t/003_check_guc.pl
+++ b/src/test/modules/test_misc/t/003_check_guc.pl
@@ -19,7 +19,7 @@ my $all_params = $node->safe_psql(
         "SELECT name
       FROM pg_settings
     WHERE NOT 'NOT_IN_SAMPLE' = ANY (pg_settings_get_flags(name)) AND
-       name <> 'config_file'
+       name <> 'config_file' AND name NOT LIKE '%.%'
       ORDER BY 1");

With the best wishes,

-- 
Anton A. Melnikov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--------------JGyK0Kzb6oFal04LPpLnLsxq
Content-Type: text/x-patch; charset=UTF-8;
 name="v0-0001-Exclude-extGUCs-from-003_check_guc.patch"
Content-Disposition: attachment;
 filename="v0-0001-Exclude-extGUCs-from-003_check_guc.patch"
Content-Transfer-Encoding: base64

Y29tbWl0IDkxYzg0ZDUwYmE0YjFjNzU3NDllNGMxNjBlMWQ0YTI1Y2E2ODRmZGEKQXV0aG9y
OiBBbnRvbiBBLiBNZWxuaWtvdiA8YS5tZWxuaWtvdkBwb3N0Z3Jlc3Byby5ydT4KRGF0ZTog
ICBXZWQgTm92IDEgMjM6NTg6MTkgMjAyMyArMDMwMAoKICAgIEV4Y2x1ZGUgZXh0ZW5zaW9u
cycgR1VDcyBmcm9tIHRoZSAwMDNfY2hlY2tfZ3VjLnBsCgpkaWZmIC0tZ2l0IGEvc3JjL3Rl
c3QvbW9kdWxlcy90ZXN0X21pc2MvdC8wMDNfY2hlY2tfZ3VjLnBsIGIvc3JjL3Rlc3QvbW9k
dWxlcy90ZXN0X21pc2MvdC8wMDNfY2hlY2tfZ3VjLnBsCmluZGV4IDRmZDZkMDNiOWUuLjYz
ZmNkNzU0ZGUgMTAwNjQ0Ci0tLSBhL3NyYy90ZXN0L21vZHVsZXMvdGVzdF9taXNjL3QvMDAz
X2NoZWNrX2d1Yy5wbAorKysgYi9zcmMvdGVzdC9tb2R1bGVzL3Rlc3RfbWlzYy90LzAwM19j
aGVja19ndWMucGwKQEAgLTE5LDcgKzE5LDcgQEAgbXkgJGFsbF9wYXJhbXMgPSAkbm9kZS0+
c2FmZV9wc3FsKAogCSJTRUxFQ1QgbmFtZQogICAgICBGUk9NIHBnX3NldHRpbmdzCiAgICBX
SEVSRSBOT1QgJ05PVF9JTl9TQU1QTEUnID0gQU5ZIChwZ19zZXR0aW5nc19nZXRfZmxhZ3Mo
bmFtZSkpIEFORAotICAgICAgIG5hbWUgPD4gJ2NvbmZpZ19maWxlJworICAgICAgIG5hbWUg
PD4gJ2NvbmZpZ19maWxlJyBBTkQgbmFtZSBOT1QgTElLRSAnJS4lJwogICAgICBPUkRFUiBC
WSAxIik7CiAjIE5vdGUgdGhlIGxvd2VyLWNhc2UgY29udmVyc2lvbiwgZm9yIGNvbnNpc3Rl
bmN5LgogbXkgQGFsbF9wYXJhbXNfYXJyYXkgPSBzcGxpdCgiXG4iLCBsYygkYWxsX3BhcmFt
cykpOwo=

--------------JGyK0Kzb6oFal04LPpLnLsxq--