Subject: Re: pgindent vs dtrace on macos
To: Tom Lane <tgl@sss.pgh.pa.us>
References: <79ed5348-be7a-b647-dd40-742207186a22@2ndquadrant.com>
 <21042.1589983015@sss.pgh.pa.us>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Organization: 2ndQuadrant
Message-ID: <fcbe3e68-19f8-ae3b-cf5a-3e420123826b@2ndquadrant.com>
Date: Fri, 22 May 2020 11:29:25 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <21042.1589983015@sss.pgh.pa.us>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2020-05-20 15:56, Tom Lane wrote:
> On a closely related point: I was confused for awhile on Monday
> afternoon, wondering why the built tarballs didn't match my local
> tree.  I eventually realized that when I'd run pgindent on Saturday,
> it had reformatted some generated files such as
> src/bin/psql/sql_help.h, causing those not to match the freshly-made
> ones in the tarball.  I wonder if we should make an effort to ensure
> that our generated .h and .c files always satisfy pgindent.

We should generally try to do that, if only so that they don't appear 
weird and random when looking at them.

I think in the past it would have been very difficult for a generation 
script to emulate pgindent's weird un-indentation logic on trailing 
lines, but that shouldn't be a problem anymore.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services