Message-ID: <fcc2f455e75122a0cba85c355e3ed07ba60b99d9.camel@j-davis.com>
Subject: Re: Statistics Import and Export
From: Jeff Davis <pgsql@j-davis.com>
To: jian he <jian.universality@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, Corey Huinker
 <corey.huinker@gmail.com>,  Tom Lane <tgl@sss.pgh.pa.us>, Michael Paquier
 <michael@paquier.xyz>, Nathan Bossart <nathandbossart@gmail.com>, Bruce
 Momjian <bruce@momjian.us>, Matthias van de Meent
 <boekewurm+postgres@gmail.com>, Magnus Hagander <magnus@hagander.net>,
 Stephen Frost <sfrost@snowman.net>, Ashutosh Bapat
 <ashutosh.bapat.oss@gmail.com>, Peter Smith <smithpb2250@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, 
 alvherre@alvh.no-ip.org
Date: Tue, 25 Feb 2025 00:10:23 -0800
In-Reply-To: <CACJufxHG9MBQozbJQ4JRBcRbUO+t+sx4qLZX092rS_9b4SR_EA@mail.gmail.com>
References: 
	<CADkLM=f0a43aTd88xW4xCFayEF25g-7hTrHX_WhV40HyocsUGg@mail.gmail.com>
	 <97b451228227c555be1a4f79c4a62ddec9a74f06.camel@j-davis.com>
	 <CADkLM=ckXu5wzSQZ3Y_fvAaL8rZ+upZdSecBLf5FCTMj7M6T-A@mail.gmail.com>
	 <b227c4fca29dfb893bb414ce6d84fc2377489ecc.camel@j-davis.com>
	 <CADkLM=dRMC6t8gp9GVf6y6E_r5EChQjMAAh_vPyih_zMiq0zvA@mail.gmail.com>
	 <y2d36zf6pl3n6ni6e4ctblu3a5iazi2dycknq53h2mjvp7lto4@hhww3h2qgdrw>
	 <1457469.1740419458@sss.pgh.pa.us>
	 <CADkLM=eWSv2z_DVB=psfwHitq7DbFJQaP9A46R27eARC-4OYtQ@mail.gmail.com>
	 <cpdanvzykcb5o64rmapkx6n5gjypoce3y52hff7ocxupgpbxu4@53jmlyvukijo>
	 <CADkLM=dX67xer59tVYMCQZ+pHAT2sCyyrUDzeDCdW_TdxqwOgA@mail.gmail.com>
	 <curtrasm6ylt7es2ukfuals2mh5an72yzxgvyel65mw3ere7qs@nw6m4ffpo4m3>
	 <8d13e4296408c53a93390525d0bcb906cbd13df4.camel@j-davis.com>
	 <CACJufxHG9MBQozbJQ4JRBcRbUO+t+sx4qLZX092rS_9b4SR_EA@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu2 
MIME-Version: 1.0
Archived-At: <https://www.postgresql.org/message-id/fcc2f455e75122a0cba85c355e3ed07ba60b99d9.camel%40j-davis.com>
Precedence: bulk

On Tue, 2025-02-25 at 11:30 +0800, jian he wrote:
> maybe we can just use
> elog(ERROR, "pg_class entry for relid %u not found", reloid)));

Thank you.

> also in stats_lock_check_privileges.
> check_inplace_rel_lock related comments should be removed?

In-place update locking rules still apply when updating pg_class or
pg_database even if the current caller is not performing an in-place
update. It might be better to point instead to=20
check_lock_if_inplace_updateable_rel()?

Regards,
	Jeff Davis