Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1osm28-0001dI-1V for pgsql-hackers@arkaria.postgresql.org; Wed, 09 Nov 2022 14:26:28 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1osm26-0003pP-Uj for pgsql-hackers@arkaria.postgresql.org; Wed, 09 Nov 2022 14:26:26 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1osm25-0003pE-Sg for pgsql-hackers@lists.postgresql.org; Wed, 09 Nov 2022 14:26:26 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1osm21-0008Dk-Hn for pgsql-hackers@postgresql.org; Wed, 09 Nov 2022 14:26:24 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 3FF2F5C006E for ; Wed, 9 Nov 2022 09:26:19 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 09 Nov 2022 09:26:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1668003979; x= 1668090379; bh=ScJQltHZ5ZR1epybKPLMzULVqfDXSDD2FSJLv15PX3U=; b=Z MNcYz3KjQN3o5rZURXIi7VSDeXect9r9G+rXRe1k8XxgsVuHoiPk58QUABPqOtUz UD4iwG+tMNx1fJFWAbgTDBn+8jMGyThLSoc90xhJ8Z3vwFAJVZBYtlx+gRZBwcK+ Gsb40D9b2sW6XCQ1l8G/LWKMrV31hmZ2k5tL3N4ifqwwtNkIs3MmggXi0enTIBZO OGK83Y8eYmnLaQn28xrFldgDhFq+gXCJvrt4VNKf3GydvkDOhblNoVvLNldI1jiF bGFQVLAzCB2+8XX6lpVN0cravw9aN1Jn07pEuOkcRJOxIrJvygkCC97nnp4m46uj GErABRLYQsN7zlutVzFcQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrfedvgdeigecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurheptgfkffggfgfhuffvsehmtderredtfe ejnecuhfhrohhmpefrvghtvghrucfgihhsvghnthhrrghuthcuoehpvghtvghrrdgvihhs vghnthhrrghuthesvghnthgvrhhprhhishgvuggsrdgtohhmqeenucggtffrrghtthgvrh hnpeetveeuvdeikeeigefhveffhffhvdejveelleefieekieekvdffgeetkedutdefleen ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehpvghtvg hrrdgvihhsvghnthhrrghuthesvghnthgvrhhprhhishgvuggsrdgtohhm X-ME-Proxy: Feedback-ID: i131946ab:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Wed, 9 Nov 2022 09:26:17 -0500 (EST) Content-Type: multipart/mixed; boundary="------------pbgP3aJ5Ui54CQ2qrIPlPT2G" Message-ID: Date: Wed, 9 Nov 2022 15:26:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Content-Language: en-US From: Peter Eisentraut Subject: Update some more ObjectType switch statements to not have default To: pgsql-hackers List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------pbgP3aJ5Ui54CQ2qrIPlPT2G Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit This arose during the review of another patch. We often omit the default case of a switch statement to allow the compiler to complain if an enum case has been missed. I found a few where that wasn't done yet, but it would make sense and would have found an omission in another patch. --------------pbgP3aJ5Ui54CQ2qrIPlPT2G Content-Type: text/plain; charset=UTF-8; name="0001-Update-some-more-ObjectType-switch-statements-to-not.patch" Content-Disposition: attachment; filename*0="0001-Update-some-more-ObjectType-switch-statements-to-not.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSAzN2EwM2I0MjBjZTUyZjAyMTE5YTAwODVmM2M1ZjY2NjZlM2I0NGZiIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy YXV0Lm9yZz4KRGF0ZTogV2VkLCA5IE5vdiAyMDIyIDE0OjUyOjMzICswMTAwClN1YmplY3Q6 IFtQQVRDSF0gVXBkYXRlIHNvbWUgbW9yZSBPYmplY3RUeXBlIHN3aXRjaCBzdGF0ZW1lbnRz IHRvIG5vdCBoYXZlCiBkZWZhdWx0CgpUaGlzIGFsbG93cyB0aGUgY29tcGlsZXIgdG8gY29t cGxhaW4gaWYgYSBjYXNlIGhhcyBiZWVuIG1pc3NlZC4gIEluCnRoZXNlIGluc3RhbmNlcywg dGhlIHRyYWRlb2ZmIG9mIGhhdmluZyB0byBsaXN0IGEgZmV3IHVubmVlZGVkIGNhc2VzCnRv IHNpbGVuY2UgdGhlIGNvbXBpbGVyIHNlZW1zIGJldHRlciB0aGFuIHRoZSByaXNrIG9mIGFj dHVhbGx5IG1pc3NpbmcKb25lLgotLS0KIHNyYy9iYWNrZW5kL2NhdGFsb2cvb2JqZWN0YWRk cmVzcy5jIHwgMjYgKysrKysrKysrKystLS0tLS0tLQogc3JjL2JhY2tlbmQvY29tbWFuZHMv ZHJvcGNtZHMuYyAgICAgfCAzOSArKysrKysrKysrKysrKysrKysrKysrKysrKystLQogMiBm aWxlcyBjaGFuZ2VkLCA1MyBpbnNlcnRpb25zKCspLCAxMiBkZWxldGlvbnMoLSkKCmRpZmYg LS1naXQgYS9zcmMvYmFja2VuZC9jYXRhbG9nL29iamVjdGFkZHJlc3MuYyBiL3NyYy9iYWNr ZW5kL2NhdGFsb2cvb2JqZWN0YWRkcmVzcy5jCmluZGV4IGM3ZGU3MjMyYjg5MC4uZjM2NTgx ZDEwNmIyIDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9jYXRhbG9nL29iamVjdGFkZHJlc3Mu YworKysgYi9zcmMvYmFja2VuZC9jYXRhbG9nL29iamVjdGFkZHJlc3MuYwpAQCAtOTYwLDcg Kzk2MCw3IEBAIE9iamVjdEFkZHJlc3MKIGdldF9vYmplY3RfYWRkcmVzcyhPYmplY3RUeXBl IG9ianR5cGUsIE5vZGUgKm9iamVjdCwKIAkJCQkgICBSZWxhdGlvbiAqcmVscCwgTE9DS01P REUgbG9ja21vZGUsIGJvb2wgbWlzc2luZ19vaykKIHsKLQlPYmplY3RBZGRyZXNzIGFkZHJl c3M7CisJT2JqZWN0QWRkcmVzcyBhZGRyZXNzID0ge0ludmFsaWRPaWQsIEludmFsaWRPaWQs IDB9OwogCU9iamVjdEFkZHJlc3Mgb2xkX2FkZHJlc3MgPSB7SW52YWxpZE9pZCwgSW52YWxp ZE9pZCwgMH07CiAJUmVsYXRpb24JcmVsYXRpb24gPSBOVUxMOwogCXVpbnQ2NAkJaW52YWxf Y291bnQ7CkBAIC05OTEsNiArOTkxLDcgQEAgZ2V0X29iamVjdF9hZGRyZXNzKE9iamVjdFR5 cGUgb2JqdHlwZSwgTm9kZSAqb2JqZWN0LAogCQkJCQkJCQkJCQkJICAgJnJlbGF0aW9uLCBs b2NrbW9kZSwKIAkJCQkJCQkJCQkJCSAgIG1pc3Npbmdfb2spOwogCQkJCWJyZWFrOworCQkJ Y2FzZSBPQkpFQ1RfQVRUUklCVVRFOgogCQkJY2FzZSBPQkpFQ1RfQ09MVU1OOgogCQkJCWFk ZHJlc3MgPQogCQkJCQlnZXRfb2JqZWN0X2FkZHJlc3NfYXR0cmlidXRlKG9ianR5cGUsIGNh c3ROb2RlKExpc3QsIG9iamVjdCksCkBAIC0xMTYzLDE0ICsxMTY0LDEyIEBAIGdldF9vYmpl Y3RfYWRkcmVzcyhPYmplY3RUeXBlIG9ianR5cGUsIE5vZGUgKm9iamVjdCwKIAkJCQkJCQkJ CQkJCQkJCSBtaXNzaW5nX29rKTsKIAkJCQlhZGRyZXNzLm9iamVjdFN1YklkID0gMDsKIAkJ CQlicmVhazsKLQkJCWRlZmF1bHQ6Ci0JCQkJZWxvZyhFUlJPUiwgInVucmVjb2duaXplZCBv YmplY3QgdHlwZTogJWQiLCAoaW50KSBvYmp0eXBlKTsKLQkJCQkvKiBwbGFjYXRlIGNvbXBp bGVyLCBpbiBjYXNlIGl0IHRoaW5rcyBlbG9nIG1pZ2h0IHJldHVybiAqLwotCQkJCWFkZHJl c3MuY2xhc3NJZCA9IEludmFsaWRPaWQ7Ci0JCQkJYWRkcmVzcy5vYmplY3RJZCA9IEludmFs aWRPaWQ7Ci0JCQkJYWRkcmVzcy5vYmplY3RTdWJJZCA9IDA7CisJCQkJLyogbm8gZGVmYXVs dCwgdG8gbGV0IGNvbXBpbGVyIHdhcm4gYWJvdXQgbWlzc2luZyBjYXNlICovCiAJCX0KIAor CQlpZiAoIWFkZHJlc3MuY2xhc3NJZCkKKwkJCWVsb2coRVJST1IsICJ1bnJlY29nbml6ZWQg b2JqZWN0IHR5cGU6ICVkIiwgKGludCkgb2JqdHlwZSk7CisKIAkJLyoKIAkJICogSWYgd2Ug Y291bGQgbm90IGZpbmQgdGhlIHN1cHBsaWVkIG9iamVjdCwgcmV0dXJuIHdpdGhvdXQgbG9j a2luZy4KIAkJICovCkBAIC0yNjM1LDkgKzI2MzQsMTYgQEAgY2hlY2tfb2JqZWN0X293bmVy c2hpcChPaWQgcm9sZWlkLCBPYmplY3RUeXBlIG9ianR5cGUsIE9iamVjdEFkZHJlc3MgYWRk cmVzcywKIAkJCQlhY2xjaGVja19lcnJvcihBQ0xDSEVDS19OT1RfT1dORVIsIG9ianR5cGUs CiAJCQkJCQkJICAgTmFtZUxpc3RUb1N0cmluZyhjYXN0Tm9kZShMaXN0LCBvYmplY3QpKSk7 CiAJCQlicmVhazsKLQkJZGVmYXVsdDoKLQkJCWVsb2coRVJST1IsICJ1bnJlY29nbml6ZWQg b2JqZWN0IHR5cGU6ICVkIiwKLQkJCQkgKGludCkgb2JqdHlwZSk7CisJCWNhc2UgT0JKRUNU X0FNT1A6CisJCWNhc2UgT0JKRUNUX0FNUFJPQzoKKwkJY2FzZSBPQkpFQ1RfREVGQVVMVDoK KwkJY2FzZSBPQkpFQ1RfREVGQUNMOgorCQljYXNlIE9CSkVDVF9QVUJMSUNBVElPTl9OQU1F U1BBQ0U6CisJCWNhc2UgT0JKRUNUX1BVQkxJQ0FUSU9OX1JFTDoKKwkJY2FzZSBPQkpFQ1Rf VVNFUl9NQVBQSU5HOgorCQkJLyogVGhlc2UgYXJlIGN1cnJlbnRseSBub3Qgc3VwcG9ydGVk IG9yIGRvbid0IG1ha2Ugc2Vuc2UgaGVyZS4gKi8KKwkJCWVsb2coRVJST1IsICJ1bnN1cHBv cnRlZCBvYmplY3QgdHlwZTogJWQiLCAoaW50KSBvYmp0eXBlKTsKKwkJCWJyZWFrOwogCX0K IH0KIApkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvY29tbWFuZHMvZHJvcGNtZHMuYyBiL3Ny Yy9iYWNrZW5kL2NvbW1hbmRzL2Ryb3BjbWRzLmMKaW5kZXggMjYxNTdlYjRlM2Y1Li44YmFj NThhOTk0MWEgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL2NvbW1hbmRzL2Ryb3BjbWRzLmMK KysrIGIvc3JjL2JhY2tlbmQvY29tbWFuZHMvZHJvcGNtZHMuYwpAQCAtNDgwLDEwICs0ODAs NDUgQEAgZG9lc19ub3RfZXhpc3Rfc2tpcHBpbmcoT2JqZWN0VHlwZSBvYmp0eXBlLCBOb2Rl ICpvYmplY3QpCiAJCQltc2cgPSBnZXR0ZXh0X25vb3AoInB1YmxpY2F0aW9uIFwiJXNcIiBk b2VzIG5vdCBleGlzdCwgc2tpcHBpbmciKTsKIAkJCW5hbWUgPSBzdHJWYWwob2JqZWN0KTsK IAkJCWJyZWFrOwotCQlkZWZhdWx0OgotCQkJZWxvZyhFUlJPUiwgInVucmVjb2duaXplZCBv YmplY3QgdHlwZTogJWQiLCAoaW50KSBvYmp0eXBlKTsKKworCQljYXNlIE9CSkVDVF9DT0xV TU46CisJCWNhc2UgT0JKRUNUX0RBVEFCQVNFOgorCQljYXNlIE9CSkVDVF9GT1JFSUdOX1RB QkxFOgorCQljYXNlIE9CSkVDVF9JTkRFWDoKKwkJY2FzZSBPQkpFQ1RfTUFUVklFVzoKKwkJ Y2FzZSBPQkpFQ1RfUk9MRToKKwkJY2FzZSBPQkpFQ1RfU0VRVUVOQ0U6CisJCWNhc2UgT0JK RUNUX1NVQlNDUklQVElPTjoKKwkJY2FzZSBPQkpFQ1RfVEFCTEU6CisJCWNhc2UgT0JKRUNU X1RBQkxFU1BBQ0U6CisJCWNhc2UgT0JKRUNUX1ZJRVc6CisJCQkvKgorCQkJICogVGhlc2Ug YXJlIGhhbmRsZWQgZWxzZXdoZXJlLCBzbyBpZiBzb21lb25lIGdldHMgaGVyZSB0aGUgY29k ZQorCQkJICogaXMgcHJvYmFibHkgd3Jvbmcgb3Igc2hvdWxkIGJlIHJldmlzaXRlZC4KKwkJ CSAqLworCQkJZWxvZyhFUlJPUiwgInVuc3VwcG9ydGVkIG9iamVjdCB0eXBlOiAlZCIsIChp bnQpIG9ianR5cGUpOworCQkJYnJlYWs7CisKKwkJY2FzZSBPQkpFQ1RfQU1PUDoKKwkJY2Fz ZSBPQkpFQ1RfQU1QUk9DOgorCQljYXNlIE9CSkVDVF9BVFRSSUJVVEU6CisJCWNhc2UgT0JK RUNUX0RFRkFVTFQ6CisJCWNhc2UgT0JKRUNUX0RFRkFDTDoKKwkJY2FzZSBPQkpFQ1RfRE9N Q09OU1RSQUlOVDoKKwkJY2FzZSBPQkpFQ1RfTEFSR0VPQkpFQ1Q6CisJCWNhc2UgT0JKRUNU X1BBUkFNRVRFUl9BQ0w6CisJCWNhc2UgT0JKRUNUX1BVQkxJQ0FUSU9OX05BTUVTUEFDRToK KwkJY2FzZSBPQkpFQ1RfUFVCTElDQVRJT05fUkVMOgorCQljYXNlIE9CSkVDVF9UQUJDT05T VFJBSU5UOgorCQljYXNlIE9CSkVDVF9VU0VSX01BUFBJTkc6CisJCQkvKiBUaGVzZSBhcmUg Y3VycmVudGx5IG5vdCB1c2VkIG9yIG5lZWRlZC4gKi8KKwkJCWVsb2coRVJST1IsICJ1bnN1 cHBvcnRlZCBvYmplY3QgdHlwZTogJWQiLCAoaW50KSBvYmp0eXBlKTsKIAkJCWJyZWFrOwor CisJCQkvKiBubyBkZWZhdWx0LCB0byBsZXQgY29tcGlsZXIgd2FybiBhYm91dCBtaXNzaW5n IGNhc2UgKi8KIAl9CisJaWYgKCFtc2cpCisJCWVsb2coRVJST1IsICJ1bnJlY29nbml6ZWQg b2JqZWN0IHR5cGU6ICVkIiwgKGludCkgb2JqdHlwZSk7CiAKIAlpZiAoIWFyZ3MpCiAJCWVy ZXBvcnQoTk9USUNFLCAoZXJybXNnKG1zZywgbmFtZSkpKTsKLS0gCjIuMzguMQoK --------------pbgP3aJ5Ui54CQ2qrIPlPT2G--