Content-Type: multipart/mixed; boundary="------------ZCxoCA0KlN6NtjELMPC607Mo"
Message-ID: <fce84be6-3158-4b9c-9b40-a403c49d2966@proxel.se>
Date: Thu, 27 Feb 2025 13:53:17 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
To: pgsql-hackers <pgsql-hackers@postgresql.org>
From: Andreas Karlsson <andreas@proxel.se>
Subject: Add support for EXTRA_REGRESS_OPTS for meson
Archived-At: <https://www.postgresql.org/message-id/fce84be6-3158-4b9c-9b40-a403c49d2966%40proxel.se>
Precedence: bulk

This is a multi-part message in MIME format.
--------------ZCxoCA0KlN6NtjELMPC607Mo
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

We use EXTRA_REGRESS_OPTS to make sure the whole test suite passes with 
our extension loaded and since I prefer develop in meson over using 
autotools and make the lack of support for EXTRA_REGRESS_OPTS in meson
has bugged me for a while.

I have implemented support for it as an environment variable we read in 
the testwrap script instead of adding it as a configuration option to 
meson.build. The reason for this is that I do not like having to run 
"meson reconfigure" all the time plus that for the PG_TEST_EXTRA we 
ended up having to add an environment variable anyway.

To use this run e.g. the following:

   EXTRA_REGRESS_OPTS="--load-extension=pgcrypto" meson test

Question: Would it make sense to rename it to PG_REGRESS_EXTRA_OPTS or 
something similar while we already touch touch this code to make the 
various options easier to remember?

Andreas

--------------ZCxoCA0KlN6NtjELMPC607Mo
Content-Type: text/x-patch; charset=UTF-8;
 name="0001-meson-Add-support-for-EXTRA_REGRESS_OPTS.patch"
Content-Disposition: attachment;
 filename="0001-meson-Add-support-for-EXTRA_REGRESS_OPTS.patch"
Content-Transfer-Encoding: base64

RnJvbSA4N2NlNjIyYTE5MzE1YjY3OWJiZDU2OTFlMDFjOTYyNjFiYzBjNGM4IE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBBbmRyZWFzIEthcmxzc29uIDxhbmRyZWFzQHByb3hl
bC5zZT4KRGF0ZTogVGh1LCAyNyBGZWIgMjAyNSAwMDoyMzo0NCArMDEwMApTdWJqZWN0OiBb
UEFUQ0hdIG1lc29uOiBBZGQgc3VwcG9ydCBmb3IgRVhUUkFfUkVHUkVTU19PUFRTCgpBZGQg
c3VwcG9ydCBmb3IgdGhlIEVYVFJBX1JFR1JFU1NfT1BUUyBlbnZpcm9ubWVudCB2YXJpYWJs
ZSBpbiBtZXNvbgp3aGljaCB3b3JrcyBqdXN0IGxpa2Ugd2l0aCBtYWtlIGFuZCBhcHBsaWVz
IHRvIGFsbCByZWdyZXNzLCBlY3BnIGFuZAppc29sYXRpb24gdGVzdHMuIFRBUCB0ZXN0cyB3
aGljaCBzdXBwb3J0IGl0IHVuZGVyIG1ha2Ugd2lsbCBjb250aW51ZQp0byBzdXBwb3J0IHRo
ZSBvcHRpb24uCgpSdW4gaXQgd2l0aCBlLmc6CgogICAgRVhUUkFfUkVHUkVTU19PUFRTPSIt
LXRlbXAtY29uZmlnPXRlc3QuY29uZiIgbWVzb24gdGVzdAotLS0KIHNyYy90b29scy90ZXN0
d3JhcCB8IDggKysrKysrKy0KIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDEg
ZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9zcmMvdG9vbHMvdGVzdHdyYXAgYi9zcmMvdG9v
bHMvdGVzdHdyYXAKaW5kZXggOGFlOGZiNzliYTcuLmY1MmNhMzc2ZGExIDEwMDc1NQotLS0g
YS9zcmMvdG9vbHMvdGVzdHdyYXAKKysrIGIvc3JjL3Rvb2xzL3Rlc3R3cmFwCkBAIC0yLDYg
KzIsNyBAQAogCiBpbXBvcnQgYXJncGFyc2UKIGltcG9ydCBzaHV0aWwKK2ltcG9ydCBzaGxl
eAogaW1wb3J0IHN1YnByb2Nlc3MKIGltcG9ydCBvcwogaW1wb3J0IHN5cwpAQCAtNTEsNyAr
NTIsMTIgQEAgZW52X2RpY3QgPSB7Kipvcy5lbnZpcm9uLAogaWYgIlBHX1RFU1RfRVhUUkEi
IG5vdCBpbiBlbnZfZGljdCBhbmQgYXJncy5wZ190ZXN0X2V4dHJhOgogICAgIGVudl9kaWN0
WyJQR19URVNUX0VYVFJBIl0gPSBhcmdzLnBnX3Rlc3RfZXh0cmEKIAotc3AgPSBzdWJwcm9j
ZXNzLlBvcGVuKGFyZ3MudGVzdF9jb21tYW5kLCBlbnY9ZW52X2RpY3QsIHN0ZG91dD1zdWJw
cm9jZXNzLlBJUEUpCitpZiBhcmdzLnRlc3RuYW1lIGluIFsncmVncmVzcycsICdpc29sYXRp
b24nLCAnZWNwZyddIGFuZCAnRVhUUkFfUkVHUkVTU19PUFRTJyBpbiBlbnZfZGljdDoKKyAg
ICB0ZXN0X2NvbW1hbmQgPSBhcmdzLnRlc3RfY29tbWFuZCArIHNobGV4LnNwbGl0KGVudl9k
aWN0WydFWFRSQV9SRUdSRVNTX09QVFMnXSkKK2Vsc2U6CisgICAgdGVzdF9jb21tYW5kID0g
YXJncy50ZXN0X2NvbW1hbmQKKworc3AgPSBzdWJwcm9jZXNzLlBvcGVuKHRlc3RfY29tbWFu
ZCwgZW52PWVudl9kaWN0LCBzdGRvdXQ9c3VicHJvY2Vzcy5QSVBFKQogIyBNZXNvbiBjYXRl
Z29yaXplcyBhIHBhc3NpbmcgVE9ETyB0ZXN0IHBvaW50IGFzIGJhZAogIyAoaHR0cHM6Ly9n
aXRodWIuY29tL21lc29uYnVpbGQvbWVzb24vaXNzdWVzLzEzMTgzKS4gIFJlbW92ZSB0aGUg
VE9ETwogIyBkaXJlY3RpdmUsIHNvIE1lc29uIGNvbXB1dGVzIHRoZSBmaWxlIHJlc3VsdCBs
aWtlIFBlcmwgZG9lcy4gIFRoaXMgY291bGQKLS0gCjIuNDcuMgoK

--------------ZCxoCA0KlN6NtjELMPC607Mo--