Feedback-ID: ie0a040ee:Fastmail
Message-ID: <fd05929c-4f9e-f143-de87-446cd673b04e@eisentraut.org>
Date: Wed, 13 Sep 2023 16:12:02 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.15.0
Subject: Re: Reducing connection overhead in pg_upgrade compat check phase
Content-Language: en-US
To: Daniel Gustafsson <daniel@yesql.se>,
 Nathan Bossart <nathandbossart@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <235E7E38-6DCA-4E5F-812C-7F3033FC800A@yesql.se>
 <89A64E5D-D3DC-4806-B038-CD493F5F5510@yesql.se>
 <20230313182147.GA294021@nathanxps13> <20230704190839.GA3468243@nathanxps13>
 <9C9D8A09-9794-46DD-8074-8961924B99F1@yesql.se>
 <20230708214354.GA4044380@nathanxps13>
 <A31FC972-FCBE-47CE-85F0-182B58C29422@yesql.se>
 <20230710230907.GA481155@nathanxps13>
 <1FE28680-333E-433C-9809-95662037B0AA@yesql.se>
 <22CDC82E-8959-4D92-B1B0-069558011F1C@yesql.se>
 <20230711233606.GA776188@nathanxps13>
 <19245526-3F25-4F84-BB80-21DA034F8650@yesql.se>
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <19245526-3F25-4F84-BB80-21DA034F8650@yesql.se>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/fd05929c-4f9e-f143-de87-446cd673b04e%40eisentraut.org>
Precedence: bulk

On 31.08.23 23:34, Daniel Gustafsson wrote:
>> On 12 Jul 2023, at 01:36, Nathan Bossart <nathandbossart@gmail.com> wrote:
>>
>> On Wed, Jul 12, 2023 at 12:43:14AM +0200, Daniel Gustafsson wrote:
>>> I did have coffee before now, but only found time to actually address this now
>>> so here is a v7 with just that change and a fresh rebase.
>>
>> Thanks.  I think the patch is in decent shape.
> 
> Due to ENOTENOUGHTIME it bitrotted a bit, so here is a v8 rebase which I really
> hope to close in this CF.

The alignment of this output looks a bit funny:

...
Checking for prepared transactions                            ok
Checking for contrib/isn with bigint-passing mismatch         ok
Checking for data type usage                                  checking all databases
ok
Checking for presence of required libraries                   ok
Checking database user is the install user                    ok
...


Also, you should put gettext_noop() calls into the .status = "Checking ..."
assignments and arrange to call gettext() where they are used, to maintain
the translatability.