public inbox for [email protected]  
help / color / mirror / Atom feed
From: Nikolay Shaplov <[email protected]>
To: Zsolt Parragi <[email protected]>
To: Álvaro Herrera <[email protected]>
Cc: Jacob Champion <[email protected]>
Cc: VASUKI M <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: [email protected]
Cc: Robert Haas <[email protected]>
Cc: [email protected]
Subject: Re: Custom oauth validator options
Date: Thu, 29 Jan 2026 14:58:52 +0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAN4CZFPUfTj-BF-m5=F7_MnY_T3+Qh-DuG7N7ojdbJDkT8JHeA@mail.gmail.com>
References: <CAN4CZFPmF9fGOcFubwOxqXymhVo_RvbUx3bLoYQcfk=f0mwECw@mail.gmail.com>
	<[email protected]>
	<CAN4CZFPUfTj-BF-m5=F7_MnY_T3+Qh-DuG7N7ojdbJDkT8JHeA@mail.gmail.com>


On 28.01.2026 22:21, Zsolt Parragi wrote:
>> but I wonder if this is something we
>> should attempt in the context of the larger refactoring done by the
>> patch series here,
> That patch series is interesting but it is about SQL (table, index,
> operator) options, while this is about guc variable validation and
> extension. These seem unrelated to me.

This patch suggests context independent API for managing extension 
defined sets of options. It is used for
relation options and similar options, but cat be also used for any 
options sets, may be with small modifications.

GUC options are almost same options as relation options. That is why, I 
guess, Alvaro suggested you to look at this patch.

And I agree with him. Please have a look at 
src/backend/access/common/options.c in that patch. I almost sure this 
code can be reused for GUC options too.

Whole https://commitfest.postgresql.org/patch/4688/ is a bit outdated, 
and need rebase, but options.c from it is as good as it was before.

And we've just recently committed a small fix that have been blocking 
4688's patch rebase. I have plans to rebase it in not so distant future.

It you find it useful for your tasks and even would like to join to 
review (at least for options.c part) I would do it with higher priority.
(but it is still my weekend-days project, so it can't be extremely fast)







view thread (3+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Custom oauth validator options
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox