Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qBbIe-0007aW-2A for pgsql-hackers@arkaria.postgresql.org; Tue, 20 Jun 2023 13:21:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1qBbIc-0001ha-SQ for pgsql-hackers@arkaria.postgresql.org; Tue, 20 Jun 2023 13:21:34 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qBbIc-0001hP-In for pgsql-hackers@lists.postgresql.org; Tue, 20 Jun 2023 13:21:34 +0000 Received: from relay5-d.mail.gandi.net ([2001:4b98:dc4:8::225]) by makus.postgresql.org with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qBbIU-003FUe-G6 for pgsql-hackers@postgresql.org; Tue, 20 Jun 2023 13:21:33 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id A1E3C1C000B; Tue, 20 Jun 2023 13:21:16 +0000 (UTC) Content-Type: multipart/alternative; boundary="------------YgARiwZMjAAYNOso0YkC2uFe" Message-ID: Date: Tue, 20 Jun 2023 09:21:14 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: run pgindent on a regular basis / scripted manner Content-Language: en-US To: Tom Lane Cc: Jelte Fennema , Michael Paquier , "shiy.fnst@fujitsu.com" , Robert Haas , Justin Pryzby , Andres Freund , Noah Misch , Peter Geoghegan , Bruce Momjian , Magnus Hagander , Alvaro Herrera , Stephen Frost , Jesse Zhang , "pgsql-hackers@postgresql.org" , Peter Eisentraut References: <3d67bc80-4de2-5ba8-e272-e4ad2e59ba04@dunslane.net> <4ac8f263-f1bb-faa5-a307-1fffe00f0e3e@dunslane.net> <0f074818-b01a-799f-3c74-5fb5deab1d23@dunslane.net> <1d66447e-a77b-ca0d-90a0-782800e85383@dunslane.net> <582c503b-cd98-1891-ff87-9c8e8ce73ee5@dunslane.net> <30a72ba4-9ca4-15b5-db0f-0e68cba7ab26@dunslane.net> <1f594a4b-14c8-e159-b250-edf8a091320d@dunslane.net> <3156045.1687208823@sss.pgh.pa.us> <3275721.1687266516@sss.pgh.pa.us> From: Andrew Dunstan In-Reply-To: <3275721.1687266516@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------YgARiwZMjAAYNOso0YkC2uFe Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2023-06-20 Tu 09:08, Tom Lane wrote: > Andrew Dunstan writes: >> On 2023-06-19 Mo 17:07, Tom Lane wrote: >>> Is koel tracking the right repo? It just spit up with a bunch of >>> diffs that seem to have little to do with the commit it's claiming >>> caused them: >> Yeah, I changed it so that instead of just checking new commits it would >> check the whole tree. The problem with the incremental approach is that >> the next run it might turn green again but the issue would not have been >> fixed. > Ah. > >> I think this is a one-off issue. Once we clean up the tree the problem >> would disappear and the commits it shows would be correct. I imaging >> that's going to happen any day now? > I can go fix the problems now that we know there are some (already). > However, if what you're saying is that koel only checks recently-changed > files, that's going to be pretty misleading in future too. If people > don't react to such reports right away, they'll disappear, no? > > That's what would have happened if I hadn't changed the way it worked (and that's why I changed it). Now it doesn't just check recent commits, it checks the whole tree, and will stay red until the tree is fixed. cheers andrew -- Andrew Dunstan EDB:https://www.enterprisedb.com --------------YgARiwZMjAAYNOso0YkC2uFe Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit


On 2023-06-20 Tu 09:08, Tom Lane wrote:
Andrew Dunstan <andrew@dunslane.net> writes:

On 2023-06-19 Mo 17:07, Tom Lane wrote:

Is koel tracking the right repo?  It just spit up with a bunch of
diffs that seem to have little to do with the commit it's claiming
caused them:


      

        
Yeah, I changed it so that instead of just checking new commits it would 
check the whole tree. The problem with the incremental approach is that 
the next run it might turn green again but the issue would not have been 
fixed.


      

      
Ah.



      

        
I think this is a one-off issue. Once we clean up the tree the problem 
would disappear and the commits it shows would be correct. I imaging 
that's going to happen any day now?


      

      
I can go fix the problems now that we know there are some (already).
However, if what you're saying is that koel only checks recently-changed
files, that's going to be pretty misleading in future too.  If people
don't react to such reports right away, they'll disappear, no?

			

    

    


    

    
That's what would have happened if I hadn't changed the way it
      worked (and that's why I changed it). Now it doesn't just check
      recent commits, it checks the whole tree, and will stay red until
      the tree is fixed.

    

    


    

    
cheers

    


    

    
andrew

    

    
--
Andrew Dunstan
EDB: https://www.enterprisedb.com


  


--------------YgARiwZMjAAYNOso0YkC2uFe--