Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tsRp8-0029gD-WF for pgsql-hackers@arkaria.postgresql.org; Wed, 12 Mar 2025 19:33:03 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tsRp7-00Bo0b-G6 for pgsql-hackers@arkaria.postgresql.org; Wed, 12 Mar 2025 19:33:01 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tsRp7-00Bo05-6N for pgsql-hackers@lists.postgresql.org; Wed, 12 Mar 2025 19:33:01 +0000 Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1tsRp3-002VSc-28 for pgsql-hackers@postgresql.org; Wed, 12 Mar 2025 19:33:00 +0000 Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-54993c68ba0so249278e87.2 for ; Wed, 12 Mar 2025 12:32:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741807978; x=1742412778; darn=postgresql.org; h=content-transfer-encoding:in-reply-to:content-language:references :to:from:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=MnbZCKEK8an+0PL7osjcKSGg3UUPjBXXf//jKVIlbdw=; b=iLZPjGqXhqxsPYy5mFTPZUrESrT3CGpyZt6TGeofuhAejn+x5kBCqaKn+f0PIBGoiz KAAknij2UaTzjDKjjXOnf1tr/H0BL/aZCErnhnG1vvqH6WeVt1dz/6AWnKQ+i2W+waZj QdUxZoMe586nJh0Sq4HQHw4ORhWuav+G66fvlblMJylduPe3TUzBdDmQ/iSfS2q0LIkh a5lO9PpbDrrnT5IlkMAbAbwjAclUCB+UlcYFww5Ga1NEGC/OTQW++yA2mOiNxLNfdAT4 vaD+W982PuKGuYFHW/j8nL0uvYS2tSWhGR59tHPwWRZBQibAAomEpr9IKn+GYJ6mW9kN wycw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741807978; x=1742412778; h=content-transfer-encoding:in-reply-to:content-language:references :to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MnbZCKEK8an+0PL7osjcKSGg3UUPjBXXf//jKVIlbdw=; b=J3obWUKasX9IwVhpP+Pau7A2xibe6lRE+eaXqu+wn9le4Di/qZnr9spJM37kTx5mSS lCBq2vShp4sDsRFG9U9PIYGD9HwNCR6Qx9wwI4w3gKw9bh3fVJbMqB2ZqEjRvTAvKh65 MrTXN/K94HhszfrMkdaaTZ1SryfyhUyE8nbXI3uYYpvg+non0IGY9yl2PkMgxlh0EVBP uum2l6DaoqWI+vvTUyoSs3C5646VzVWDrdh5FeG7+E55p+yjJU60H1ycbSpc3TJkmSkp wcmokxrAzOVVVf5r4r3inQ93mWffjv+0OZZFP/QU0zdawdbHMzKfZXh5vVdFnJ1h9s+r LUvg== X-Forwarded-Encrypted: i=1; AJvYcCWzdfeB7uOkcmojnjLndPqH1LS5YbGSitTd5RlerIG2WkmlIjbprzoa0NycOvbeYRnnxyZsdrsCl6Uh+zV8@postgresql.org X-Gm-Message-State: AOJu0YzjqLD3mqS58MPVPzFDuwT+Esxk3c8SVXQJ7Ydct9odx17hySX0 AXkNPCHrkSkShozptYYYSxCh2796QQ7+Vpo/2octe9GDR5yEjlOR X-Gm-Gg: ASbGncsKqnXJOoxF3kgk8z81n+g7yOLL7M0N3GzWEe6QKZ5VOzAaqiMKJkKco0A8Fsy PVNkOnIk5F8FSO1XGnvnR6LBur1WzimKRiIeOAirDK9IYZaBmq83uhzTLpYW+PZxVhjleaWh0GW fBAFRBoghUW1/0fVESxdT6ITHVZgBR8+Z3mFdDPjVV6bF/ChsoEK8ARwA2OhuG697gJ0CACKcdd A5EV29EAoak8FtnQiWimJDjlPHvch60aeRX6OqRIzNdsy+YalThEa/gIyJdYORi968XCcSFZr2R pHKl+W2D76KowEBsA2AlJq1gOeCCfO1dIkilp1Wohqfm6LSdzk+ae+CbkvDfn4ST72NyK3e/THy bgEvFQmo4rnWP6MtLKp4dnDRUdoM= X-Google-Smtp-Source: AGHT+IGpi4FORbvZCGmzQ15asWYA9p3Bt3IHHAc94wonGEiVDrAwayYa21Ey8Dvu4WSxs40Z5fN9qQ== X-Received: by 2002:a05:6512:3046:b0:545:f4b:ed58 with SMTP id 2adb3069b0e04-549ababc77amr3474966e87.18.1741807977781; Wed, 12 Mar 2025 12:32:57 -0700 (PDT) Received: from [192.168.50.127] (broadband-188-255-2-52.ip.moscow.rt.ru. [188.255.2.52]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5498b0bcf82sm2199282e87.154.2025.03.12.12.32.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Mar 2025 12:32:57 -0700 (PDT) Message-ID: Date: Wed, 12 Mar 2025 22:32:57 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Optimization for lower(), upper(), casefold() functions. From: Alexander Borisov To: Jeff Davis , Heikki Linnakangas , pgsql-hackers@postgresql.org References: <7cac7e66-9a3b-4e3f-a997-42aa0c401f80@gmail.com> <2a1b632e-4531-43cf-a6d9-51cc1a271dc1@gmail.com> <7ab9d255-d7c0-4841-96c3-ed3ce9aa4abd@iki.fi> <12956299-1496-4455-b3ab-299cc0a87d7c@gmail.com> <340f2451-cd76-487b-a1e4-0f0a2fe91fba@gmail.com> <3ffb8b75b26e76624668c0883cac7886468c5d07.camel@j-davis.com> <5cf176fa-44b9-4019-b9b7-ee902352a844@gmail.com> <3080de9bcce916cf8720ac197f634e381c4de564.camel@j-davis.com> <1e3f4f6f-9b12-4109-b0d2-a4c52b5064f8@gmail.com> <4f3772355e038acd3cfe0be43ae2c1aacae1794d.camel@j-davis.com> Content-Language: ru In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk 12.03.2025 19:55, Alexander Borisov wrote: [...] >> A couple questions: >> >> * Is there a reason the fast-path for codepoints < 0x80 is in >> unicode_case.c rather than unicode_case_func.h? > > Yes, this is an important optimization, below are benchmarks that [...] I forgot to add the benchmark: Benchmark Anatation: Patch v3j_0001: patch v3j_0001 without any changes. Patch v3j_0001 + static: patch v3j_0001 with adding static to casemap(). Patch v3j_0001 + static + fast path: patch v3j_0001 with adding static to casemap() and fast path for codepoint < 0x80. v4_0001: v3j_0001 + static + fast path v4_0001 + v3j_0002: v3j_0002 patch unchanged, but with static for casemap() (inherited from v4_0001 patch) v4_0001 + v4_0002: changed fast path for codepoint < 0x80. Made fast return to avoid unnecessary checks. Without: current version of the code without any patches. All results are in tps. * macOS 15.1 (Apple M3 Pro) (Apple clang version 16.0.0) ASCII: Repeated characters (700kb) in the range from 0x20 to 0x7E. Patch v3j_0001: 201.029609 Patch v3j_0001 + static: 247.155438 Patch v3j_0001 + static + fast path: 267.941047 Patch v4_0001 + v3j_0002: 260.737601 Patch v4_0001 + v4_0002: 268.913658 Without: 260.437508 Cyrillic: Repeated characters (1MB) in the range from 0x0410 to 0x042F. Patch v3j_0001: 48.130350 Patch v3j_0001 + static: 49.365897 Patch v3j_0001 + static + fast path: 48.891842 Patch v4_0001 + v3j_0002: 88.833061 Patch v4_0001 + v4_0002: 88.329603 Without: 47.869687 Unicode: A query consisting of all Unicode characters from 0xA0 to 0x2FA1D (excluding 0xD800..0xDFFF). Patch v3j_0001: 91.333557 Patch v3j_0001 + static: 92.464786 Patch v3j_0001 + static + fast path: 91.359428 Patch v4_0001 + v3j_0002: 103.390609 Patch v4_0001 + v4_0002: 102.819763 Without: 92.279652 Regards, Alexander Borisov