Content-Type: multipart/alternative;
 boundary="------------gcpGKpSzAKvTmo1aNC5e0tEO"
Message-ID: <fe15d2b8-729f-4783-9d72-fdc3c9da0c2f@darold.net>
Date: Thu, 29 Jan 2026 16:39:54 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Pasword expiration warning
To: pgsql-hackers@lists.postgresql.org
References: <129bcfbf-47a6-e58a-190a-62fc21a17d03@migops.com>
 <MEAPR01MB3031D75330A64DD25A5B8A04B685A@MEAPR01MB3031.ausprd01.prod.outlook.com>
 <7aa9c67e-c423-43c4-89e8-4fbe8f5019d2@darold.net>
 <MEAPR01MB30311B76AFD06D3CAEAEF9C7B685A@MEAPR01MB3031.ausprd01.prod.outlook.com>
 <3002ddbd-64b5-499e-b15c-e1c1720cc356@darold.net>
 <MEAPR01MB303185AAA6F5BF90759D5E86B685A@MEAPR01MB3031.ausprd01.prod.outlook.com>
 <94634e38-7184-42a1-b9e1-7611076e1c08@darold.net>
 <MEAPR01MB303142AEB3F47886C171194EB682A@MEAPR01MB3031.ausprd01.prod.outlook.com>
 <CAD43U4WHJm=UkxbfhxQRxQRxtdtu7AGj77uO2fF78THQWCaYTg@mail.gmail.com>
 <MEAPR01MB30319B858B3028CA38BEDC5EB682A@MEAPR01MB3031.ausprd01.prod.outlook.com>
 <MN2PR15MB30212CEFE2F8B93C398FBF60A782A@MN2PR15MB3021.namprd15.prod.outlook.com>
 <MEAPR01MB30319C7BB75B88028E1DB7E1B682A@MEAPR01MB3031.ausprd01.prod.outlook.com>
 <f7d6e318-415a-4b98-86b0-28ae954707cc@darold.net>
 <f04d4dc5-c7a7-4987-bc20-4b97f45ab92d@app.fastmail.com>
Content-Language: en-US
From: Gilles Darold <gilles@darold.net>
Autocrypt: addr=gilles@darold.net; keydata=
 xsBNBEyscTYBCADOHjxbECHbFaVEA8fKAh8gtdRMKCXPhYwgrhIq+435c824l0NkxxT6xAq/
 U2embiCGSBy13yVT016bzcxOnOqxgw4dJgXPE1P6RYLgjd17c5Xt7uzkbn4ChO1LOVtx+7y/
 uf8GV1fiPTtnilzGQvWdXMDDTNaFbyfIsebE6rB2p47Ns0m+cj46hS22pmEWELM4RilmQ2MX
 X7vNZPxQ/C6SKQDgeGZSHrvw9OLzFty8yY7HnExfUmCzfN4asAH3q/lCu1YQgud84bCC6hXz
 Cbw/DvR7pW8QK/ej/UkNzeGUWsWX6GYDF26P3wO9Zqk5T8JixrveiCaWA/e4DR5yr2bTABEB
 AAHNIUdpbGxlcyBEYXJvbGQgPGdpbGxlc0BkYXJvbGQubmV0PsLAjgQTAQoAOBYhBEnFnv37
 SNFcBZKyn3AqzJ89qW5hBQJfxQsiAhsjBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEHAq
 zJ89qW5hjXsIAI53R1IdrgOia4DCtL1hK3+nbqPYYAhHAbQa54V/oHFEuXubH5F+mEBRT12M
 XNibbPvOCVUHTa46CuYLyBY6GZZ83fYpPZ3IQIavCDiLmpANR7rOoVmGERKs8VLVnQuJ1a+q
 BObwo1WKOFiqR1UEeT3hfytsmJVan8l2GzNFA+OOwIGEPdLLEpuSO9K3uyEa5FMNxXVWDROR
 MIHWvcS/RLlJby9GgLUIbLCXYXNrxncQajPs4P/TLS7fsW36laBPHIBoGbIBkgGIlpXhuTj2
 PY95YOfyFelXW3AL6oXOncmV9SkfaE2iIpc33FIrN3pEbIC4XEqMANKjidFXcdM3+JfOwE0E
 TKxxNgEIALVvukwz2p2Vw37pnMk2CGWCgoj76Lnts/3sG42Jw6Ewjvjg7u9SGg2fJJ4dzywc
 oBW5ufJlZalghO3RpbZqDwT2432CUdGG500GLLzYrHIhGBw8h9SkoJqnfel3MOjGy/HZMymK
 mCy/uqx3ti3Tp0l0Is38C7GK/lG3NKnYUwQuFaM2pDkIoIx3hyogGXEMwV+IHtYpvFroCBVi
 CgkYubsOEfqJti40BMXJfKv74ecDk43I7x9V6Pzt0j0rfmj4vFbSKHF6ptJNeZBrXrNSeTmf
 AJXaPD/olDLEStWu6cr5XyMmYxYE9D2eMOQHhFb7UOZdh++HhWcPxMMyKNNB2YsAEQEAAcLA
 XwQYAQIACQUCTKxxNgIbDAAKCRBwKsyfPaluYZETB/91iP031oHNFMU62RC8x+bERW5x6Dpu
 7Kk9rOSKf7ChcSWElBQ2A7OnNAACgPNbJgYyuEquYHTdXLP43phNDJ93EhL+af5z2BLx1gkd
 V+1rotlzbzIaUv9uofRWU6UJ/emgL3kn1TRmf3PKWWgJkHRlePqKDeNVc53uApbXHoNrS4ul
 uiwD88mx3+xgZqteCQO2DhEpAckzki82S4n4Ww6fRFB3KIGyafO7fzHFK8cFuT4za4YUFQN9
 Ix6WTABleoRLz3Cn+Jde049Zhg1222l0N07KWRS3ZZxAhwr3rv+pg3cJdbNf/rDszym92rig
 79SbGEEuL3nFCUXmA/QRIE+v
In-Reply-To: <f04d4dc5-c7a7-4987-bc20-4b97f45ab92d@app.fastmail.com>
Archived-At: <https://www.postgresql.org/message-id/fe15d2b8-729f-4783-9d72-fdc3c9da0c2f%40darold.net>
Precedence: bulk

This is a multi-part message in MIME format.
--------------gcpGKpSzAKvTmo1aNC5e0tEO
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Le 28/01/2026 à 13:44, Euler Taveira a écrit :
> On Fri, Jan 9, 2026, at 8:27 AM, Gilles Darold wrote:
>> Here is a v11 version of the patch.
>>
> +           if (result <= (TimestampTz) password_expire_warning)
> +           {
> +               MyClientConnectionInfo.warning_message =
> +                   psprintf(_("your password will expire in %d day(s)"),
> +                            (int) (result / SECS_PER_DAY));
> +           }
>
> You should use ngettext() for plural forms.

Is it a use we must do now or a wish?

    $ grep -r "ngettext(" src/backend/ | wc -l
    9
    $ grep -r "(s)" src/backend/ | wc -l
    831

If this is not a must do now, I prefer to use the old way because we 
don't have to repeat 2 times the constant.


> I don't think you need a string into ClientConnectionInfo. Instead, you could store only the number of days.
>
> +   /*
> +    * Emit a warning message to the client when set, for example
> +    * to warn the user that the password will expire.
> +    */
> +   if (MyClientConnectionInfo.warning_message)
> +       ereport(WARNING, (errmsg("%s", MyClientConnectionInfo.warning_message)));
> +
>
> ... and you construct the message directly in the ereport().


I have explained this choice in my first message:

"I have chosen to add a new field, const char *warning_message, to 
struct ClientConnectionInfo so that it can be used to send other 
messages to the client at end of connection ( 
src/backend/utils/init/postinit.c: InitPostgres() ). Not sure sure that 
this is the best way to do that but as it is a message dedicated to the 
connection I've though it could be the right place. If we don't expect 
other warning message sent to the client at connection time, just using 
an integer for the number of days remaining will be enough. We could use 
notice but it is not logged by default and also I think that warning is 
the good level for this message. "

-- 
Gilles Darold
http://hexacluster.ai/

--------------gcpGKpSzAKvTmo1aNC5e0tEO
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <div class="moz-cite-prefix">Le 28/01/2026 à 13:44, Euler Taveira a
      écrit :<br>
    </div>
    <blockquote type="cite"
      cite="mid:f04d4dc5-c7a7-4987-bc20-4b97f45ab92d@app.fastmail.com">
      <pre wrap="" class="moz-quote-pre">On Fri, Jan 9, 2026, at 8:27 AM, Gilles Darold wrote:
</pre>
      <blockquote type="cite">
        <pre wrap="" class="moz-quote-pre">
Here is a v11 version of the patch.

</pre>
      </blockquote>
      <pre wrap="" class="moz-quote-pre">
+           if (result &lt;= (TimestampTz) password_expire_warning)
+           {
+               MyClientConnectionInfo.warning_message =
+                   psprintf(_("your password will expire in %d day(s)"),
+                            (int) (result / SECS_PER_DAY));
+           }

You should use ngettext() for plural forms.</pre>
    </blockquote>
    <br>
    <p>Is it a use we must do now or a wish? </p>
    <blockquote>
      <p>$ grep -r "ngettext(" src/backend/ | wc -l<br>
        9<br>
        $ grep -r "(s)" src/backend/ | wc -l<br>
        831</p>
    </blockquote>
    <p>If this is not a must do now, I prefer to use the old way because
      we don't have to repeat 2 times the constant.</p>
    <p><br>
    </p>
    <blockquote type="cite"
      cite="mid:f04d4dc5-c7a7-4987-bc20-4b97f45ab92d@app.fastmail.com">
      <pre wrap="" class="moz-quote-pre">I don't think you need a string into ClientConnectionInfo. Instead, you could store only the number of days.

+   /*
+    * Emit a warning message to the client when set, for example
+    * to warn the user that the password will expire.
+    */
+   if (MyClientConnectionInfo.warning_message)
+       ereport(WARNING, (errmsg("%s", MyClientConnectionInfo.warning_message)));
+

... and you construct the message directly in the ereport().</pre>
    </blockquote>
    <p><br>
    </p>
    <p>I have explained this choice in my first message:</p>
    <p>"I have chosen to add a new field, const char *warning_message,
      to struct ClientConnectionInfo so that it can be used to send
      other messages to the client at end of connection (
      src/backend/utils/init/postinit.c: InitPostgres() ). Not sure sure
      that this is the best way to do that but as it is a message
      dedicated to the connection I've though it could be the right
      place. If we don't expect other warning message sent to the client
      at connection time, just using an integer for the number of days
      remaining will be enough. We could use notice but it is not logged
      by default and also I think that warning is the good level for
      this message. "</p>
    <pre class="moz-signature" cols="72">-- 
Gilles Darold
<a class="moz-txt-link-freetext" href="http://hexacluster.ai/">http://hexacluster.ai/</a></pre>
  </body>
</html>

--------------gcpGKpSzAKvTmo1aNC5e0tEO--