Message-ID: <fe32d2a0-0998-d866-d6ee-2aed70b9be00@iki.fi>
Date: Mon, 2 Oct 2023 12:19:29 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: Show various offset arrays for heap WAL records
Content-Language: en-US
To: Melanie Plageman <melanieplageman@gmail.com>
Cc: Peter Geoghegan <pg@bowt.ie>, Andres Freund <andres@anarazel.de>,
 pgsql-hackers@postgresql.org, Robert Haas <robertmhaas@gmail.com>,
 Peter Eisentraut <peter.eisentraut@enterprisedb.com>
References: 
 <CAAKRu_b2oE4GL=q4g9mcByS9yT7wTQvEH9OLpabj28e+WKFi2A@mail.gmail.com>
 <CAH2-WzkbYuvwYKm-Y-72QEh6SPMQcAo9uONv+mR3bMGcu9E_Cg@mail.gmail.com>
 <CAH2-Wz=pNYtxiJ2Jx5Lj=fKo1OEZ4GE0p_kct+ugAUTqBwU46g@mail.gmail.com>
 <CAAKRu_ZvGUSuy-RTzRg7VVC_oiTyS=LduHSaKr1h+6Pn82KGAQ@mail.gmail.com>
 <CAH2-WzmPRRNzH6Z7TiP2OqokPiQunFayEXeD9WbYV5ZErPiKZw@mail.gmail.com>
 <20230411002315.oyaicmcqrq2hb3ek@liskov>
 <CAH2-Wznr-CkJ9WYWRXJQfDH9xRBnhVyC7OV0jDob23_u7Tox7A@mail.gmail.com>
 <CAAKRu_YsTdLoJ1mX_yPAdPhGEWFD-KR--1foi7386HHB1iqxng@mail.gmail.com>
 <CAH2-WzkpdnkNd8eAqkM-QNH67gxns0wSt2EufU+DMSgLAwM5ow@mail.gmail.com>
 <CAH2-WznbeqNJtVV5s72Rz-OYv-ML7tycKjD0tRfWizaiZTZHDw@mail.gmail.com>
 <CAH2-Wzny=-9y6Cf0cRY0JTSfA50m6+o7zdm-Cc-nrP3d=3A4UQ@mail.gmail.com>
 <CAAKRu_Z7CsF-KNGhgd-1oD-1q2pYQQm_7fSMns=J42bdWK_2Mw@mail.gmail.com>
 <CAH2-Wzn5Bo47OJgxJRKq20dSnmFkQA1THJhd_kX+1Oy5CtbAGA@mail.gmail.com>
 <9159daf7-f42d-781b-458f-1b2cf32cb256@iki.fi>
 <CAAKRu_aUtMSAwijJzGRCeVtoraxenX1UgJehrWFMXhYQL7poqA@mail.gmail.com>
From: Heikki Linnakangas <hlinnaka@iki.fi>
In-Reply-To: 
 <CAAKRu_aUtMSAwijJzGRCeVtoraxenX1UgJehrWFMXhYQL7poqA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/fe32d2a0-0998-d866-d6ee-2aed70b9be00%40iki.fi>
Precedence: bulk

On 04/09/2023 23:02, Melanie Plageman wrote:
> I might phrase the last bit as "neither the description functions nor
> the output format should be considered part of a stable API"
> 
> +Guidelines for rmgrdesc output format
> +=====================================
> 
> I noticed you used === for both headings and wondered if it was
> intentional. Other READMEs I looked at in src/backend/access tend to
> have a single heading underlined with ==== and then subsequent
> headings are underlined with -----. I could see an argument either way
> here, but I just thought I would bring it up in case it was not a
> conscious choice.
> 
> Otherwise, LGTM.

Made these changes and committed. Thank you!

-- 
Heikki Linnakangas
Neon (https://neon.tech)