MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Thu, 17 Apr 2025 23:27:42 +0900
From: torikoshia <torikoshia@oss.nttdata.com>
To: Rahila Syed <rahilasyed90@gmail.com>, m.melihmutlu@gmail.com
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Align memory context level numbering in
 pg_log_backend_memory_contexts()
In-Reply-To: 
 <CAH2L28sk1ORSrL8oXQRe59O5HQV5CPJ4j0MuHfbzjcwPXqN-_g@mail.gmail.com>
References: <395ea5d4fe190480efa95bf533485c70@oss.nttdata.com>
 <CAApHDvpE6JS9F5kg+W4+p9TsiqFsPE+6XqEtD0P0HKNBoa9tYA@mail.gmail.com>
 <81B10568-B4A1-46C0-9809-2F8E06AB8C7B@yesql.se>
 <f56063dfad48f5121e5ab733b36ec46d@oss.nttdata.com>
 <CAApHDvrAQPuwOe5KZ9Kb3Lo68eQJJxaJW5_bBCf4-FwudNy2Sg@mail.gmail.com>
 <CAH2L28sk1ORSrL8oXQRe59O5HQV5CPJ4j0MuHfbzjcwPXqN-_g@mail.gmail.com>
User-Agent: Roundcube Webmail/1.4.11
Message-ID: <fe60f073a7f646239f1a273f21bebf03@oss.nttdata.com>
Archived-At: 
 <https://www.postgresql.org/message-id/fe60f073a7f646239f1a273f21bebf03%40oss.nttdata.com>
Precedence: bulk

Thanks for your review, Melih and Rahila.

On 2025-04-17 21:25, Rahila Syed wrote:
> Hi,
> 
>> The attached patch is how I think we should do it.
> 
> Thank you for the patch.
> I tested this patch and it works fine. I agree with the changes made
> in it.
> 
> Regarding v2 patch,
> -                       int                     level = 0;
> 
> Retaining the level variable will enhance the code readability, IMO.

As for the level variable, this change comes from the v1 patch, and I 
don't have a strong opinion about it.
However, if we decide to keep the level variable here, it might be more 
consistent to also define it in MemoryContextStatsDetail().


-- 
Regards,

--
Atsushi Torikoshi
Seconded from NTT DATA GROUP CORPORATION to SRA OSS K.K.