Feedback-ID: ie0a040ee:Fastmail
Message-ID: <fe6fafd1-8bf3-9307-b1d0-e5074722452a@eisentraut.org>
Date: Mon, 3 Jul 2023 08:13:40 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.12.0
Subject: Re: Make uselocale protection more consistent
Content-Language: en-US
To: Tristan Partin <tristan@neon.tech>, pgsql-hackers@postgresql.org
References: <CTNITWIN1G6L.CFIPH8SYNQQW@gonk>
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <CTNITWIN1G6L.CFIPH8SYNQQW@gonk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/fe6fafd1-8bf3-9307-b1d0-e5074722452a%40eisentraut.org>
Precedence: bulk

On 27.06.23 17:02, Tristan Partin wrote:
> This is a patch which implements an issue discussed in bug #17946[0]. It
> doesn't fix the overarching issue of the bug, but merely a consistency
> issue which was found while analyzing code by Heikki. I had originally
> submitted the patch within that thread, but for visibility and the
> purposes of the commitfest, I have re-sent it in its own thread.
> 
> [0]: https://www.postgresql.org/message-id/49dfcad8-90fa-8577-008f-d142e61af46b@iki.fi

I notice that HAVE_USELOCALE was introduced much later than 
HAVE_LOCALE_T, and at the time the code was already using uselocale(), 
so perhaps the introduction of HAVE_USELOCALE was unnecessary and should 
be reverted.

I think it would be better to keep HAVE_LOCALE_T as encompassing any of 
the various locale_t-using functions, rather than using HAVE_USELOCALE 
as a proxy for them.  Otherwise you create weird situations like having 
#ifdef HAVE_WCSTOMBS_L inside #ifdef HAVE_USELOCALE, which doesn't make 
sense, I think.