Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oihGN-0005Rs-Ak for pgsql-hackers@arkaria.postgresql.org; Wed, 12 Oct 2022 19:19:31 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oihGL-0003jy-6w for pgsql-hackers@arkaria.postgresql.org; Wed, 12 Oct 2022 19:19:29 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oihGK-0003iu-7U for pgsql-hackers@lists.postgresql.org; Wed, 12 Oct 2022 19:19:28 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oihGF-0000oB-4Y for pgsql-hackers@lists.postgresql.org; Wed, 12 Oct 2022 19:19:27 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 043175C0081; Wed, 12 Oct 2022 15:19:21 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 12 Oct 2022 15:19:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1665602361; x= 1665688761; bh=PKtLdZt8qzPWhJ98Kyk/fqB7CjOa1c6Ro06fPtBlko4=; b=E 1k8QgYdi56YboEF9etL5dz5ZpNvNBOFlXW9P072mHIcu2OuNgso6KvvB7qsV8QZD XtMUigyn9Al3Umz09+v0Hpy3DbYO0cljfnretxCnvBkdq9YWF5+dktnmkZ5hSN2t KcZGUm04LniAdftjbF9m7xcfmV4UWfBdRVudvKUdfALuvEWBPkItxp6rt1bHELd8 NXnp5QJHQMKTMLRWnRWe9omoShHwcwYRkGuMVtYoUqSRmM7dtUswSkyQ+eXnpqwY wkmJ11nALrRkGByb6CNeHBEEXcpCJoPKo2dAyxffeOB3XAm2qf2sSTyvxpjxtETW U7QsAeK9cxBTI40Ifuglw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeejkedgudefjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomheprfgv thgvrhcugfhishgvnhhtrhgruhhtuceophgvthgvrhdrvghishgvnhhtrhgruhhtsegvnh htvghrphhrihhsvggusgdrtghomheqnecuggftrfgrthhtvghrnhepheelffeggedujeet iefhleetuddvieffhfffvdejvdffgeejkeduleduheduieefnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepphgvthgvrhdrvghishgvnhhtrhgr uhhtsegvnhhtvghrphhrihhsvggusgdrtghomh X-ME-Proxy: Feedback-ID: i131946ab:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 12 Oct 2022 15:19:19 -0400 (EDT) Message-ID: Date: Wed, 12 Oct 2022 21:19:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: Simplifying our Trap/Assert infrastructure Content-Language: en-US To: Nathan Bossart , Tom Lane Cc: pgsql-hackers@lists.postgresql.org References: <3928703.1665345117@sss.pgh.pa.us> <20221009210148.GA900071@nathanxps13> <20221012183620.GA1447761@nathanxps13> From: Peter Eisentraut In-Reply-To: <20221012183620.GA1447761@nathanxps13> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 12.10.22 20:36, Nathan Bossart wrote: > On Sun, Oct 09, 2022 at 02:01:48PM -0700, Nathan Bossart wrote: >> The patch LGTM. It might be worth removing usages of AssertArg and >> AssertState, too, but that can always be done separately. > > If you are so inclined... I'm in favor of this. These variants are a distraction.