Content-Type: multipart/mixed; boundary="------------x122b0ur8gYKdBUf1fpG66YG"
Message-ID: <fea4190e-f8b5-4432-a52d-bcbee5f34366@postgrespro.ru>
Date: Tue, 16 Jun 2026 15:01:15 +0700
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: pgsql-hackers <pgsql-hackers@lists.postgresql.org>
Content-Language: en-US
From: Sergey Tatarintsev <s.tatarintsev@postgrespro.ru>
Subject: 004_timeline_switch TAP test may fail
Archived-At: 
 <https://www.postgresql.org/message-id/fea4190e-f8b5-4432-a52d-bcbee5f34366%40postgrespro.ru>
Precedence: bulk

This is a multi-part message in MIME format.
--------------x122b0ur8gYKdBUf1fpG66YG
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi hackers!

I found that after commit 7185eddf0522b3146ed1ff6e063e8e129e77c706 we 
got little omission
in TAP test 004_timeline_switch:
...
my $node_standby_1 = PostgreSQL::Test::Cluster->new('standby_1');
...
$node_primary->stop;

There is no guarantee that standby_1 and standby_2 was successfully 
connected to primary and start
streaming before primary stopped.

  I think we must ensure that primary knows about standby_1 and standby_2

-- 
With best regards,
Sergey Tatarintsev,
PostgresPro

--------------x122b0ur8gYKdBUf1fpG66YG
Content-Type: text/x-patch; charset=UTF-8;
 name="0001-Fix-004_timeline_switch-TAP-test-wait-for-standbys-s.patch"
Content-Disposition: attachment;
 filename*0="0001-Fix-004_timeline_switch-TAP-test-wait-for-standbys-s.pa";
 filename*1="tch"
Content-Transfer-Encoding: base64

RnJvbSBjZWRlNjJlOGRhMTQ0MWYwZWQyYWJmOWMyM2Y3MDczZGVmZjZkODM4IE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBTZXJnZXkgVGF0YXJpbnRzZXYgPHMudGF0YXJpbnRz
ZXZAcG9zdGdyZXNwcm8ucnU+CkRhdGU6IFR1ZSwgMTYgSnVuIDIwMjYgMTE6NTc6MzkgKzA3
MDAKU3ViamVjdDogW1BBVENIXSBGaXggMDA0X3RpbWVsaW5lX3N3aXRjaCBUQVAgdGVzdDog
d2FpdCBmb3Igc3RhbmRieXMgc3RhcnRzCiBiZWZvcmUgcHJpbWFyeSBzdG9wcwoKLS0tCiBz
cmMvdGVzdC9yZWNvdmVyeS90LzAwNF90aW1lbGluZV9zd2l0Y2gucGwgfCA0ICsrKysKIDEg
ZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9zcmMvdGVzdC9y
ZWNvdmVyeS90LzAwNF90aW1lbGluZV9zd2l0Y2gucGwgYi9zcmMvdGVzdC9yZWNvdmVyeS90
LzAwNF90aW1lbGluZV9zd2l0Y2gucGwKaW5kZXggZTBiMzg1MTkyN2MuLjJjNDMyYjUwZTU0
IDEwMDY0NAotLS0gYS9zcmMvdGVzdC9yZWNvdmVyeS90LzAwNF90aW1lbGluZV9zd2l0Y2gu
cGwKKysrIGIvc3JjL3Rlc3QvcmVjb3ZlcnkvdC8wMDRfdGltZWxpbmVfc3dpdGNoLnBsCkBA
IC0zMCw2ICszMCwxMCBAQCAkbm9kZV9zdGFuZGJ5XzItPmluaXRfZnJvbV9iYWNrdXAoJG5v
ZGVfcHJpbWFyeSwgJGJhY2t1cF9uYW1lLAogCWhhc19zdHJlYW1pbmcgPT4gMSk7CiAkbm9k
ZV9zdGFuZGJ5XzItPnN0YXJ0OwogCisjIFdhaXQgZm9yIHN0YW5kYnlfMSBhbmQgc3RhbmRi
eV8yIHN0YXJ0cworJG5vZGVfcHJpbWFyeS0+cG9sbF9xdWVyeV91bnRpbCgncG9zdGdyZXMn
LAorCSJTRUxFQ1QgY291bnQoMSkgPSAyIEZST00gcGdfc3RhdF9yZXBsaWNhdGlvbiIpOwor
CiAjIENyZWF0ZSBzb21lIGNvbnRlbnQgb24gcHJpbWFyeQogJG5vZGVfcHJpbWFyeS0+c2Fm
ZV9wc3FsKCdwb3N0Z3JlcycsCiAJIkNSRUFURSBUQUJMRSB0YWJfaW50IEFTIFNFTEVDVCBn
ZW5lcmF0ZV9zZXJpZXMoMSwxMDAwKSBBUyBhIik7Ci0tIAoyLjQzLjAKCg==

--------------x122b0ur8gYKdBUf1fpG66YG--