Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iAG0x-0003Cd-G3 for pgsql-hackers@arkaria.postgresql.org; Tue, 17 Sep 2019 16:07:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iAG0v-0007ZC-8q for pgsql-hackers@arkaria.postgresql.org; Tue, 17 Sep 2019 16:07:37 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iAG0u-0007Z2-Vq for pgsql-hackers@lists.postgresql.org; Tue, 17 Sep 2019 16:07:37 +0000 Received: from cyclops.postgrespro.ru ([93.174.131.138] helo=mail.postgrespro.ru) by magus.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iAG0r-00068x-Qn for pgsql-hackers@lists.postgresql.org; Tue, 17 Sep 2019 16:07:36 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.postgrespro.ru (Postfix) with ESMTP id 53A0921C288A; Tue, 17 Sep 2019 19:07:32 +0300 (MSK) X-Virus-Scanned: Debian amavisd-new at postgrespro.ru X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=x tagged_above=-99 required=4 WHITELISTED tests=[] autolearn=unavailable Received: from mail.postgrespro.ru (cyclops.l.postgrespro.ru [192.168.27.1]) by mail.postgrespro.ru (Postfix) with ESMTP id 216FA21C2874; Tue, 17 Sep 2019 19:07:32 +0300 (MSK) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_b20b42f93b2fb6ee2e5f706d2cdd12da" Date: Tue, 17 Sep 2019 19:07:31 +0300 From: Marina Polyakova To: pgsql-hackers@lists.postgresql.org Cc: Victor Wagner Subject: pg_upgrade check fails on Solaris 10 Organization: Postgres Professional Message-ID: X-Sender: m.polyakova@postgrespro.ru User-Agent: Roundcube Webmail/1.3.8 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --=_b20b42f93b2fb6ee2e5f706d2cdd12da Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed Hello, hackers! We got an error for pg_upgrade check on the branch REL_11_STABLE (commit 40ad4202513c72f5c1beeb03e26dfbc8890770c0) on Solaris 10 because IIUC the argument to the sed command is not enclosed in quotation marks (see [1]): $ gmake -C src/bin/pg_upgrade/ check <...> MAKE=gmake bindir="/home/buildfarm/mpolyakova/postgrespro_REL_11_STABLE/inst/bin" libdir="/home/buildfarm/mpolyakova/postgrespro_REL_11_STABLE/inst/lib" EXTRA_REGRESS_OPTS="" /bin/sh test.sh --install test.sh: MSYS/MINGW/: not found gmake: *** [check] Error 1 gmake: Leaving directory `/home/buildfarm/mpolyakova/postgrespro_REL_11_STABLE/src/bin/pg_upgrade' $ sed: command garbled: s/ Attached diff.patch fixes the problem. About the system: SunOS, Release 5.10, KernelID Generic_141444-09. About the used shell: according to the manual, it comes from the package SUNWcsu. Thanks to Victor Wagner for his help to investigate this issue. [1] $ man sh <...> Quoting The following characters have a special meaning to the shell and cause termination of a word unless quoted: ; & ( ) | ^ < > newline space tab -- Marina Polyakova Postgres Professional: http://www.postgrespro.com The Russian Postgres Company --=_b20b42f93b2fb6ee2e5f706d2cdd12da Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=diff.patch Content-Disposition: attachment; filename=diff.patch; size=520 ZGlmZiAtLWdpdCBhL3NyYy9iaW4vcGdfdXBncmFkZS90ZXN0LnNoIGIvc3JjL2Jpbi9wZ191cGdy YWRlL3Rlc3Quc2gKaW5kZXggNDI0ZDg5YzNmZWVjZWQ5MTUzMTkyMGU5MTlhMmQ5ZTA2Y2M0YmFh Ni4uZjI1ODk4M2IxOGY4Mjc2Y2ZlZjNkYjBhNDI1ZDU5ZmVhZDY0OTNkOSAxMDA2NDQKLS0tIGEv c3JjL2Jpbi9wZ191cGdyYWRlL3Rlc3Quc2gKKysrIGIvc3JjL2Jpbi9wZ191cGdyYWRlL3Rlc3Qu c2gKQEAgLTMzLDcgKzMzLDcgQEAgc3RhbmRhcmRfaW5pdGRiKCkgewogCiAjIFdoYXQgZmxhdm9y IG9mIGhvc3QgYXJlIHdlIG9uPwogIyBUcmVhdCBNSU5HVyogKG1zeXMxKSBhbmQgTVNZUyogKG1z eXMyKSB0aGUgc2FtZS4KLXRlc3Rob3N0PWB1bmFtZSAtcyB8IHNlZCBzL15NU1lTL01JTkdXL2AK K3Rlc3Rob3N0PWB1bmFtZSAtcyB8IHNlZCAncy9eTVNZUy9NSU5HVy8nYAogCiAjIEVzdGFibGlz aCBob3cgdGhlIHNlcnZlciB3aWxsIGxpc3RlbiBmb3IgY29ubmVjdGlvbnMKIGNhc2UgJHRlc3Ro b3N0IGluCg== --=_b20b42f93b2fb6ee2e5f706d2cdd12da--