Feedback-ID: ie0a040ee:Fastmail
Content-Type: multipart/mixed; boundary="------------TwLQJ7J8376vv0DSxOzndwXq"
Message-ID: <ff129805-1516-478a-a438-145880165c58@eisentraut.org>
Date: Fri, 13 Mar 2026 11:43:15 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Change copyObject() to use typeof_unqual
To: Jelte Fennema-Nio <postgres@jeltef.nl>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
References: <92f9750f-c7f6-42d8-9a4a-85a3cbe808f3@eisentraut.org>
 <a18378cc-69f5-4eaa-999b-1fcfc9b1ed7f@eisentraut.org>
 <b136156d-11d1-4db9-84db-28fd8c0aa756@eisentraut.org>
 <CAGECzQSxqAgF4YA_2C3mBKoTJ1-Mc3uVMAe2AgLjibnv4Ltkuw@mail.gmail.com>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: 
 <CAGECzQSxqAgF4YA_2C3mBKoTJ1-Mc3uVMAe2AgLjibnv4Ltkuw@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ff129805-1516-478a-a438-145880165c58%40eisentraut.org>
Precedence: bulk

This is a multi-part message in MIME format.
--------------TwLQJ7J8376vv0DSxOzndwXq
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 07.03.26 01:17, Jelte Fennema-Nio wrote:
> On Fri, 6 Mar 2026 at 20:17, Peter Eisentraut <peter@eisentraut.org> wrote:
>> This revealed an insufficiency in that commit, which I fix in the first
>> patch.
> 
> Thanks!

There is a failure related to this on buildfarm member sevengill:

../pgsql/src/test/modules/test_cplusplusext/test_cplusplusext.cpp:41:22: 
error: no template named 'remove_reference_t' in namespace 'std'; did 
you mean 'remove_reference'?

I don't know how that makes sense.  Maybe this is a problem in the local 
installation of the compiler or standard library.

(This is also a bit suspicious because AFAICT, clang 15 defaults to 
C++14, but on that animal it thinks it needs to add -std=gnu++11.)

>> I have addressed the above problem by swapping the order of the probes
>> (putting the underscore variant first), as discussed.
> 
> Annoying that this is needed, but I agree that it's the least bad
> option in this case.

I committed this and it still fails, but the failure is now narrower. 
There is a failure on buildfarm member taipan because it uses an unusual 
combination of gcc and clang (the gcc is much newer than clang).  The 
only sensible workaround I could think of is a hardcoded override based 
on the clang version, as in the attached patch.  And alternative is that 
we decide that we don't want to support this combination, meaning that 
we would effectively require that clang is approximately as-old-or-newer 
than gcc.

--------------TwLQJ7J8376vv0DSxOzndwXq
Content-Type: text/plain; charset=UTF-8;
 name="0001-Hardcode-override-of-typeof_unqual-for-clang-for-bit.patch"
Content-Disposition: attachment;
 filename*0="0001-Hardcode-override-of-typeof_unqual-for-clang-for-bit.pa";
 filename*1="tch"
Content-Transfer-Encoding: base64

RnJvbSA1Mjk1Y2JiMGE0NTczZWE4ODZmMjFkNGY1ZTg5Y2U3YmVhZjYwZjU4IE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy
YXV0Lm9yZz4KRGF0ZTogRnJpLCAxMyBNYXIgMjAyNiAxMToyMDozMSArMDEwMApTdWJqZWN0
OiBbUEFUQ0hdIEhhcmRjb2RlIG92ZXJyaWRlIG9mIHR5cGVvZl91bnF1YWwgZm9yIGNsYW5n
LWZvci1iaXRjb2RlCgpUaGUgZnVuZGFtZW50YWwgcHJvYmxlbSBpcyB0aGF0IHdoZW4gd2Ug
Y2FsbCBjbGFuZyB0byBnZW5lcmF0ZQpiaXRjb2RlLCB3ZSBtaWdodCBiZSB1c2luZyBjb25m
aWd1cmUgcmVzdWx0cyBmcm9tIGEgZGlmZmVyZW50CmNvbXBpbGVyLCB3aGljaCBtaWdodCBu
b3QgYmUgZnVsbHkgY29tcGF0aWJsZSB3aXRoIHRoZSBjbGFuZyB3ZSBhcmUKdXNpbmcuICBJ
biBwcmFjdGljZSwgY2xhbmcgc3VwcG9ydHMgbW9zdCB0aGluZ3Mgb3RoZXIgY29tcGlsZXJz
CnN1cHBvcnQsIHNvIHRoaXMgaGFzIGFwcGFyZW50bHkgbm90IGJlZW4gYSBwcm9ibGVtIGlu
IHByYWN0aWNlLgoKQnV0IGNvbW1pdHMgNGNmY2U0ZTYyYzgsIDBhZjA1YjVkYmI0LCBhbmQg
NTkyOTJmN2FhYzcgaGF2ZSBiZWVuCnN0cnVnZ2xpbmcgdG8gbWFrZSB0eXBlb2ZfdW5xdWFs
IHdvcmsgaW4gdGhpcyBzaXR1YXRpb24uICBDbGFuZyBhZGRlZApzdXBwb3J0IGluIHZlcnNp
b24gMTksIEdDQyBpbiB2ZXJzaW9uIDE0LCBzbyBpZiB5b3UgYXJlIHVzaW5nLCBzYXksCkdD
QyAxNCBhbmQgQ2xhbmcgMTYsIHRoZSBjb21waWxhdGlvbiB3aXRoIHRoZSBsYXR0ZXIgd2ls
bCBmYWlsLgpBZ2FpbiwgaW4gcHJhY3RpY2UsIHRoaXMgbWlnaHQgYmUgdW5saWtlbHksIGJl
Y2F1c2UgR0NDIDE0IGFuZCBDbGFuZwoxOSB3ZXJlIHJlbGVhc2VkIHdpdGhpbiBhIGZldyBt
b250aHMgb2YgZWFjaCBvdGhlciwgYW5kIHNvIExpbnV4CmRpc3RyaWJ1dGlvbnMgYXJlIGxp
a2VseSB0byBoYXZlIHN1aXRhYmxlIGNvbWJpbmF0aW9ucy4gIEJ1dCBidWlsZGZhcm0KbWVt
YmVyICJ0YWlwYW4iIGRvZXMgbm90IChnY2MgMTUsIGNsYW5nIDE2KSwgc28gSSdsbCB0cnkg
dG8gZml4IGl0LgoKVGhlIGZ1bGx5IGNvcnJlY3Qgc29sdXRpb24gd291bGQgYmUgdG8gcnVu
IGEgc2VwYXJhdGUgc2V0IG9mIGNvbmZpZ3VyZQp0ZXN0cyBmb3IgdGhhdCBjbGFuZy1mb3It
Yml0Y29kZSwgYnV0IHRoYXQgd291bGQgYmUgdmVyeSBkaWZmaWN1bHQgdG8KaW1wbGVtZW50
LCBhbmQgcHJvYmFibHkgb2YgbGltaXRlZCB1c2UgaW4gcHJhY3RpY2UuICBTbyB0aGUgd29y
a2Fyb3VuZApoZXJlIGlzIHRoYXQgd2UgaGFyZGNvZGVkbHkgb3ZlcnJpZGUgdGhlIGNvbmZp
Z3VyZSByZXN1bHQgdW5kZXIgY2xhbmcKYmFzZWQgb24gdGhlIHZlcnNpb24gbnVtYmVyLiAg
QXMgbG9uZyBhcyB3ZSBvbmx5IGhhdmUgYSBmZXcgb2YgdGhlc2UKY2FzZXMsIHRoaXMgc2hv
dWxkIGJlIG1hbmFnZWFibGUuCgpEaXNjdXNzaW9uOiBodHRwczovL3d3dy5wb3N0Z3Jlc3Fs
Lm9yZy9tZXNzYWdlLWlkL2ZsYXQvOTJmOTc1MGYtYzdmNi00MmQ4LTlhNGEtODVhM2NiZTgw
OGYzJTQwZWlzZW50cmF1dC5vcmcKLS0tCiBzcmMvaW5jbHVkZS9jLmggfCAxNSArKysrKysr
KysrKysrKysKIDEgZmlsZSBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0
IGEvc3JjL2luY2x1ZGUvYy5oIGIvc3JjL2luY2x1ZGUvYy5oCmluZGV4IDJhYWI3NGQ4YjBl
Li4yZTc4OWIwMDU5NCAxMDA2NDQKLS0tIGEvc3JjL2luY2x1ZGUvYy5oCisrKyBiL3NyYy9p
bmNsdWRlL2MuaApAQCAtNDMyLDYgKzQzMiwyMSBAQCBleHRlcm4gIkMrKyIKICNkZWZpbmUg
dW5saWtlbHkoeCkgKCh4KSAhPSAwKQogI2VuZGlmCiAKKy8qCisgKiBXaGVuIHdlIGNhbGwg
Y2xhbmcgdG8gZ2VuZXJhdGUgYml0Y29kZSwgd2UgbWlnaHQgYmUgdXNpbmcgY29uZmlndXJl
IHJlc3VsdHMKKyAqIGZyb20gYSBkaWZmZXJlbnQgY29tcGlsZXIsIHdoaWNoIG1pZ2h0IG5v
dCBiZSBmdWxseSBjb21wYXRpYmxlIHdpdGggdGhlCisgKiBjbGFuZyB3ZSBhcmUgdXNpbmcu
ICBUaGUgZnVsbHkgY29ycmVjdCBzb2x1dGlvbiB3b3VsZCBiZSB0byBydW4gYSBzZXBhcmF0
ZQorICogc2V0IG9mIGNvbmZpZ3VyZSB0ZXN0cyBmb3IgdGhhdCBjbGFuZy1mb3ItYml0Y29k
ZSwgYnV0IHRoYXQgY291bGQgYmUgdmVyeQorICogZGlmZmljdWx0IHRvIGltcGxlbWVudCwg
YW5kIGluIHByYWN0aWNlIGNsYW5nIHN1cHBvcnRzIG1vc3QgdGhpbmdzIG90aGVyCisgKiBj
b21waWxlcnMgc3VwcG9ydC4gIFNvIHRoaXMgc2VjdGlvbiBqdXN0IGNvbnRhaW5zIHNvbWUg
aGFyZGNvZGVkIHVnbGluZXNzCisgKiB0byBvdmVycmlkZSBzb21lIGNvbmZpZ3VyZSByZXN1
bHRzIHdoZXJlIGl0IGlzIG5lY2Vzc2FyeS4KKyAqLworI2lmIGRlZmluZWQoX19jbGFuZ19f
KQorI2lmIF9fY2xhbmdfbWFqb3JfXyA8IDE5CisjdW5kZWYgSEFWRV9UWVBFT0ZfVU5RVUFM
CisjZW5kaWYKKyNlbmRpZgkJCQkJCQkvKiBfX2NsYW5nX18gKi8KKwogLyoKICAqIFByb3Zp
ZGUgdHlwZW9mIGluIEMrKyBmb3IgQysrIGNvbXBpbGVycyB0aGF0IGRvbid0IHN1cHBvcnQg
dHlwZW9mIG5hdGl2ZWx5LgogICogSXQgbWlnaHQgYmUgc3BlbGxlZCBfX3R5cGVvZl9fIGlu
c3RlYWQgb2YgdHlwZW9mLCBpbiB3aGljaCBjYXNlCi0tIAoyLjUzLjAKCg==

--------------TwLQJ7J8376vv0DSxOzndwXq--