Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w61mP-003sH1-1k for pgsql-hackers@arkaria.postgresql.org; Fri, 27 Mar 2026 07:38:53 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1w61mO-0088D6-09 for pgsql-hackers@arkaria.postgresql.org; Fri, 27 Mar 2026 07:38:52 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w61mM-0088Cy-2s for pgsql-hackers@lists.postgresql.org; Fri, 27 Mar 2026 07:38:52 +0000 Received: from fhigh-a6-smtp.messagingengine.com ([103.168.172.157]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1w61mL-00000001HSQ-0fvk for pgsql-hackers@lists.postgresql.org; Fri, 27 Mar 2026 07:38:50 +0000 Received: from phl-compute-08.internal (phl-compute-08.internal [10.202.2.48]) by mailfhigh.phl.internal (Postfix) with ESMTP id AE51D140026F; Fri, 27 Mar 2026 03:38:47 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-08.internal (MEProxy); Fri, 27 Mar 2026 03:38:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eisentraut.org; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm3; t=1774597127; x= 1774683527; bh=Pu2G0lrD1Bl8fg0h/DsQdWFWvPV9BsOhAFAFo+e3QAI=; b=B w4K9/E11lG8L2ka3H0TOcU1USHpair0km/yZRB4jZs0rv9V4p5yi7L5KEhGyWxTr yAmBrvb/c9CveK7g8fy5P58EAyd8cFzP+HT0AFMFo8o/wnOjhi4MxN+kXqr64DxQ jUtITAlOGoOXj+t1Gpu8KgoxmcTm6hrGFR0/nrIj5Tl9i8tM6/7zdNATd3MHg37M jGV61rFo7/3zcF60yUees1+TiAp2oN5NcJOsuOTpGl2RFTM3pwmB1Npl5lLK5pam CVHjQDFDDg4VUtlmVWv4Pn5vy0oxblmUhybTu4Pxvt3xXfyj+bemiEi5EwyhDN7v hfVMRYGruh/HE8Eyh+MEg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1774597127; x=1774683527; bh=Pu2G0lrD1Bl8fg0h/DsQdWFWvPV9BsOhAFA Fo+e3QAI=; b=Ameuf+nAYzD5r+/3w2t5msIXyUBXwm6g21073Ox0mqBPeT3s6bR Nvis8DSoZbuIfFp54hu9CsTMAuc/5PSYNN4McGMmMLoiWmTYSS/ADCYrR0C7JopM 6rvZEypCgiMGkIBM6vFsTO+OdWCF8+IbqEP5YYh4uVewkGBf3r124gcP94eg0FfJ WzXYWFDsMDD4aXNJ4yr4So4PTuH+55yoQlcbJKVXIVa2B20IbqMPLw/ZT9R3+mHW 3u2j3zg4pE280+Pu1gVADQlgc5okdPxlDPPFfxWU91O7XY4uhZF5QouFLKkr+Zl0 3+NpNp3HeK7EFhlgdEILXxI8d+LAKOetObw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgdefvdeljedtucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucenucfjughrpegtkfffgggfuffvvehfhfgjsehmtderre dtvdejnecuhfhrohhmpefrvghtvghrucfgihhsvghnthhrrghuthcuoehpvghtvghrsegv ihhsvghnthhrrghuthdrohhrgheqnecuggftrfgrthhtvghrnhepkedtuedthfdvhfevie fgffetgedvjedvhffhveefvefgtdfgleegheeivefhgfeinecuvehluhhsthgvrhfuihii vgeptdenucfrrghrrghmpehmrghilhhfrhhomhepphgvthgvrhesvghishgvnhhtrhgruh htrdhorhhgpdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhuthdprhgtphht thhopegsvghrthhrrghnuggurhhouhhvohhtrdhpghesghhmrghilhdrtghomhdprhgtph htthhopehpghhsqhhlqdhhrggtkhgvrhhssehlihhsthhsrdhpohhsthhgrhgvshhqlhdr ohhrgh X-ME-Proxy: Feedback-ID: ie0a040ee:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 27 Mar 2026 03:38:46 -0400 (EDT) Content-Type: multipart/mixed; boundary="------------4HjMOLbpW0DjUmXaHwm83vq0" Message-ID: Date: Fri, 27 Mar 2026 08:38:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Enable -Wstrict-prototypes and -Wold-style-definition by default To: Bertrand Drouvot Cc: pgsql-hackers@lists.postgresql.org References: <44885d54-0376-46b3-b574-59e0e3098580@eisentraut.org> <4ab608af-2f90-47d8-88a5-6329f6630fff@eisentraut.org> Content-Language: en-US From: Peter Eisentraut In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------4HjMOLbpW0DjUmXaHwm83vq0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit The first three patches have been committed. On 24.03.26 08:16, Bertrand Drouvot wrote: > 0004: > > --- a/meson.build > +++ b/meson.build > @@ -2199,6 +2199,7 @@ unroll_loops_cflags = cc.get_supported_arguments(['-funroll-loops']) > > common_warning_flags = [ > '-Wmissing-prototypes', > + '-Wold-style-declaration', > > Nit, what about adding it with (as the comment is also accurate for the new one)? > > " > # These are C-only flags, supported in all C11-capable GCC/Clang versions. > cflags_warn += cc.get_supported_arguments(['-Wstrict-prototypes', '-Wold-style-definition']) > " Yeah, makes sense to collect the C-only flags together. But now that I'm looking at this again, the comment "supported in all C11-capable GCC/Clang versions" is not relevant here, it was only relevant in configure.ac because there we don't actually test for these flags but require them without testing. What do you think about the attached patch, which reorganizes this a bit more? --------------4HjMOLbpW0DjUmXaHwm83vq0 Content-Type: text/plain; charset=UTF-8; name="v3-0001-Add-warning-option-Wold-style-declaration.patch" Content-Disposition: attachment; filename="v3-0001-Add-warning-option-Wold-style-declaration.patch" Content-Transfer-Encoding: base64 RnJvbSBhZTNhMzRlNzYyYTdmOGFmMjJhMDcxOGY5MWQzOTIwMDY4OWMwN2UzIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy YXV0Lm9yZz4KRGF0ZTogRnJpLCAyNyBNYXIgMjAyNiAwODozNDozNyArMDEwMApTdWJqZWN0 OiBbUEFUQ0ggdjNdIEFkZCB3YXJuaW5nIG9wdGlvbiAtV29sZC1zdHlsZS1kZWNsYXJhdGlv bgoKVGhpcyB3YXJuaW5nIGhhcyBiZWVuIHRyaWdnZXJlZCBhIGZldyB0aW1lcyB2aWEgdGhl IGJ1aWxkZmFybSAoc2VlCmNvbW1pdHMgODIxMjYyNWU1M2YsIDJiNzI1OWY4NTU3LCBhZmU4 NmE5ZTczYiksIHNvIHdlIG1pZ2h0IGFzIHdlbGwKYWRkIGl0IHNvIHRoYXQgZXZlcnlvbmUg c2VlcyBpdC4KCihUaGlzIGlzIGNvbXBsZXRlbHkgc2VwYXJhdGUgZnJvbSB0aGUgcmVjZW50 bHkgYWRkZWQKLVdvbGQtc3R5bGUtZGVmaW5pdGlvbi4pCgpSZXZpZXdlZC1ieTogVG9tIExh bmUgPHRnbEBzc3MucGdoLnBhLnVzPgpSZXZpZXdlZC1ieTogQmVydHJhbmQgRHJvdXZvdCA8 YmVydHJhbmRkcm91dm90LnBnQGdtYWlsLmNvbT4KRGlzY3Vzc2lvbjogaHR0cHM6Ly93d3cu cG9zdGdyZXNxbC5vcmcvbWVzc2FnZS1pZC9mbGF0L2FhNzNxMWFUMEEzL3ZrZS8lNDBpcC0x MC05Ny0xLTM0LmV1LXdlc3QtMy5jb21wdXRlLmludGVybmFsCi0tLQogY29uZmlndXJlICAg IHwgNDEgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKIGNvbmZp Z3VyZS5hYyB8ICAyICsrCiBtZXNvbi5idWlsZCAgfCAxNCArKysrKysrKystLS0tLQogMyBm aWxlcyBjaGFuZ2VkLCA1MiBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQoKZGlmZiAt LWdpdCBhL2NvbmZpZ3VyZSBiL2NvbmZpZ3VyZQppbmRleCA4ZTBlNzQ4M2MxZC4uZDA1ODYw NWM3YWQgMTAwNzU1Ci0tLSBhL2NvbmZpZ3VyZQorKysgYi9jb25maWd1cmUKQEAgLTU1MjYs NiArNTUyNiw0NyBAQCBmaQogCiAKIAoreyAkYXNfZWNobyAiJGFzX21lOiR7YXNfbGluZW5v LSRMSU5FTk99OiBjaGVja2luZyB3aGV0aGVyICR7Q0N9IHN1cHBvcnRzIC1Xb2xkLXN0eWxl LWRlY2xhcmF0aW9uLCBmb3IgQ0ZMQUdTIiA+JjUKKyRhc19lY2hvX24gImNoZWNraW5nIHdo ZXRoZXIgJHtDQ30gc3VwcG9ydHMgLVdvbGQtc3R5bGUtZGVjbGFyYXRpb24sIGZvciBDRkxB R1MuLi4gIiA+JjY7IH0KK2lmICR7cGdhY19jdl9wcm9nX0NDX2NmbGFnc19fV29sZF9zdHls ZV9kZWNsYXJhdGlvbis6fSBmYWxzZTsgdGhlbiA6CisgICRhc19lY2hvX24gIihjYWNoZWQp ICIgPiY2CitlbHNlCisgIHBnYWNfc2F2ZV9DRkxBR1M9JENGTEFHUworcGdhY19zYXZlX0ND PSRDQworQ0M9JHtDQ30KK0NGTEFHUz0iJHtDRkxBR1N9IC1Xb2xkLXN0eWxlLWRlY2xhcmF0 aW9uIgorYWNfc2F2ZV9jX3dlcnJvcl9mbGFnPSRhY19jX3dlcnJvcl9mbGFnCithY19jX3dl cnJvcl9mbGFnPXllcworY2F0IGNvbmZkZWZzLmggLSA8PF9BQ0VPRiA+Y29uZnRlc3QuJGFj X2V4dAorLyogZW5kIGNvbmZkZWZzLmguICAqLworCitpbnQKK21haW4gKCkKK3sKKworICA7 CisgIHJldHVybiAwOworfQorX0FDRU9GCitpZiBhY19mbl9jX3RyeV9jb21waWxlICIkTElO RU5PIjsgdGhlbiA6CisgIHBnYWNfY3ZfcHJvZ19DQ19jZmxhZ3NfX1dvbGRfc3R5bGVfZGVj bGFyYXRpb249eWVzCitlbHNlCisgIHBnYWNfY3ZfcHJvZ19DQ19jZmxhZ3NfX1dvbGRfc3R5 bGVfZGVjbGFyYXRpb249bm8KK2ZpCitybSAtZiBjb3JlIGNvbmZ0ZXN0LmVyciBjb25mdGVz dC4kYWNfb2JqZXh0IGNvbmZ0ZXN0LiRhY19leHQKK2FjX2Nfd2Vycm9yX2ZsYWc9JGFjX3Nh dmVfY193ZXJyb3JfZmxhZworQ0ZMQUdTPSIkcGdhY19zYXZlX0NGTEFHUyIKK0NDPSIkcGdh Y19zYXZlX0NDIgorZmkKK3sgJGFzX2VjaG8gIiRhc19tZToke2FzX2xpbmVuby0kTElORU5P fTogcmVzdWx0OiAkcGdhY19jdl9wcm9nX0NDX2NmbGFnc19fV29sZF9zdHlsZV9kZWNsYXJh dGlvbiIgPiY1CiskYXNfZWNobyAiJHBnYWNfY3ZfcHJvZ19DQ19jZmxhZ3NfX1dvbGRfc3R5 bGVfZGVjbGFyYXRpb24iID4mNjsgfQoraWYgdGVzdCB4IiRwZ2FjX2N2X3Byb2dfQ0NfY2Zs YWdzX19Xb2xkX3N0eWxlX2RlY2xhcmF0aW9uIiA9IHgieWVzIjsgdGhlbgorICBDRkxBR1M9 IiR7Q0ZMQUdTfSAtV29sZC1zdHlsZS1kZWNsYXJhdGlvbiIKK2ZpCisKKworICAjIC1Xb2xk LXN0eWxlLWRlY2xhcmF0aW9uIGlzIG5vdCBhcHBsaWNhYmxlIGZvciBDKysKKwogICAjIFRv IHJlcXVpcmUgZmFsbHRocm91Z2ggYXR0cmlidXRlIGFubm90YXRpb25zLCB1c2UKICAgIyAt V2ltcGxpY2l0LWZhbGx0aHJvdWdoPTUgd2l0aCBnY2MgYW5kIC1XaW1wbGljaXQtZmFsbHRo cm91Z2ggd2l0aAogICAjIGNsYW5nLiAgVGhlIGxhdHRlciBpcyBhbHNvIGFjY2VwdGVkIG9u IGdjYyBidXQgZG9lcyBub3QgZW5mb3JjZQpkaWZmIC0tZ2l0IGEvY29uZmlndXJlLmFjIGIv Y29uZmlndXJlLmFjCmluZGV4IDJiYWFjNWU5ZGE3Li5jMjdhZmVlMTgyMiAxMDA2NDQKLS0t IGEvY29uZmlndXJlLmFjCisrKyBiL2NvbmZpZ3VyZS5hYwpAQCAtNTU1LDYgKzU1NSw4IEBA IGlmIHRlc3QgIiRHQ0MiID0geWVzIC1hICIkSUNDIiA9IG5vOyB0aGVuCiAgIFBHQUNfUFJP R19DWFhfQ0ZMQUdTX09QVChbLVdlcnJvcj11bmd1YXJkZWQtYXZhaWxhYmlsaXR5LW5ld10p CiAgIFBHQUNfUFJPR19DQ19DRkxBR1NfT1BUKFstV21pc3NpbmctZm9ybWF0LWF0dHJpYnV0 ZV0pCiAgIFBHQUNfUFJPR19DWFhfQ0ZMQUdTX09QVChbLVdtaXNzaW5nLWZvcm1hdC1hdHRy aWJ1dGVdKQorICBQR0FDX1BST0dfQ0NfQ0ZMQUdTX09QVChbLVdvbGQtc3R5bGUtZGVjbGFy YXRpb25dKQorICAjIC1Xb2xkLXN0eWxlLWRlY2xhcmF0aW9uIGlzIG5vdCBhcHBsaWNhYmxl IGZvciBDKysKIAogICAjIFRvIHJlcXVpcmUgZmFsbHRocm91Z2ggYXR0cmlidXRlIGFubm90 YXRpb25zLCB1c2UKICAgIyAtV2ltcGxpY2l0LWZhbGx0aHJvdWdoPTUgd2l0aCBnY2MgYW5k IC1XaW1wbGljaXQtZmFsbHRocm91Z2ggd2l0aApkaWZmIC0tZ2l0IGEvbWVzb24uYnVpbGQg Yi9tZXNvbi5idWlsZAppbmRleCBlYTMxY2JjZTljMC4uMGVlNzcyY2Q0NzUgMTAwNjQ0Ci0t LSBhL21lc29uLmJ1aWxkCisrKyBiL21lc29uLmJ1aWxkCkBAIC0yMTk4LDcgKzIxOTgsNiBA QCB2ZWN0b3JpemVfY2ZsYWdzID0gY2MuZ2V0X3N1cHBvcnRlZF9hcmd1bWVudHMoWyctZnRy ZWUtdmVjdG9yaXplJ10pCiB1bnJvbGxfbG9vcHNfY2ZsYWdzID0gY2MuZ2V0X3N1cHBvcnRl ZF9hcmd1bWVudHMoWyctZnVucm9sbC1sb29wcyddKQogCiBjb21tb25fd2FybmluZ19mbGFn cyA9IFsKLSAgJy1XbWlzc2luZy1wcm90b3R5cGVzJywKICAgJy1XcG9pbnRlci1hcml0aCcs CiAgICMgUmVhbGx5IGRvbid0IHdhbnQgVkxBcyB0byBiZSB1c2VkIGluIG91ciBkaWFsZWN0 IG9mIEMKICAgJy1XZXJyb3I9dmxhJywKQEAgLTIyMTEsNyArMjIxMCwxNSBAQCBjb21tb25f d2FybmluZ19mbGFncyA9IFsKICAgJy1XZm9ybWF0LXNlY3VyaXR5JywKIF0KIAotY2ZsYWdz X3dhcm4gKz0gY2MuZ2V0X3N1cHBvcnRlZF9hcmd1bWVudHMoY29tbW9uX3dhcm5pbmdfZmxh Z3MpCisjIEMtb25seSB3YXJuaW5ncworY193YXJuaW5nX2ZsYWdzID0gWworICAnLVdtaXNz aW5nLXByb3RvdHlwZXMnLAorICAnLVdvbGQtc3R5bGUtZGVjbGFyYXRpb24nLAorICAnLVdv bGQtc3R5bGUtZGVmaW5pdGlvbicsCisgICctV3N0cmljdC1wcm90b3R5cGVzJywKK10KKwor Y2ZsYWdzX3dhcm4gKz0gY2MuZ2V0X3N1cHBvcnRlZF9hcmd1bWVudHMoY29tbW9uX3dhcm5p bmdfZmxhZ3MsIGNfd2FybmluZ19mbGFncykKIGlmIGhhdmVfY3h4CiAgIGN4eGZsYWdzX3dh cm4gKz0gY3h4LmdldF9zdXBwb3J0ZWRfYXJndW1lbnRzKGNvbW1vbl93YXJuaW5nX2ZsYWdz KQogZW5kaWYKQEAgLTIyNTIsOSArMjI1OSw2IEBAIGlmIGNjLmhhc19hcmd1bWVudCgnLVdt aXNzaW5nLXZhcmlhYmxlLWRlY2xhcmF0aW9ucycpCiAgIGNmbGFnc19ub19taXNzaW5nX3Zh cl9kZWNscyArPSAnLVduby1taXNzaW5nLXZhcmlhYmxlLWRlY2xhcmF0aW9ucycKIGVuZGlm CiAKLSMgVGhlc2UgYXJlIEMtb25seSBmbGFncywgc3VwcG9ydGVkIGluIGFsbCBDMTEtY2Fw YWJsZSBHQ0MvQ2xhbmcgdmVyc2lvbnMuCi1jZmxhZ3Nfd2FybiArPSBjYy5nZXRfc3VwcG9y dGVkX2FyZ3VtZW50cyhbJy1Xc3RyaWN0LXByb3RvdHlwZXMnLCAnLVdvbGQtc3R5bGUtZGVm aW5pdGlvbiddKQotCiAjIFRoZSBmb2xsb3dpbmcgdGVzdHMgd2FudCB0byBzdXBwcmVzcyB2 YXJpb3VzIHVuaGVscGZ1bCB3YXJuaW5ncyBieSBhZGRpbmcKICMgLVduby1mb28gc3dpdGNo ZXMuICBCdXQgZ2NjIHdvbid0IGNvbXBsYWluIGFib3V0IHVucmVjb2duaXplZCAtV25vLWZv bwogIyBzd2l0Y2hlcywgc28gd2UgaGF2ZSB0byB0ZXN0IGZvciB0aGUgcG9zaXRpdmUgZm9y bSBhbmQgaWYgdGhhdCB3b3JrcywKLS0gCjIuNTMuMAoK --------------4HjMOLbpW0DjUmXaHwm83vq0--