Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jRI8D-0008K4-8o for pgsql-hackers@arkaria.postgresql.org; Wed, 22 Apr 2020 16:21:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jRI8C-0006nG-68 for pgsql-hackers@arkaria.postgresql.org; Wed, 22 Apr 2020 16:21:48 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jRI8B-0006mt-Vf for pgsql-hackers@lists.postgresql.org; Wed, 22 Apr 2020 16:21:47 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jRI88-0001Cu-ND for pgsql-hackers@postgresql.org; Wed, 22 Apr 2020 16:21:46 +0000 Received: from hnk.local (p2421237-ipbf2725funabasi.chiba.ocn.ne.jp [122.24.33.237]) by oss.nttdata.com (Postfix) with ESMTPSA id 67E496049D; Thu, 23 Apr 2020 01:21:40 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.102.2 at oss.nttdata.com Subject: Re: backup manifests From: Fujii Masao To: Robert Haas Cc: David Steele , Andres Freund , Noah Misch , Stephen Frost , Amit Kapila , Suraj Kharage , tushar , Rajkumar Raghuwanshi , Rushabh Lathia , Tels , Andrew Dunstan , PostgreSQL Hackers , Jeevan Chalke , vignesh C References: <20200330185944.42bxysvem6b757ew@alap3.anarazel.de> <20200402172318.3kvfrrewxmemzpia@alap3.anarazel.de> <20200402182346.6iffoadxu2hsbi2s@alap3.anarazel.de> <20200402194750.7ze74b4t6b6o4cui@alap3.anarazel.de> <78f76a3d-1a28-a97d-0394-5c96985dd1c0@oss.nttdata.com> <777d236e-f46c-8099-bb5e-a6e4efc43999@oss.nttdata.com> <01e3ed3a-8729-5aaa-ca84-e60e3ca59db8@oss.nttdata.com> <3286f87b-d396-1c35-1f49-463af10de637@oss.nttdata.com> Message-ID: Date: Thu, 23 Apr 2020 01:21:40 +0900 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <3286f87b-d396-1c35-1f49-463af10de637@oss.nttdata.com> Content-Type: multipart/mixed; boundary="------------3799AD354D32D5331592BEDA" Content-Language: en-US List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk This is a multi-part message in MIME format. --------------3799AD354D32D5331592BEDA Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 2020/04/15 11:18, Fujii Masao wrote: > > > On 2020/04/14 0:15, Robert Haas wrote: >> On Sun, Apr 12, 2020 at 10:09 PM Fujii Masao >> wrote: >>> I found other minor issues. >> >> I think these are all correct fixes. Thanks for the post-commit >> review, and sorry for this mistakes. > > Thanks for the review, Michael and Robert. Pushed the patches! I found three minor issues in pg_verifybackup. + {"print-parse-wal", no_argument, NULL, 'p'}, This is unused option, so this line should be removed. + printf(_(" -m, --manifest=PATH use specified path for manifest\n")); Typo: --manifest should be --manifest-path pg_verifybackup accepts --quiet option, but its usage() doesn't print any message for --quiet option. Attached is the patch that fixes those issues. Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION --------------3799AD354D32D5331592BEDA Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="pg_verifybackup_options_v1.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="pg_verifybackup_options_v1.patch" ZGlmZiAtLWdpdCBhL3NyYy9iaW4vcGdfdmVyaWZ5YmFja3VwL3BnX3ZlcmlmeWJhY2t1cC5j IGIvc3JjL2Jpbi9wZ192ZXJpZnliYWNrdXAvcGdfdmVyaWZ5YmFja3VwLmMKaW5kZXggOWMw YThjNTU1MC4uMzQwNzY1NTI2ZCAxMDA2NDQKLS0tIGEvc3JjL2Jpbi9wZ192ZXJpZnliYWNr dXAvcGdfdmVyaWZ5YmFja3VwLmMKKysrIGIvc3JjL2Jpbi9wZ192ZXJpZnliYWNrdXAvcGdf dmVyaWZ5YmFja3VwLmMKQEAgLTE2Miw3ICsxNjIsNiBAQCBtYWluKGludCBhcmdjLCBjaGFy ICoqYXJndikKIAkJeyJpZ25vcmUiLCByZXF1aXJlZF9hcmd1bWVudCwgTlVMTCwgJ2knfSwK IAkJeyJtYW5pZmVzdC1wYXRoIiwgcmVxdWlyZWRfYXJndW1lbnQsIE5VTEwsICdtJ30sCiAJ CXsibm8tcGFyc2Utd2FsIiwgbm9fYXJndW1lbnQsIE5VTEwsICduJ30sCi0JCXsicHJpbnQt cGFyc2Utd2FsIiwgbm9fYXJndW1lbnQsIE5VTEwsICdwJ30sCiAJCXsicXVpZXQiLCBub19h cmd1bWVudCwgTlVMTCwgJ3EnfSwKIAkJeyJza2lwLWNoZWNrc3VtcyIsIG5vX2FyZ3VtZW50 LCBOVUxMLCAncyd9LAogCQl7IndhbC1kaXJlY3RvcnkiLCByZXF1aXJlZF9hcmd1bWVudCwg TlVMTCwgJ3cnfSwKQEAgLTg5NCw4ICs4OTMsOSBAQCB1c2FnZSh2b2lkKQogCXByaW50Zihf KCJPcHRpb25zOlxuIikpOwogCXByaW50ZihfKCIgIC1lLCAtLWV4aXQtb24tZXJyb3IgICAg ICAgICBleGl0IGltbWVkaWF0ZWx5IG9uIGVycm9yXG4iKSk7CiAJcHJpbnRmKF8oIiAgLWks IC0taWdub3JlPVJFTEFUSVZFX1BBVEggIGlnbm9yZSBpbmRpY2F0ZWQgcGF0aFxuIikpOwot CXByaW50ZihfKCIgIC1tLCAtLW1hbmlmZXN0PVBBVEggICAgICAgICB1c2Ugc3BlY2lmaWVk IHBhdGggZm9yIG1hbmlmZXN0XG4iKSk7CisJcHJpbnRmKF8oIiAgLW0sIC0tbWFuaWZlc3Qt cGF0aD1QQVRIICAgIHVzZSBzcGVjaWZpZWQgcGF0aCBmb3IgbWFuaWZlc3RcbiIpKTsKIAlw cmludGYoXygiICAtbiwgLS1uby1wYXJzZS13YWwgICAgICAgICAgZG8gbm90IHRyeSB0byBw YXJzZSBXQUwgZmlsZXNcbiIpKTsKKwlwcmludGYoXygiICAtcSwgLS1xdWlldCAgICAgICAg ICAgICAgICAgZG8gbm90IHByaW50IGFueSBvdXRwdXQsIGV4Y2VwdCBmb3IgZXJyb3JzXG4i KSk7CiAJcHJpbnRmKF8oIiAgLXMsIC0tc2tpcC1jaGVja3N1bXMgICAgICAgIHNraXAgY2hl Y2tzdW0gdmVyaWZpY2F0aW9uXG4iKSk7CiAJcHJpbnRmKF8oIiAgLXcsIC0td2FsLWRpcmVj dG9yeT1QQVRIICAgIHVzZSBzcGVjaWZpZWQgcGF0aCBmb3IgV0FMIGZpbGVzXG4iKSk7CiAJ cHJpbnRmKF8oIiAgLVYsIC0tdmVyc2lvbiAgICAgICAgICAgICAgIG91dHB1dCB2ZXJzaW9u IGluZm9ybWF0aW9uLCB0aGVuIGV4aXRcbiIpKTsK --------------3799AD354D32D5331592BEDA--