Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vuQQp-0046uP-2X for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Feb 2026 07:32:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vuQQo-00CG8x-2H for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Feb 2026 07:32:38 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vuQQo-00CG8o-1K for pgsql-hackers@lists.postgresql.org; Mon, 23 Feb 2026 07:32:38 +0000 Received: from fhigh-a4-smtp.messagingengine.com ([103.168.172.155]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vuQQl-00000000lNi-1tYy for pgsql-hackers@postgresql.org; Mon, 23 Feb 2026 07:32:37 +0000 Received: from phl-compute-01.internal (phl-compute-01.internal [10.202.2.41]) by mailfhigh.phl.internal (Postfix) with ESMTP id DB55F1400019; Mon, 23 Feb 2026 02:32:35 -0500 (EST) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-01.internal (MEProxy); Mon, 23 Feb 2026 02:32:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eisentraut.org; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm2; t=1771831955; x=1771918355; bh=XcgrFTgHnOuUg6OFpAle7nbpxTybGewJ r+kuT+iJdMc=; b=W8CLQbGUOE6WJrmdX4+AlFFrHItDWlOVgygAmLLy91RkuN9y 9vD6Qbv1YOMx/z8P0O2kl77BJ7QjzVDeJGAXupcHguUCydtabUfNMCG4Zf2eYiC9 s3bbr42R6E0SGZRC5D4or/e6GhYJgEwsPVssfTABuRL194aH7RN1N9Qp92SejINn lFL/AC/RD0gObTp8W1+0tZJJDz6+FIRbiDLdXEUGN9nbBaB7xHPxmKt2dMkTGiiQ BAYB8XogxiarZ9mtazEtj5vgaCpMUk5meJVjDYb683qcqtfRIxmOyCogjAdmf8V2 wbDo1HwYvwVu8ZUoPqCms28Jgw8lPyhKlsmlyw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1771831955; x= 1771918355; bh=XcgrFTgHnOuUg6OFpAle7nbpxTybGewJr+kuT+iJdMc=; b=C /O6ThbjxPRhM6zwEklzV7LrWfWzVlA2h3lgcEjwoAnPj5ErcCSoeuPbs8GFuKvta jxOMnJsRRnV+vjQBliBBozYGvKhX3RyFgO0bm1ci78LV8Epjp7uJ8fnf1m0g1y9B V1AwsW2KqQDUlqnmjWiveULdrRzD1gQa50olaxOB2is/cnr2fP9+XWAo0eH9/DWV fzC9DU6Ku5knhNiSlocR4nIRyKmgBNtP+YX9WxDq/MaiH28aJhRl9ymsbXPwRyce Spi56nZMR6d+q40HZ8Tn6NULKFcfIbIzaJpROKDGgd09Dxkk9n7V1dbR/PjM5fuO BWEV5hPaT9+m/Y3ymG+Xw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgddvfeeiieefucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucenucfjughrpefkffggfgfuhffvvehfjggtgfesthekre dttddvjeenucfhrhhomheprfgvthgvrhcugfhishgvnhhtrhgruhhtuceophgvthgvrhes vghishgvnhhtrhgruhhtrdhorhhgqeenucggtffrrghtthgvrhhnpedvjeeihffhvdefhe evleekveeujefhieduueeljeekieejieegfefhtdfhleejgeenucevlhhushhtvghrufhi iigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehpvghtvghrsegvihhsvghnthhrrg huthdrohhrghdpnhgspghrtghpthhtohepvddpmhhouggvpehsmhhtphhouhhtpdhrtghp thhtohepphhoshhtghhrvghssehjvghlthgvfhdrnhhlpdhrtghpthhtohepphhgshhqlh dqhhgrtghkvghrshesphhoshhtghhrvghsqhhlrdhorhhg X-ME-Proxy: Feedback-ID: ie0a040ee:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 23 Feb 2026 02:32:34 -0500 (EST) Message-ID: Date: Mon, 23 Feb 2026 08:32:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: enable fallthrough warnings on clang From: Peter Eisentraut To: Jelte Fennema-Nio Cc: pgsql-hackers References: <76a8efcd-925a-4eaf-bdd1-d972cd1a32ff@eisentraut.org> <955ddaa3-d6e8-4d87-a368-ef9f25960d4e@eisentraut.org> Content-Language: en-US In-Reply-To: <955ddaa3-d6e8-4d87-a368-ef9f25960d4e@eisentraut.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 21.01.26 12:34, Peter Eisentraut wrote: > On 20.01.26 16:03, Jelte Fennema-Nio wrote: >> On Tue, 20 Jan 2026 at 12:16, Peter Eisentraut >> wrote: >>> So my proposal is that we wrap the appropriate attribute into a >>> pg_fallthrough macro, and replace the current comments with that. >> >> All looks okay to me. The only thing that stood out is that it checks >> for C++ with __cpp_attributes instead of __cplusplus. Is it really >> worth using this more specific attribute? Given that we're already >> requiring C++11 and afaict all C++11 compilers should support the >> general notion of attributes. > > I agree.  I will make that change. I have committed this patch set. I also added a test into the C++ module.