Message-ID: <ffe496e6-11ba-6f60-1621-90a600335cec@enterprisedb.com>
Date: Wed, 23 Feb 2022 23:53:17 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.0
Subject: Re: convert libpq uri-regress tests to tap test
Content-Language: en-US
To: Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org
References: <20220223203031.ezrd73ohvjgfksow@alap3.anarazel.de>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <20220223203031.ezrd73ohvjgfksow@alap3.anarazel.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/ffe496e6-11ba-6f60-1621-90a600335cec%40enterprisedb.com>
Precedence: bulk

On 23.02.22 21:30, Andres Freund wrote:
> hen verifying that the meson port actually runs all perl based tests I came
> across src/interfaces/libpq/test/regress.pl.  Instead of running tests yet
> another way, it seems better to convert it to a tap test.
> 
> I hope others agree?
> 
> Where would we want that test to live? Right now we have the slightly odd
> convention that some tap tests live in src/test/{misc,modules,...}. But
> e.g. frontend binary ones are below src/bin/.

libpq TAP tests should be in src/interfaces/libpq/t/.

I think there were issues that the build farm wouldn't pick up a test 
located there, but that should be fixed rather than worked around.