Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rYB9o-00EkAz-Ie for pgsql-hackers@arkaria.postgresql.org; Thu, 08 Feb 2024 20:38:05 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rYB9n-0031FL-OJ for pgsql-hackers@arkaria.postgresql.org; Thu, 08 Feb 2024 20:38:03 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rYB9n-0031FC-D5 for pgsql-hackers@lists.postgresql.org; Thu, 08 Feb 2024 20:38:03 +0000 Received: from mout-u-204.mailbox.org ([80.241.59.204]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rYB9l-006BYZ-3w for pgsql-hackers@postgresql.org; Thu, 08 Feb 2024 20:38:02 +0000 Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:b231:465::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-204.mailbox.org (Postfix) with ESMTPS id 4TW81x5DB4z9sS6; Thu, 8 Feb 2024 21:37:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ewie.name; s=MBO0001; t=1707424677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=z6umiAnE86+xP7yNVTObXl9emKlnP1GmWdMKpA3IMNo=; b=rPgagMgOnu0v1C646s+1N6oz+GsmO7VKEntLZQsXWKfglJ+BiA0b2oHYl0d+yxTpMdcixe qtyAq+WX7gisHPZMzdlIsLC2APn7q5e1mWklu9mdrpgpfBSXtB/EsBWE3kAq2g2kiqsli1 /xgKBYITkRS8FUZ/PTUtWwtB0i+QPohDOAKnCzwvSHya8f2kiwk9hORzRhGy1tqY3Yf/eY onmXTW7QKFgZIah0Rqe67dtu1LH0hcahhkfMpCTv6l7sfPv1Cpw2ts8qDEi8r+zc+oXzhL 9/uFtx+TfFWMO+XD+RQURgJ7BhFR3APnUQovoMA53pM+v68LISw207H7rXzNsA== Date: Thu, 8 Feb 2024 21:37:54 +0100 From: Erik Wienhold To: Jim Jones Cc: Maiquel Grassi , Pavel Luzanov , Nathan Bossart , "pgsql-hackers@postgresql.org" Subject: Re: Psql meta-command conninfo+ Message-ID: References: <20240206215022.GA3452@nathanxps13> <852cabef-f596-4826-9a54-d3f75d9a6cc8@postgrespro.ru> <47dcfd6f-d1d8-4a13-9bc5-b43ee9bd534f@uni-muenster.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4TW81x5DB4z9sS6 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2024-02-08 20:37 +0100, Jim Jones wrote: > One thing I just noticed. The psql autocomplete feature does not suggest > the new + option of \conninfo. For instance, when typing "\connin[TAB]" > it automatically autocompletes to "\conninfo ". I guess it should also > be included in this patch. Modifiers such as + or S in \dS are not covered by autocompletion. src/bin/psql/tab-complete.c only specifies backslash commands in their basic form (without modifiers). (\dS actually autocompletes to \ds to my surprise) > I can do a more thorough review of the code when you add the > documentation and tests to the patch. I noticed that the pattern parameter in listConnectionInformation is unused. exec_command_conninfo scans the pattern but \conninfo should not accept any argument. So the pattern can be removed entirely. -- Erik