public inbox for [email protected]  

help / color / mirror / Atom feed

From: Andres Freund <[email protected]>
To: Tomas Vondra <[email protected]>
Cc: [email protected]
Cc: Dilip Kumar <[email protected]>
Cc: Jelte Fennema-Nio <[email protected]>
Cc: Thomas Munro <[email protected]>
Cc: Noah Misch <[email protected]>
Subject: Re: Test timings are increasing too fast for cfbot
Date: Wed, 25 Mar 2026 12:13:08 -0400
Message-ID: <ggrz726w3y2umzgrfybvbemkfkeedyjspikzlfnifyw4rvd3oz@inhcgrbasohs> (raw)
In-Reply-To: <[email protected]>
References: <mtkrkkcn2tlhytumitpch5ubxiprv2jzvprf5r5m3mjeczvq4q@p6wkzbfxuyv2>
	<ogohyk54vjyejn3kdibrc73wcrdhwsq57fawxitycen6ntbzo3@gnnwuagu2qqj>
	<[email protected]>

Hi,

On 2026-03-25 15:38:01 +0100, Tomas Vondra wrote:
> On 3/25/26 04:15, Andres Freund wrote:
> > ...
> > 
> > The slowest test is stats_ext.sql - Not surprising, it does sequential scans
> > of tables with ~1000-10000 rows over and over again.  I don't see why it has
> > to do that with as many rows as it does.
> > 
> 
> IIRC we needed to use non-trivial amounts of data to ensure building the
> right right type of statistics (e.g. no MCV). But I understand it can be
> annoyingly expensive, so I'll try to make it cheaper.

Great.  It might also be worth checking if any of the query conditions can be
made cheaper without actually changing what they do test.


> >  ...
> > 2) AssertCheckRanges() (only in the brin test, but there a very large portion
> >    of the runtime)
> 
> True. It is a very comprehensive validation of the ranges, and it was
> very useful - particularly during development. But I'll try to make it
> more targeted at the stuff actually changed / called less often.

Makes sense.  There might also be some changs that make it faster without
loosing any coverage. E.g. not using FunctionCall2Coll() - which initializes
stuff on every call - but doing InitFunctionCallInfoData() once and then
update arguments + FunctionCallInvoke() for each call.


> Both changes will require time (so that we don't lose test coverage),
> but I assume it's OK if that happens sometime after the feature freeze.

Yea. We're not running out of credits tomorrow or something like that.

Greetings,

Andres Freund

view thread (9+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Test timings are increasing too fast for cfbot
  In-Reply-To: <ggrz726w3y2umzgrfybvbemkfkeedyjspikzlfnifyw4rvd3oz@inhcgrbasohs>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox