Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w8OvJ-000Uib-2E for pgsql-hackers@arkaria.postgresql.org; Thu, 02 Apr 2026 20:45:54 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1w8OuH-007zBW-1H for pgsql-hackers@arkaria.postgresql.org; Thu, 02 Apr 2026 20:44:49 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w8OuG-007zBO-1G for pgsql-hackers@lists.postgresql.org; Thu, 02 Apr 2026 20:44:49 +0000 Received: from fout-b4-smtp.messagingengine.com ([202.12.124.147]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1w8OuD-00000000G7p-0E46 for pgsql-hackers@lists.postgresql.org; Thu, 02 Apr 2026 20:44:48 +0000 Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfout.stl.internal (Postfix) with ESMTP id 78AC01D000EA; Thu, 2 Apr 2026 16:44:42 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-04.internal (MEProxy); Thu, 02 Apr 2026 16:44:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1775162682; x=1775249082; bh=BeGfYjxZrQWiimlfkg3boN8jEXiMHzk9UBt3V7E8dOQ=; b= VD3iijv7bSYByh9TsxjbaeTk+5/vYULazayDnMqXTn9FoJrdDAjTEK6lM2WrzG2Q QiH0HSMSQEy3Aes0asuRQzpi4f6X8+39rVc02KfLidvi1gnC8FMJpgbDt1wISA0X 5vBkCCVC6kWapASRtsPVIkOiv7sWJSvdRhjthukPj/D4tfTiCOV9GB2XdGfMz4GE d38qHB7exmfwTRLvKYTS2xPH7rvSyKGln6Rcb3uI/496ZeE3r9SIUriqUOdu56rb LNvcaKQeGqfM4pJ/3Gu6U9td2/rRCeuKlTyoLOzThkK8lSaYxLXm3q6rDumJvyr8 DhhQ8HzkWgogkZQ2NrOtJg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1775162682; x= 1775249082; bh=BeGfYjxZrQWiimlfkg3boN8jEXiMHzk9UBt3V7E8dOQ=; b=W SP0+qbIG/no/FS+ImonYarS9NjMFEsN0q3qGWiuTETOXkIp7SO0WMLNFvRQYLV+q hJsaXVldXHPCF+1LXxDhrOc1QaGk+NEqo5aKYIG9vW/Qy9Lmxz1kuLFX2IcXyttY YIxiYPWH5+BTztiqSwV6N1od8Uc8saD1Lr5+iBqgpDu/jmlD1EzzIsnluC9+wtJV L4ByHk/3yYGXDHlm0OqsfALf91ZxMUMZ+TJ5BBlSr2ycjYQwJTToT3Rb5OaVRwhk 0zUL8jfAnyal6WivowC0DPI0IpyRCwa+KSKIKP02A9J4dWlAVY3JhtPCnygnxPp1 z2J9VMKEyTdCQdqb0tcIA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgdejtddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurh epfffhvfevuffkfhggtggugfgjsehtkefstddttddunecuhfhrohhmpeetnhgurhgvshcu hfhrvghunhguuceorghnughrvghssegrnhgrrhgriigvlhdruggvqeenucggtffrrghtth gvrhhnpeehvdefffdujeevlefgheekueeuueevgfethfeivdffkeeufeehueeufeeiteeu geenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrnh gurhgvshesrghnrghrrgiivghlrdguvgdpnhgspghrtghpthhtohepvddpmhhouggvpehs mhhtphhouhhtpdhrtghpthhtoheprghlvhhhvghrrhgvsehkuhhrihhlvghmuhdruggvpd hrtghpthhtohepphhgshhqlhdqhhgrtghkvghrsheslhhishhtshdrphhoshhtghhrvghs qhhlrdhorhhg X-ME-Proxy: Feedback-ID: id4a34324:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 2 Apr 2026 16:44:41 -0400 (EDT) Date: Thu, 2 Apr 2026 16:44:41 -0400 From: Andres Freund To: =?utf-8?Q?=C3=81lvaro?= Herrera Cc: Pg Hackers Subject: Re: some more include removal from headers Message-ID: References: <202604021754.6becsqczyjci@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <202604021754.6becsqczyjci@alvherre.pgsql> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2026-04-02 20:24:29 +0200, Álvaro Herrera wrote: > On 2026-Apr-02, Andres Freund wrote: > > After the attached patches, a change to bufmgr.h triggers rebuilding 213 > > files, before it was 323. Not perfect, but better. > > > > Would be nice to get rid of the bufmgr.h includes in access/nbtree.h and such, > > but it looks like that'd be a bit more work. > > > > I included your catalog/publication.h in it, as my version had surprisingly > > extensive bitrot... > > I ran each patch individually under headerscheck and a full tree > compile; they all pass for me. Also, each change is sensible on its own. > > Looking at what else includes bufmgr.h, I think the minimum it can > reduced to is compiling 157 files when you change bufmgr.h, per the > patches attached here. Most of them are direct inclusions, so reducing > further is tough. The only one we could blame is xlogutils.h, but it > needs the ReadBufferMode enum, so in order to do better, we'd have to > split bufmgr.h in two. I think you may have forgotten to attach the changes? Greetings, Andres Freund