Feedback-ID: id4a34324:Fastmail
Date: Fri, 20 Feb 2026 11:02:49 -0500
From: Andres Freund <andres@anarazel.de>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>, Jeff Davis <pgsql@j-davis.com>, 
	Greg Sabino Mullane <htamfids@gmail.com>, pgsql-hackers@lists.postgresql.org
Subject: Re: Adding locks statistics
Message-ID: <isi5wszczhusgjetxwe6khxa5mbm5jms3msmbhwl73jktxw7ic@3mympoumua76>
References: <aYreqqn3meYqPm1A@ip-10-97-1-34.eu-west-3.compute.internal>
 <aY7UmTIiBScP4rAq@paquier.xyz>
 <aY779Gu3rQwJ4Erq@ip-10-97-1-34.eu-west-3.compute.internal>
 <aY-MRFnzTDJO265s@alap3.anarazel.de>
 <aZLtDbGEqSN2MuRb@ip-10-97-1-34.eu-west-3.compute.internal>
 <otjn7ykaezlueayyp7fppggkldw23ykh3i6ite2rqq4xh7dwvl@w5dvqqgvqf25>
 <aZSYcsRmqh7grqJb@ip-10-97-1-34.eu-west-3.compute.internal>
 <aZaMXK90sRjSQBJP@paquier.xyz>
 <v76tz252usppu2turrn6wxiyyxmybzxhqck5b3amtsbzrc6yto@n26qnwvpkxqw>
 <aZgBTyzxWmPJL0Tt@ip-10-97-1-34.eu-west-3.compute.internal>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <aZgBTyzxWmPJL0Tt@ip-10-97-1-34.eu-west-3.compute.internal>
Archived-At: <https://www.postgresql.org/message-id/isi5wszczhusgjetxwe6khxa5mbm5jms3msmbhwl73jktxw7ic%403mympoumua76>
Precedence: bulk

Hi,

On 2026-02-20 06:38:07 +0000, Bertrand Drouvot wrote:
> > If the delay is very
> > short it's probably also not that interesting to track, but I guess that's
> > debatable.
> 
> v6 was introducing timed_waits so that we have:
> 
> waits
> timed_waits
> wait_time
> fastpath_exceeded
> 
> timed_waits and wait_time were incremented together and waits was incremented
> unconditionally. I like the idea of being able to track the numbers of waits
> whatever the value of log_lock_waits (or the new track_lock_timing) is. Also
> one could compare waits vs timed_waits.

How could a user benefit from that split? To me this is pointless number
gathering that wastes resources and confuses users.

Seriously, youre introducing stats left and right, you really need to stop and
first carefully think about what those stats could possibly be useful
for. Before writing a patch implementing the stats.

Greetings,

Andres Freund