Date: Fri, 9 Aug 2024 16:29:48 +0200
From: Dmitry Dolgov <9erthalion6@gmail.com>
To: Stefan Fercot <stefan.fercot@dataegret.com>
Cc: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Subject: Re: Recovery of .partial WAL segments
Message-ID: <jj4b3wolr7gt3rjjvv7yw2luv5kho7s4t5sizwoq4vjbdsxvce@twycelwxpdxq>
References: <PUrgXj3toL_CVxytc7fzYQNlY5FiUllklbS9UL1wU5ptiJAC2ChrF64EwO8neCKU9QnET5Zjv1HpMLFAgQPJQxOzM9f49jjkV56gEpUOYw8=@protonmail.com>
 <CAPzjO7U4oM8pkLOPrMq=ugWHqjfo-a1hdm6rd2Y+y+Xqt_Tkdw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAPzjO7U4oM8pkLOPrMq=ugWHqjfo-a1hdm6rd2Y+y+Xqt_Tkdw@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/jj4b3wolr7gt3rjjvv7yw2luv5kho7s4t5sizwoq4vjbdsxvce%40twycelwxpdxq>
Precedence: bulk

> On Fri, Aug 02, 2024 at 08:47:02AM GMT, Stefan Fercot wrote:
>
> Not sure why CFbot CI fails on macOS/Windows while it works with the Github
> CI on my fork (
> https://cirrus-ci.com/github/pgstef/postgres/partial-walseg-recovery).

I guess it's because the test has to wait a bit after the node has been
started until the log lines will appear. One can see it in the
node_pitr3 logs, first it was hit by

    SELECT pg_is_in_recovery() = 'f'

and only some moments later produced

    restored log file "000000010000000000000003.partial" from archive

where the test has those operations in reversed order. Seems like the
retry loop from 019_replslot_limit might help.