From: Robbie Harwood <rharwood@redhat.com>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH v11] GSSAPI encryption support
In-Reply-To: 
 <CAB7nPqSwnVLci7mZ89K+oNig7QHTi9MLxYnefOmgM=Vpro96ag@mail.gmail.com>
References: <jlg1tgq1ktm.fsf@thriss.redhat.com>
 <jlgh9fl3qlr.fsf@thriss.redhat.com>
 <CAB7nPqSwnVLci7mZ89K+oNig7QHTi9MLxYnefOmgM=Vpro96ag@mail.gmail.com>
User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1
 (x86_64-pc-linux-gnu)
Date: Mon, 04 Apr 2016 16:15:19 -0400
Message-ID: <jlgh9fht9k8.fsf@thriss.redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

--=-=-=
Content-Type: text/plain

Michael Paquier <michael.paquier@gmail.com> writes:

> On Sat, Apr 2, 2016 at 7:34 AM, Robbie Harwood <rharwood@redhat.com> wrote:
>
>>   Since I still can't reproduce this locally (left a client machine and
>>   a process on the same machine retrying for over an hour on your test
>>   case and didn't see it), could you provide me with some more
>>   information on why repalloc is complaining?
>>   Is this a low memory situation where alloc might have failed?
>
> No, this is an assertion failure, and it seems that you are compiling
> this code without --enable-cassert, without the switch the code
> actually works.

You are right.  I now see the assertion failure.

>>   That pointer looks like it's on the heap, is that correct?
>
> appendBinaryStringInfo depends on palloc calls that allocate memory
> depending on the memory context used. It looks that what's just
> missing in your logic is a private memory context that be_gssapi_write
> and be_gssapi_read can use to handle the allocation of the
> communication buffers.

Thank you very much for the pointer!  I will work in memory context
management for the next version.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJXAstYAAoJECUy+RdqlaRCM/gP+wdNnhxuajjqORoiRMRQWxtg
NxHkBi4n363YFfHXbMdr9Ei7p7RdOOWyCQYanLsK2jptAYfubTIK3noqlr52PSel
qIwUFZTM8vxtLJDUdLDhFqzCcg0m44s5Qug4AvSURhjE6Heb1RIEi2vNJNr1XQe8
Pszqxffw884jN1t9LQHN2XAF9Zf2sbZQrCizvqWinz6B6AmHNF6xYhjMPJEthnHm
BF6ERKG/ydA1AK5XHPYTfF4MaL19hMRf6KvBP9dkRnPZory38HRmkV1YFv97o9WG
0m8XTlcwlDB/FFHdr0i7dI3Bid0MCqRluJ8jCKE/BV2atke5BsFJ8yJ76ADjgAD/
+rWm71G9U3wVHh0xW52LdQ0bWMSET79Wi3adPuKInVO+wK5WFKMU6paxXI9RzKyN
72lC4PWLUS2XA4IPLleZbLeJsVPa519W97XHkzhwAU4FFNlWx2HpVT9pCthp6vPj
ojwmmGLq+kSxILmKAj3I7tDRz7rvSSWXgDFCwZxqx1dYNP0L3TAEXcQ67Wdf4HRe
4WOI2QADJOj7H+BiErtbdn2qDC6veB8Vstyj62/TMTU4msd8U476FHdGw1XZDed8
XgMnwzpbSozFxLu/uVXOFjWt0++R/s9mvntUdu3jASKrZryKI4v2FSl1t36bRc49
ZFh3RXhyTbVJkzyxyWuj
=rwcp
-----END PGP SIGNATURE-----
--=-=-=--