From: Robbie Harwood <rharwood@redhat.com>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH v4] GSSAPI encryption support
In-Reply-To: 
 <CAB7nPqS+zyHHE61cxy_DQnFL_Nk2N6V1w1E07bg53shm1++p-w@mail.gmail.com>
References: <jlg1tgq1ktm.fsf@thriss.redhat.com>
 <jlg4mdg8ebw.fsf@thriss.redhat.com>
 <CAB7nPqS+zyHHE61cxy_DQnFL_Nk2N6V1w1E07bg53shm1++p-w@mail.gmail.com>
User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1
 (x86_64-pc-linux-gnu)
Date: Thu, 11 Feb 2016 13:56:06 -0500
Message-ID: <jlglh6r5b5l.fsf@thriss.redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

--=-=-=
Content-Type: text/plain

Michael Paquier <michael.paquier@gmail.com> writes:

> On Thu, Feb 11, 2016 at 6:06 AM, Robbie Harwood <rharwood@redhat.com> wrote:
>>
>> - The GSSAPI authentication code has been moved without modification.
>>   In doing so, the temptation to modify it (flags, error checking, that
>>   big comment at the top about things from Athena, etc.)  is very large.
>>   I do not know whether these changes are best suited to another patch
>>   in this series or should be reviewed separately.  I am also hesitant
>>   to add things beyond the core before I am told this is the right
>>   approach.
>
> I would recommend a different patch if code needs to be moved around.
> The move may make sense taken as an independent piece of the
> integration.

Sorry, are you suggesting separate patch for moving the GSS auth code,
or separate patch for changes to said code?  I am happy to move it if
so, just want to be sure.

> + * Portions Copyright (c) 2015-2016, Red Hat, Inc.
> + * Portions Copyright (c) 1996-2016, PostgreSQL Global Development Group
> I think that this part may be a problem... Not sure the feeling of the
> others regarding additional copyright notices.

Good catch.  That's an accident (force of habit).  Since I'm pretty sure
this version won't be merged anyway, I'll drop it from the next one.

> It would be good to add that to the next CF, I will be happy to get a
> look at it.

Sounds good.  Thanks for looking at it!

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJWvNlJAAoJECUy+RdqlaRC1lIP/2oHv+YLJkBP+vc+wOOdgevr
eXlUwMxIjd9l5H3NIvsQaHaV1qL98fWQX7v2HF5UwfEnH+8hed59BqJ2cP1oTq9P
kaSWEqdrv8xBI2c0d+TTBU30IeOtNyP138+plWlfM19miFcbOM6lpLGiCaxZYRFA
55kjzofAuPs5MV2K6Y5Hcdjtn3BpVvPCHfexdXNjE9KxlYYYqPcFyC38L7StHadp
p11Lmf3MoWLGhWz8y3j/FiOugpOjlaYsBFI0Rpr0z1rtthsALerfNbSXcCqi5kfl
5ognellL3PycOaKRC5iEcGsV7iVnmpkYJhFRFitxPpmL297JIZGiu/N9t6dAozUn
8k8ixn9owxmc/5eGVHzOdKlyt2EuHbU0JGUmsTaIOkEo5dYbKv+VE9X3ijpN1y9f
hsIDeqD+aTzJeJRSuqbgZwPzFzWNjg+HW81pjv29vhkoYR6kKGmJtNukJNVH60eg
MXlEaQHoNOkSO9UzojE5nM+3RadGlp+f7ORdhXKQ97zLxbDB/iSZHrwFRTduorYM
Pg3caC1RYnJFD0mJalt2WS5AGofrQgeSsVxY5moSsHUKjnchBX60PmKCViukDG2a
+IEOFt3gfOD7hNp1SYf+A0mjC7cffKJbFKbaF3jBjamTG/5iPfS5V2KD1xLRng6/
yw85/Y5b94kQO9HkVBJI
=1kRo
-----END PGP SIGNATURE-----
--=-=-=--