From: Robbie Harwood <rharwood@redhat.com>
To: Stephen Frost <sfrost@snowman.net>
Cc: Michael Paquier <michael.paquier@gmail.com>,
        David Steele <david@pgmasters.net>,
        Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH v6] GSSAPI encryption support
In-Reply-To: <20160315195436.GE3127@tamriel.snowman.net>
References: <jlg1tgq1ktm.fsf@thriss.redhat.com>
 <jlgegbkmvxl.fsf@thriss.redhat.com> <56E81852.1060005@pgmasters.net>
 <CAB7nPqTjnLWBOepE+Oy5WZBjcq7sRJ9_uKvvXuThst9dvBxkZQ@mail.gmail.com>
 <jlgtwk7il5x.fsf@thriss.redhat.com>
 <20160315195436.GE3127@tamriel.snowman.net>
User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1
 (x86_64-pc-linux-gnu)
Date: Tue, 15 Mar 2016 16:35:26 -0400
Message-ID: <jlgr3fbiinl.fsf@thriss.redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Stephen Frost <sfrost@snowman.net> writes:

> Robbie,
>
> * Robbie Harwood (rharwood@redhat.com) wrote:
>> Michael Paquier <michael.paquier@gmail.com> writes:
>> > -       maj_stat =3D gss_accept_sec_context(
>> > -                                         &min_stat,
>> > +       maj_stat =3D gss_accept_sec_context(&min_stat,
>> >
>> > This is just noise.
>>=20
>> You're not wrong, though I do think it makes the code more readable by
>> enforcing style and this is a "cleanup" commit.  I'll take it out if it
>> bothers you.
>
> First, thanks much for working on this, I've been following along the
> discussions and hope to be able to help move it to commit, once it's
> ready.
>
> Secondly, generally, speaking, we prefer that 'cleanup' type changes
> (particularly whitespace-only ones) are in independent commits which are
> marked as just whitespace/indentation changes.  We have a number of
> organizations which follow our code changes and it makes it more
> difficult on them to include whitespace/indentation changes with code
> changes.

Thanks for the clarification.  I'll be sure to take it out!

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJW6HIPAAoJECUy+RdqlaRCs8UP/ioKodeymuiE8xMn4NOys9Y4
BkRjBfCYw21IcXQlUTumO3rkUO6AUWyTgcFh6U6I/27F+q8uTMZo+Fgjc/zTOQks
iGDQhyfloPUS49l9YlAUrXYmA0EznYTu0lPgJSydPH0JIavXqehqjAcC8jYHEGzB
EYD8CKKojT+LlKTrNfTe8MLbZwRZKWO1W/S/bNob9+UrNUbQUesMsLt2Ge59a14X
/rCvrg3htHNtyIHwjJ7qiduhDnhaErTsGjqjID0pzjQS2Gp5QTVNig36lFs9okiA
/YaGxap8GPzLlh4sKReStWsZSv1G0RigFNvC7lnmTHmLCewGGk+XxRfdMmonnu+N
q6KghJ5NkUKWT/Rerz6DnJQgQQmIieQdE5MhOETLkBfp2DcY3tPSIAousYEsscdy
brW7ebzduwESALWeEGUlqD8D8ZVmeoLgqR6bH9e8atQmJuO8pia5g0GC4PavnxjL
3WLcXUt/ZtdVRr2y1ruFu0c6T7SsmeciWNRK0afYG+gaB0iUMnZ/wXTV1/k4MNhh
GuET6gWXjNeGzBSvXVy4ccUW+rqFq443yBTSaEqfqNIcKL60hEK8copuFIARnoGT
0Ze0XnlDgeLV0MFjQkbrJ3ZVdootEyRd6ojstWet/jNf8gPpRydf5UeTJzEt1OD4
Sg2k56yJhx7+AC1Kkdxb
=QeQh
-----END PGP SIGNATURE-----
--=-=-=--