Date: Mon, 6 Apr 2026 15:05:37 +0200
From: Dmitry Dolgov <9erthalion6@gmail.com>
To: Haibo Yan <tristan.yim@gmail.com>
Cc: David Rowley <dgrowleyml@gmail.com>, Andy Fan <zhihuifan1213@163.com>,
	Peter Eisentraut <peter@eisentraut.org>,
 Amit Langote <amitlangote09@gmail.com>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
 jian he <jian.universality@gmail.com>,
	Chapman Flack <chap@anastigmatix.net>, pgsql-hackers@lists.postgresql.org
Subject: Re: Extract numeric filed in JSONB more effectively
Message-ID: <l6mh4jmhbmdxgoqbpcjuxa5x27age7h5xtrqzpe5sjg7sjmrsa@4g7wv4zw5o5i>
References: <875xx197bp.fsf@163.com>
 <87ttk0lgcx.fsf@163.com>
 <CAApHDvqnUONCN54dAXdH678ELK7aH2gyVhh0GjTRtrexPd9YMw@mail.gmail.com>
 <8734m5fua1.fsf@163.com>
 <mmilfltxeqgajpi4zok2v2moudot6bhdmwsqgjgnymz3nvkvng@k3caignaldcp>
 <87a5dx4cfb.fsf@163.com>
 <cudr6wao4hz2otlycx2z2equkigbjxslxvzqb3ejfc4amroheo@frqbvffcgqnu>
 <7487A577-7BDC-4B94-9FFA-741E95439BFC@gmail.com>
 <CAApHDvozyjc8Qety7_aWeLaiNWGs59vBSoDNrNzXGgXbjL85NQ@mail.gmail.com>
 <40442A5A-C7BF-4742-9F88-1068686EC174@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <40442A5A-C7BF-4742-9F88-1068686EC174@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/l6mh4jmhbmdxgoqbpcjuxa5x27age7h5xtrqzpe5sjg7sjmrsa%404g7wv4zw5o5i>
Precedence: bulk

> On Fri, Apr 03, 2026 at 09:42:20AM -0700, Haibo Yan wrote:

Thanks for picking it up, the patch looks good.

> One small thing: the UI looks a bit odd on my side. It does not seem to have picked my attachment, and is instead showing your older attachment there. But cfbot appears to have picked up mine, so I think it may just be a UI issue.

It takes some time, as far as I can see currently the correct patch is shown.

> +		/*
> +		 * Identify the inner extraction expression.  It may appear as
> +		 * either a FuncExpr or an OpExpr; accept both forms.
> +		 */
> +		if (IsA(arg, FuncExpr))
> +		{
> +			FuncExpr   *inner = (FuncExpr *) arg;
> +
> +			inner_funcid = inner->funcid;
> +			inner_args = inner->args;
> +			location = inner->location;
> +		}
> +		else if (IsA(arg, OpExpr))
> +		{
> +			OpExpr	   *inner = (OpExpr *) arg;
> +
> +			inner_funcid = inner->opfuncid;
> +			inner_args = inner->args;
> +			location = inner->location;
> +		}
> +		else
> +			PG_RETURN_POINTER(NULL);

It may also appear as a SubscriptingRef expression if we use subscription over
jsonb.

	SELECT test_json['field7']::bool FROM test_jsonb WHERE json_type = 'object';

Seems to be worth handling this case as well, since it doesn't lead to an
interface explosion.